Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Hudson » Review hudson-code pull request which modifies scm polling behaviour
icon10.gif  Review hudson-code pull request which modifies scm polling behaviour [message #1404749] Tue, 05 August 2014 13:35 Go to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 37
Registered: October 2013
Member
This fixes our bug that polling did not detect any changes - when job is assigned to one slave, slave is online, but on slave there is no workspace directory for job (ex. it was manually deleted).

Please review this pull request:
https://github.com/eclipse/hudson.core/pull/1
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1404750 is a reply to message #1404749] Tue, 05 August 2014 13:40 Go to previous messageGo to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 37
Registered: October 2013
Member
Bug reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=441181
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1404783 is a reply to message #1404750] Tue, 05 August 2014 17:32 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 469
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Hi Lukaz, thanks for the pull request. Seems https://github.com/eclipse/hudson.core is a read only one-way mirror of Eclipe git. So, I'm not sure if there is a way to merge your changes back to https://git.eclipse.org/c/hudson/org.eclipse.hudson.core.git/ from Github.

Non Eclipse committers contribute through Gerrit as explained here

https://wiki.eclipse.org/Hudson-ci/development#Submitting_a_Patch_for_Non-Committers

Do you mind submit your changes via Gerrit?







Winston Prakash
Eclipse Hudson team
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1404923 is a reply to message #1404783] Wed, 06 August 2014 06:48 Go to previous messageGo to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 37
Registered: October 2013
Member
Winston, there is a way to merge my changes - just add my github repo (https://github.com/ljader/hudson.core/) as an another remote to your hudson.core local clone, fetch the remote, cherry-pick my commit and after review push it to main repo.
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1405137 is a reply to message #1404923] Wed, 06 August 2014 17:09 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 469
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Because of Eclipse CLA requirements that is not allowed. When I push it will be blocked (see below).

wjprakash@seaview:org.eclipse.hudson.core-review$ git push
Counting objects: 87, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 941 bytes | 0 bytes/s, done.
Total 9 (delta 7), reused 0 (delta 0)
remote: Resolving deltas: 100% (7/7)
remote: Processing changes: refs: 1, done    
remote: ----------
remote: Reviewing commit: 29fa3a55
remote: Authored by: Łukasz Jąder <ljaderdev@gmail.com>
remote: 
remote: error: The author does not have a Gerrit account.
remote: All authors must either be a commiter on the project, or have a current CLA on file.
remote: Please see http://wiki.eclipse.org/CLA
remote: 
To ssh://wprakash@git.eclipse.org:29418/hudson/org.eclipse.hudson.core.git
 ! [remote rejected] master -> master (The author must register with Gerrit.)
error: failed to push some refs to 'ssh://wprakash@git.eclipse.org:29418/hudson/org.eclipse.hudson.core.git'


Winston Prakash
Eclipse Hudson team
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1405358 is a reply to message #1405137] Thu, 07 August 2014 07:03 Go to previous messageGo to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 37
Registered: October 2013
Member
Winston, so test if this change does not break anything and if its ok push it as yourself - its just one line and I dont mind Smile
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1405567 is a reply to message #1405358] Thu, 07 August 2014 16:57 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 469
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Lukaz, sure, but I want you to be listed as the contributor Smile. I want to see more core contributors listed here https://projects.eclipse.org/projects/technology.hudson/who

Winston Prakash
Eclipse Hudson team
Re: Review hudson-code pull request which modifies scm polling behaviour [message #1405569 is a reply to message #1405358] Thu, 07 August 2014 17:03 Go to previous message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 469
Registered: August 2011
Location: Fremont, CA USA
Senior Member
BTW, contributing through Gerrit is similar to Github. You create the eclipse account and add your SSH key. Then clone

git clone ssh://{sshusername}@git.eclipse.org:29418/hudson/org.eclipse.hudson.core.git

The only difference is when you push, you need to use this

git push ssh://{sshusername}@git.eclipse.org:29418/hudson/org.eclipse.hudson.core.git HEAD:refs/for/master

This will create a Gerrit review similar to Github pull request.


Winston Prakash
Eclipse Hudson team
Previous Topic:Monitoring plugin for Hudson
Next Topic:Bug in "Restrict where this job can be run"
Goto Forum:
  


Current Time: Thu Mar 05 10:32:53 GMT 2015

Powered by FUDForum. Page generated in 0.02007 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software