Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » GMF (Graphical Modeling Framework) » AbstractContributionItem causes deadlock
AbstractContributionItem causes deadlock [message #236348] Fri, 17 July 2009 09:17 Go to next message
Roland Brand is currently offline Roland BrandFriend
Messages: 42
Registered: July 2009
Member
Hi

We recently upgraded our product from Eclipse Ganymede to Galileo and are
now faced with a deadlock caused by the AbstractContributionItem.

The background is that we have a thread that continuously updates our EMF
model, using EMF commands. All works well until the undo limit is reached.
At this point, the DefaultOperationHistory (in org.eclipse.core.commands)
is removing a command from the undoList and notifies the listeners about
this.

The deadlock occurs, when the FontnameContributionItem receives this
notification. The problem is the syncExec in historyNotification() at line
658 in AbstractContributionItem. The syncExec will never be executed,
because the main thread is locked by an asyncExec initiated by the
OperationHistoryHandler, which is waiting for another lock, which is hold
by the DefaultOperationHistory.

I think the deadlock could be avoided by simply calling an asyncExec in
the AbstractContributionItem. Could someone please verify this?

Thanks, Roland
Re: AbstractContributionItem causes deadlock [message #236877 is a reply to message #236348] Mon, 20 July 2009 13:42 Go to previous messageGo to next message
Alexander Shatalin is currently offline Alexander ShatalinFriend
Messages: 2928
Registered: July 2009
Senior Member
Hello Roland,

Please file a bugzilla request for this problem. It make sense to use assyncExec
there.

-----------------
Alex Shatalin
Re: AbstractContributionItem causes deadlock [message #236920 is a reply to message #236877] Mon, 20 July 2009 14:12 Go to previous message
Roland Brand is currently offline Roland BrandFriend
Messages: 42
Registered: July 2009
Member
Hi Alex

I just filed bugzilla entry #284009 for this.

Greets, Roland
Previous Topic:Ecore editor style galleries for GMF
Next Topic:How to close an open editor
Goto Forum:
  


Current Time: Thu Apr 02 17:00:11 GMT 2020

Powered by FUDForum. Page generated in 0.02656 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top