Eclipse Community Forums: GMF (Graphical Modeling Framework) » Deletion of reference does also delete containment

Help

Home

Home » Modeling » GMF (Graphical Modeling Framework) » Deletion of reference does also delete containment

Show: Today's Messages :: Show Polls :: Message Navigator

Deletion of reference does also delete containment [message #222873]

Thu, 26 March 2009 14:24

Daniel Rippel

Messages: 29
Registered: July 2009

Junior Member

Hi everyone.

I have a model where my objects A are stored as containments under the
diagram root node.
Also contained in the root node are some objects B which hold references
to some of the elements A.

My problem: Each time I delete a reference in B the original element A
which is contained in the root node is also deleted. The same happens if
I delete one of the B's. All of the referenced A's are also deleted.

Does anybody know a way how this could be bypassed? The optimal solution
would be, that on deletion of a reference, a check would be triggerd if
there is still another reference to A. If there is one, A would stay
untouched, but if this was the last reference, A would also be deleted
from the containment (and thus from the model)

Thanks in advance,
Daniel

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223379 is a reply to message #222873]

Mon, 30 March 2009 17:08

Alexander Shatalin

Messages: 2928
Registered: July 2009

Senior Member

Hello Daniel,

Are you sure reference from B to A is not a containment one?
By default only reference should be removed on deleting B instance - A should
stay on a diagram.

-----------------
Alex Shatalin

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223473 is a reply to message #223379]

Tue, 31 March 2009 07:11

Daniel Rippel

Messages: 29
Registered: July 2009

Junior Member

This is a multi-part message in MIME format.
--------------060608000205090301040001
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I have set conmaintent to false in the ecore definition of the model.
Unfortunately I'm rather sure, that gmf doesn't make any difference
between the containment->True relation in the diagram node, and the
containment->False relation in B. It uses the following code to create
the property (which is A in the example):

public class Property2CreateCommand extends EditElementCommand {
....
ProductStructureDiagram.Property newElement =
ProductStructureDiagram.ProductStructureDiagramFactory.eINST ANCE
.createProperty();

ProductStructureDiagram.ProductStructureModel owner =
(ProductStructureDiagram.ProductStructureModel)
getElementToEdit().eContainer();
owner.getPSD_Property_Containment().add(newElement);
ProductStructureDiagram.Node_Object childHolder =
(ProductStructureDiagram.Node_Object) getElementToEdit();
childHolder.getProperties().add(newElement);
....

whereas the .eContainer in the owner statement is added manually because
the generated code tries to cast getElementToEdit first to model
(resulting in an exception) and then to the Node_Object where a
reference should be placed...

I couldn't find any other way to express an reference, than to set
eCores containment flag to false. (Attached a picture from the ecore
diagram)

Alex Shatalin schrieb:
> Hello Daniel,
>
> Are you sure reference from B to A is not a containment one? By default
> only reference should be removed on deleting B instance - A should stay
> on a diagram.
>
> -----------------
> Alex Shatalin
>
>

--------------060608000205090301040001
Content-Type: image/png;
name="PartOfTheECore.PNG"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="PartOfTheECore.PNG"

iVBORw0KGgoAAAANSUhEUgAAAlkAAAC+CAIAAACJRI0DAAAAAXNSR0IArs4c 6QAAAARnQU1B
AACxjwv8YQUAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgA ABdwnLpRPAAA
GlJJREFUeF7tndtzFce1h33+Jx6TSogNwYbEIa+88AfkgYpjjFJgBERg7LIr URwJndgCyQiS
4wv4AUMloYLkTSWpckBIQgoYW/CYvTegLVAs8cIZscN4mOnbXHdP90dNuWSp L2t9a+3+zepp
af7n8ePHz/EPAhCAAAQg4DOBQAv5BwEIQAACEPCZwHM+O4/vEIAABCAAgfX9 UShAAAIQgAAE
PCeAFnqeALgPAQhAAALUheQABCAAAQh4T4C60PsUAAAEIAAB7wmghd6nAAAg AAEIeE8ALfQ+
BQAAAQhAwHsCaKH3KQAACEAAAt4TQAu9TwEAPH78aHVltjF25eJw7IINBCDg CQG00JNA46aK
wMpy6/TRF84Obb8wvjN5fTa640T/hjsLl4CoJXD27FltGxpAwEICaKGFQcGk qgl0tfCr2ROr
a9eS1/27k6eOfq9ULQz+DGQZPpc0rMJUtLCMODJmBQRK+QRWYDdTQKBAAoEW ThzddGt2TKaF
J9/4vlALZWKTVoTSto/5Hv2LytEfqYfNOamQP1pYYFoyVJUE0MIqaTOXpQQC LfzgyKYvZz74
ZnUuuFbXnlxPv7jfbowf3nh7XrBH2hWhpFdpZSZt+3DGpAHR72QeVhEn9Zho oaUpjlk6Amih
jhA/94BAoIUnDm/+y9n+L/4+tn7948n19Iu/TQ79vv+7i/OTMs1LykNaEUrb PqqFCiXOPCxa
6EHW4+IzBNBCEgICjx8ut97/1ZYz47v+fO7NPyWu82cODu39ztdyLQwIxlQn +r/hBqZiY9Ok
farqsztg+N9Y+Zg0SWtkd/bY6+2SJlEX1vHj9GhNfI46eqx6qbVYR9dCm7WZ iRbWOr4YXwyB
h53W/x568V/XxoXPC++1p0YOvvDV9SnzCizUtpjIyeo5bXuhn4qyL6qCmScV Gs8eaTE5Z9Mo
K8tN589Ro4U2ZRy22ErgQac11L91YVqshXfbU7/r3/zlnEoLY6VhtCyLOp3t +zJsJlqYLEZj
0ijb4JUNjhbamsXZ7epqofQcdbv0c9TZTTfuiRYao6KhxwQCLRzcv/X61Qnh 2Zm7rcu/ef2H
N2c/V9SF3R/FyjtzmYltZka3IhVhKUoLYzufMsGO+Sg0TLvieJxl9rq+0mmq zlG3J2XnqLs5
b5iuvfVfm5nskfY2QMxuBYFAC9/Zt+3D00cv/vWj5HXh/Ikju5+/YaCFoRxm q//UJZdWic0L
0Kiqpa3/qAutSNlCjXjYaSrOUd9rSc9RR+//TG6VCrX6v4MZfmrQwjLgM6Zr BJY7rTd/+aOR
ob0TfxyZ+EP8Gh//df/Pf7Awo68LK9bC5EokLE+TGokWupbB+fwJtFB1jvqS 9By1MAMNxSmf
yd/2NpwOLSwKOOO4TGB5qX2k78czV04Kz860W1OH+16cN9PCcNcoeZusOEcj PDsjk7qYtsXW
gu6GlfAmPdlS3UxoMHWhe5+EQAsV56g/O3NAdo5aoYXRbf+QWLibGv1O+JER PlOI5nP0XlP2
WCEWnXBMtNC9vMWj4gl0ltqHXvvJ9D/FWthqTR18bev1a43kxCYbjMnPf6hA 4ec8pjqyLjLP
ZQ9snn2UE38gYjKp0BKFedoVp/jgMWJuAg86TcU56rvtSdk5arUWyu69or2E Uqe4j4y1jxkg
VNPuaNrM5Hlh7jxigPoTCLSwf/f2q1+cFp6daTUv739129y0QAtr7brh5lIq H7UrTqrRaFwN
gUALVeeoW5Oyc9RJLTTck4hWeMJKTqZqCrVTKChaWE0iMUvtCQRa+PqrP33/ 2C8+/fit9euT
J9fTLz48dWj3zzbPTV/ulZ+x8i5t1aioJgv3CC0sHGkFAy4vqc5Rt5sN2Tnq rqQJtyUURWFU
tBSal0x7RRkaUortdoTf12YmdWEFmcYUthP4z8ryydEjxwb7hiXXyG/7bn89 b7sbZvYVJaXC
2bQrjpmNtKqUQKCFinPU5z+TnqMWilOyPlNomHn9JxzWfGRtZqKFleYck0HA bQLaFcdt92vq
XaCFqnPUY9Jz1GhhTSOO2RD4lkCj0QgWbv4VTiAAS57Vi0BnqaU4R91qSs9R m2thrKXJY0Xh
Lqv2eaGsfNTepVEX1itpsRYCVhPQrjhWW++rcYEWqs5RN6XnqFNpYbdx8uCo 7BR0tL1MO0Pl
U5xH7bbRZiZa6Gv64zcESiCgXXFKmJMh8xJYut9SnKNu/rvEc9RlHGYWKrQ2 M9HCvGlEfwhA
ICSgXXFgZSGBQAsV56j/r8xz1GVooXBMbWaihRZmJiZBoK4EtCtOXR1z2u6V h51enaNGC53O
LJyDgK8E0EJfI2+739rMpC60PYTY5x6BMu6FLaGkXXEssRMzPDxHrT7hjBby oYBAWQRkB+TU
WphfKWV/pyb/yFpSaKEWEQ16QkCbmWhhT+LCpI4TiJ3wDryNfqcMTZKNWcZc iuBpVxzHA497
thLQZiZaaGvosKunBB6trsw2xq5cHFZcS61FmY1CBVL/jlROd9HCnADp7jYB tNDt+OJdWQRW
llsTb2w6M7T9wvjO5HVudMfo/g23Fy4Jp1eUYt0fhf+V/d5xOGzyd5O7P4p9 P7YpGrUqaYzs
OzKrhDPKuGtXnLICxrgQUBLQZiZ1IRkEAQGBQAuPD2y+OTMmfLvvvfbk6MDG xfnJzFoYFaSY
OAnLR1l7ba2ZSgu1s4RCjhbysakXAbSwXvHCWlsIPOi0hg+8tDA9LtTCu+2p oQObbs1NZdbC
WMekCKmrt+S8qfZIhZpnPqOi8NWuOLYEGDs8I6DNTOpCzzICd80ILHfawVts 5q5OCN/u225d
fnvvlhuzn5eqhbGdz+j+asVaKLRE6Lt2xTHDT6saE0h1W1aZn9rMRAsriwUT 1YlAoIUDfS8f
H3lF+Hbfj04d2rfr+fkZ8QsZDJ8XRnGY1IXd9mkXGnV7xVZtOJfCnWREtStO nZIAWzMRiD0F
D8dIlUiZZlZ10mYmWlg4cwZ0gUDwdt9TxwdGBvcI3+4bvPX3vXf33FmUvt1X +LFXPNtDC11I
God8eLSW/Ry1bAMDLXQoQXAFAmYEkrfG0e/IDsvEKr9UZ2rS1ovJElNhldrg KBLt3bcZP1r1
mMDKcjP/OWp1RoUb77HCMfb9ZLNu6sqqTxk4bWZSF/Y455jeYQLRx2xRN2OP 32IEYjWi+Vog
aykjnFyqZAZHVx/13b12xXE43C659rDTzH+O2uRmLnpPFpO35P/GbhaT93OK EGgzEy10KYHx
xQUClW0lmVd75li1K475ULTsIYEHnabqHHVr0vAcdXLzP+lU2MZkvyT56TD8 vGgzEy3sYb4x
NQQEBAw/2znZZV5T1PNqV5ycZtO9GgLLSy3VOepmw/wctVDqhFsjhloY62v4 edFmJlpYTWox
CwQ0BDI8AsnDFC3MQ8/5voEWFniOupts2vrPUAuzwUcLs3GjFwQgkIWAdsXJ Mih9KicQvN03
8zlq2W1WTBFDn7Qa2W0p627IRpuZ1IWGJGkGAQjoCWhXHP0QtKg5AeGmZXgQ RnhiK6p2SY2M
/TTbc25tZqKFNc87zM9KwMN3mQbLQQX/1G9MzRou+tWGgOwBXrT+iz4RSFUX hrqY9pkCWlib
BMJQCDhAQLviOOAjLtSRgDYzqQvrGFZshoClBLQrjqV2Y5brBLSZiRa6ngL4 B4EKCWhXnApt
YSoIfEtAm5loIekCAQgURkC74hQ2EwNBIA0BbWaihWlw0hYCEFAS0K448INA TwhoMxMt7Elc
mBQCbhLQrjhuuo1X1hPQZiZaaH0MMRAC9SGgXXHq4wqWOkVAm5looVPxxhkI 9JaAdsXprXnM
7i0BbWaihd7mBo5DoHgC2hWn+CkZEQIGBLSZiRYaUKQJBCBgRkC74pgNQ6sa E0i+RyLt34gp
w3ltZqKFZWBnTAh4SkC74njKxVe3DV+oVAEebWaihRVEgSkg4AsB7YrjC4ia +/lobWW2MXbl
4rDiWmotar1EC7WIaAABCDhIAC10I6gry82JNzadGdp+YXxn8jo3umN0/4bb C5e0zpq8JjP6
MibZbmr+XVZtZlIXaqNJAwhAwJSAdsUxHYh2PSXwsNM8PrD55szY6tq15HWv PTk6sHFxflJr
YyotjDY2+Vo7e7SBNjPRwlQ8aewOAd7ZVNL7m3hnkwMfkged5vCBlxamx4Va eLc1OXRg0625
Ka2nsncZhh1lL2wKGmjf/audHS1MhYjGEIBAYQS0d9+FzcRAZRJYXmq9s2/b 3NWJb1bngmt1
7cn19It2s/H23i03Zj/XmlCIFiYPpmrnTTbQZiZ1YQaqdIEABMQEtCsO4GpB INDCgb6Xj4+8
8unHb61fnzy5nn7x0alD+3Y9Pz/T0Pqifq+vbCO0O6ysLtROKmygzUy0MBtY ekEAAgIC2hUH
arUgsPKwc+r4wMjgnuHBvuR1bLDvvXf33Fmc1/qCFmoR0QACEHCQAFroYFBz uKT4nYrYjxT/
q25paJ02M6kLDUnSDAIQ0BPorjjhqRx9B1o4TSCVFkafC8aoKH5kyA8tNARF MwhAoAACsRUH
USyAqaNDFFLtmbNBC81Z0RICEMhLQLbiIIp5ybrV3+T3Dov1GC0sliejQQAC KgLaFSf6S42g
9JYAWuht6HEcAl4Q0GphlALFohc5YYeT2szk7IwdgcIKCDhBQLviCL1EFJ0I vtVOaDMTLbQ6
fhgHgXoR0K44ancQxXqFu0bWajMTLaxRNDEVArYT0K44hg4gioagaGZIQJuZ aKEhSZq5RqCk
v0zNsMUmCqJYLE9vR0MLvQ09jkPAKQKIolPhjDhTzft+0UJX8we/HCfA7x7I AowoOpb6aKFj
AcUdCOQlgP6lIogopsJlbWO00NrQYBgEqiOA/uVnDcP8DGMjPFpbmW2MXbk4 rLiWWouFzIsW
FoKRQSBQPwKs3eXFjGKxELYry82JNzadGdp+YXxn8jo3umN0/4bbC5eEc6n/ pkzyr2ybvL8+
7JXZO54XZkZHRwgUTIBlumCgyuGgnYf2w07z+MDmmzNjq2vXkte99uTowMbF +cm0Wij8e9xa
LVS/8tfQTbTQEBTNIFAKAUrAUrCmGRRRTEPrv20fdJrDB15amB4XauHd1uTQ gU235qZkIxuq
V1QFZdVkUX+5FC3MkAZ0gUAuAuhfLnyldUYUzdEuL7Xe2bdt7urEN6tzwbW6 9uR6+kW72Xh7
75Ybs59n0MLoHqmhFsa6ZHu+iBaaR5+WEMhOAP3Lzq7ynoiiFnmghQN9Lx8f eeXTj99avz55
cj394qNTh/bten5+pqEYR7jzmWGPNJvyJQ1DC7VBpwEEMhJA/zKCs6YboigL xcrDzqnjAyOD
e4YH+5LXscG+997dc2dxPpUWqndBzfdIs6UPWpiNG70gICaA/jmZGYhiGWFV v7m+u/MZzCur
IMPu6nEMLUcLDUHRDAJSAuifP8mBKBYYa2GpF/3tiJgKxn7dInYAJ+evVaCF BUaWofwiwLLo
V7yf9ZYbIMeijxY6FlDcKZcAK2C5fOs5OndF9YzbM1ajhQ4EERfKJYD+lcvX odERxfoGEy2s
b+ywvEQC6F+JcD0YGlGsXZDRwtqFDIPLIoD+lUXW43ERxboEHy2sS6SwsxQC 6F8pWBk0QQBR
tDwp0ELLA4R5pRBgYSoFK4MaEKhL7jUajeidog9fBy4rArj+q478g4ADBCgB HQiiSy7URRRd
Yq7whbrQk0B76ib652nga+U2omhDuNBCG6KADUUSQP+KpMlYFRIgdSuEHZ8K LewhfKYujACL
SGEoGcgOAhSLFccBLawYONMVRgD9KwwlA1lMAFGsJjhoYTWcmaUYAuhfMRwZ pYYEEMVSg4YW
loqXwYshwCpQDEdGcYIAH4cywogWlkGVMQsgQAlYAESGcJoAolhgeNHCAmEy VF4C6F9egvT3
kgCimD/saGF+hoyQiwD6lwsfnSEQIYAoZk4HtDAzOjpmJ4D+ZWdHTwgYEEAU DSA90wQtTEuM
9hkJoH8ZwdENAjkIaD93Wg3IMXmdumo58PdI6xROC23l/tTCoGCSnwRkH8bu 9/1kEnqtJYAW
ep4hWdzX3opmGZQ+EIBAQQSEoqgVg4Imt3QYrftooaWRs80s9M+2iGAPBLQE YqIY1QPe2RSj
hxZq08nNBlFtE34duI3+uRl7vPKPQOwz7h+A9dVM7TVa6F1WaFWQR4De5QQO e0PA2083WuhN
jps5aiiEZoPRCgIQqA0Bz0tDtLA2mVqBoSZCWIEZTAEBCFRAwHPxixFGCytI uRpMYaKC2lyp
gZ+YCAEIQEBEQLu+8bzQ/cRBCN2PMR5CAAJKAmghCbJOQC2Hhoy0yWQ4Ds0g AAEIVExAu3xR
F1YckRpPp02mGvuG6RCAgNMEtMuXVAsfra7MNsauXBxWXEutRafp4dwzBLTJ BC8IQAACdhLQ
Ll9SLVxZbp0++sLZoe0Xxncmr89Gd5zo33Bn4ZKdbmNVGQRkyZTcgC1jdsaE AAQgkJlAXi38
avbE6tq15HX/7uSpo9+rRgufe46N3MwJsN5RDdAcbyyZTI7k5LKbzhCAAAQK IpBLCyeObro1
OybTwpNvfF+ohcHaGv2X3xHzxVo9V7FW5fdLMULXVGEDxY9kAxarhSYSSBsI QAACthHQCITs
x8Ee6QdHNn0588E3q3PBtbr25Hr6xf12Y/zwxtvzgj3S2MqbX8myjaA2I/xp tsFlKlWUQHat
Stom+772JkCtu4Zmd2+ssuW34RQ0gwAEINATAqrnhScOb/7L2f4v/j62fv3j yfX0i79NDv2+
/7uL85NJo2UreGb3sslVtJdihGyD+6yFXd/NFTFz3OkIAQhAoDICUi18uNx6 /1dbzozv+vO5
N/+UuM6fOTi09ztfp9HCsKaJqZRw0y+50aqW2LB9F1ysu3q/MbZ3GtpT7IzR ki7mcsz4aEUo
VPRsAGNkwgwzvxsQbrjLRLGyDGYiCEAAAvkJyLWw0xo59OK/ro0Lnxfea08d O/jCV9enzOvC
pObJSjfh9qZCmbSCEVWXmMFJXVGIRNhYO6Nie1PoXShUsi+EApkKYAyC0Bd1 PikePkcVMX9S
MgIEIACBiglItfBBpzXUv3VhWqyFd9tTv+vf/OWcXgtla65CLYRyZd4+JidR bTPXY6F8Rms7
9U2AobUmzZKTyswo6vuyFNQexKo4d5kOAhCAQFEEVFo4uH/r9asTwrMzd1uX f/P6D2/Ofi6U
hNiuo1CcTGQg2tG8vUwLhQWfrLSqTAujrEKpTlql/o4hKO1cmevCotKRcSAA AQj0hIBKC9/Z
t+3D00cv/vWj5HXh/Ikju5+/IdFCoSeKvUHDpdywXtRqYVTneq6FGVgVW/8l bzKoC3vyUWRS
CECghwSkWrjcab35yx+NDO2d+OPIxB/i1/j4r/t//oOFGXFdmGF9D/XJvP4z 37EUFq9Jycys
1tqhZN7JdEitT2hhDz8wTA0BCDhJQK6FS+3DfT+euXJSeHam3Zoa6HtxPocW xjYhFcdAhEt/
9MmfsK9hwWfYrGtt2DjDjGoBC3NLLfAx0VVAiw4oNFtx80Fd6ORHHacgAAEF AakWdpbah177
yfQ/xVrYak0dfG3r9WsNRckV+5Gw1gmfYCUbJx+eRR93JaU0qlWhZkQH0c4l LEmjvWLak2pG
hcjF/Iq5piasdUoGSiaQilzh7AxLCQQg4CoBlRb2795+9YvTwrMzrebl/a9u m5sWaKGrpPAL
LSQHIAABVwmotPD1V3/6/rFffPrxW+vXJ0+up198eOrQ7p9tnpu+7CoX/EoS QAvJCghAwFUC
Ui38z8ryydEjxwb7hiXXyG/7bn897yoX/EILyQEIQMAfArwOyZ9Y5/WUujAv QfpDAAK2EnhG
CxuNhvnfXKalhwSCDLE1k7ELAhCAQHYC1IXZ2fnWk7rQt4jjLwT8IYAW+hPr vJ6ihXkJ0h8C
ELCVAFpoa2TsswsttC8mWAQBCBRDAC0shqMPo6CFPkQZHyHgJwG00M+4Z/Ea LcxCjT4QgEAd
CKCFdYiSHTaihXbEASsgAIHiCaCFxTN1dUS00NXI4hcEIIAWkgOmBNBCU1K0 gwAE6kYALaxb
xHpnL1rYO/bMDAEIlEsALSyXr0ujo4UuRRNfIACBKAG0kHwwJYAWmpKiHQQg UDcCaGHdItY7
e9HC3rFnZghAoFwCaGG5fF0aHS10KZr4AgEIsEdKDmQhgBZmoUYfCECgDgR4 Z5OHb17K7jLv
bKrDhxobIQCB1ATYI02NzNsO1IXehh7HIeA8AbTQ+RAX5iBaWBhKBoIABCwj gBZaFhCLzUEL
LQ4OpkEAArkIoIW58HnVGS30Ktw4CwGvCKCFXoU7l7NoYS58dIYABCwmgBZa HBzLTEMLLQsI
5kAAAoURQAsLQ+n8QGih8yHGQQh4SwAt9Db0qR1HC1MjowMEIFATAmhhTQJl gZlooQVBwAQI
QKAUAmhhKVidHBQtdDKsOAUBCAQE0ELSwJQAWmhKinYQgEDdCKCFdYtY7+xF C3vHnpkhAIFy
CaCF5fJ1aXS00KVo4gsEIBAlgBaSD6YE0EJTUrSDAATqRoB3NmV/gZGHPXln U90+4NgLAQgY
EaAuNMJEo4AAdSFpAAEIuEoALXQ1ssX7hRYWz5QRIQABOwighXbEoQ5WoIV1 iBI2QgACWQig
hVmo+dkHLfQz7ngNAR8IoIU+RLkYH9HCYjgyCgQgYB8BtNC+mNhqEVpoa2Sw CwIQyEsALcxL
0J/+aKE/scZTCPhGAC30LeLZ/UULs7OjJwQgYDcBtNDu+NhkHVpoUzSwBQIQ KJIAWlgkTbfH
Qgvdji/eQcBnAmihz9FP5ztamI4XrSEAgfoQQAvrE6teW4oW9joCzA8BCJRF 4Bkt9PCPTeNy
KgJlpSHjQgACEOgpAerCnuJncghAAAIQsIAAWmhBEDABAhCAAAR6SgAt7Cl+ JocABCAAAQsI
oIUWBAETIAABCECgpwTQwp7iZ3IIQAACELCAAFpoQRAwAQIQgAAEekrg/wFN HGam91qG+gAA
AABJRU5ErkJggg==
--------------060608000205090301040001--

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223572 is a reply to message #223473]

Tue, 31 March 2009 10:46

Alexander Shatalin

Messages: 2928
Registered: July 2009

Senior Member

Hello Daniel,

Looks like Property is described as a child element of Node_Object in your
..gmfmap model (otherwise why generated Property2CreateCommand casting element
to edit to Node_Object..)

Can you please briefly explain me a structure of mapping model in this situation?
In general if you are describing a node and child elements/links from this
node then corresponding children/link domain model element should be deleted
from morel on deleting the node…

Looking on your model structure I propose following mapping:
- TopNodeMapping for Node_Object
- TopNodeMapping for Property
- LinkMapping with LinkMetaFeature set to a reference from Node_Object to
Property
In this case Property should not be removed on deleting a link from Node_Object
to Property or NodeObject itself..

-----------------
Alex Shatalin

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223651 is a reply to message #223572]

Tue, 31 March 2009 12:28

Daniel Rippel

Messages: 29
Registered: July 2009

Junior Member

Hi Alex,

yes you are right, acutally I use a ChildReference to access the
Properties, and to put them in the according compartment. The
ChildReference has set Containment on the DiagramRoots containment and
ChildrenFeature on the Node_Objects non-containment-reference.

My actual Model looks like:
TopNode Node_Object
|- Compartment
|- ChildReference Property (Containment:
DiagramRoot.PropertyContainment/ChildrenFeature: Node_Object.Properties)

There are some other TopNodes (witch are rather similar to the
Node_Object) and one Link Maping for the associations that could be
drawn in the model.

I have tried to use a Top Node Reference to define the Properties, but
then I'm not sure how to create them correctly (using Node_Objects
childreference and setting Referenced Child to the top node does only
create the property in the Root-Containment and then crashes when trying
to add it to the Node_Object (again it tries to cast to both from
getElementToEdit() )

I'm not sure how I could create a Link Maping, using the non containment
relationship as containment feature, or how i could include a link in an
compartment. My situation is the following: I want to create something
that looks similar to the uml class. Box (Node_Object) with an
compartment of referenced Properties (Each displayed in a shared
WrappingLabel). These properties are contained in the DiagramRoot
because I need to have a complete list of all of them, and because the
Node_Object should only use references to the object, so that changing
one of them also influences and updates the other references (this works
fine)

Alex Shatalin schrieb:
> Hello Daniel,
>
> Looks like Property is described as a child element of Node_Object in
> your .gmfmap model (otherwise why generated Property2CreateCommand
> casting element to edit to Node_Object..)
>
> Can you please briefly explain me a structure of mapping model in this
> situation? In general if you are describing a node and child
> elements/links from this node then corresponding children/link domain
> model element should be deleted from morel on deleting the node…
> Looking on your model structure I propose following mapping:
> - TopNodeMapping for Node_Object
> - TopNodeMapping for Property
> - LinkMapping with LinkMetaFeature set to a reference from Node_Object
> to Property
> In this case Property should not be removed on deleting a link from
> Node_Object to Property or NodeObject itself..
>
> -----------------
> Alex Shatalin
>
>
>

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223729 is a reply to message #223651]

Tue, 31 March 2009 17:09

Alexander Shatalin

Messages: 2928
Registered: July 2009

Senior Member

Hello Daniel,

So, you have really a little bit modified use case – by default GMF generates
code supposing that all child nodes are contained in a parent node and should
be removed together with parent node.

I suppose you’ve already modified generated code a little bit to support
this situation, so I suggest you to fix this very problem – deletion of Property
nodes on deleting parent diagram node. I suggest you to modify generated
NodeItemSemanticEditPolicy.getDestroyElementCommand() and skip (comment out)
child element deletion there.

With the link (non-containment reference from Node to Property) deletion
everything should be ok – I mean I do not see a reason for removing Property
object in this situation. Can you please describe me a way you are using
to delete this link? Are you deleting it from the diagram or from properties
view?

-----------------
Alex Shatalin

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223805 is a reply to message #223729]

Wed, 01 April 2009 07:39

Daniel Rippel

Messages: 29
Registered: July 2009

Junior Member

Hi Alex,,

thank you! Editing the SemanticItemEditPolicy prevents deletion of the
properties on node deletion.

The problem remaines when on the diagram clicking on a property in a
compartment, and pressing the DEL-Key on the keyboard. Then the original
property object is destroyed as well and all other references are
pointing to nowhere, displaying sometihing like ...Propert@d4rv2323 and
some empty boxes as title (reference to a type and memory adress where
nothing is stored anymore). It works fine using the property sheets
selection mechanism to remove properties from the list).

Is there any way to disable the deletion of properties in a compartment?
If so the user could use the property sheets mechanism do remove them.
(I'd love to leave them selectable because its the only way to edit them
by selecting in the compartment :) )

To the link: I'm not sure what exacly you mean with it I can't create a
link mapping for this reference or can I? I've tried, but Link Mappings
always require to have a class and a containment feature for the link.
Alex Shatalin schrieb:
> Hello Daniel,
>
> So, you have really a little bit modified use case – by default GMF
> generates code supposing that all child nodes are contained in a parent
> node and should be removed together with parent node.
>
> I suppose you’ve already modified generated code a little bit to support
> this situation, so I suggest you to fix this very problem – deletion of
> Property nodes on deleting parent diagram node. I suggest you to modify
> generated NodeItemSemanticEditPolicy.getDestroyElementCommand() and skip
> (comment out) child element deletion there.
>
> With the link (non-containment reference from Node to Property) deletion
> everything should be ok – I mean I do not see a reason for removing
> Property object in this situation. Can you please describe me a way you
> are using to delete this link? Are you deleting it from the diagram or
> from properties view?
>
> -----------------
> Alex Shatalin
>
>

Report message to a moderator

Re: Deletion of reference does also delete containment [message #223890 is a reply to message #223805]

Wed, 01 April 2009 12:16

Alexander Shatalin

Messages: 2928
Registered: July 2009

Senior Member

Hello Daniel,

> The problem remaines when on the diagram clicking on a property in a
> compartment, and pressing the DEL-Key on the keyboard. Then the
> original property object is destroyed as well and all other
> references are pointing to nowhere, displaying sometihing like
> ...Propert@d4rv2323 and some empty boxes as title (reference to a type
Try .. modifying PropertyItemSemanticEditPolicy.getDestroyElementCommand()
and write some custom code deleting the property from it's container only
in the situation then there are no other references to this property object.
:-)

> Is there any way to disable the deletion of properties in a
> compartment? If so the user could use the property sheets mechanism do
There should be a way to "decontribute" delete action from the particular
diagram element - see generated plugin.xml as a hint (we are "decontributing"
some actions there).

> To the link: I'm not sure what exacly you mean with it I can't create
> a link mapping for this reference or can I? I've tried, but Link
> Mappings always require to have a class and a containment feature for
> the link.
There are two types of links supported by GMF: Type-based and Feature-based.
First one is a diagram link associated with domain model element. This domain
model element should be contained in a link source domain model element and
point to the link destination one.
Second is just a reference drom source domain model element to the target
one.

To use second approach you should leave all teh fields blank in a link mapping
(domain element, containment feature) and specify only link feature (target
feature) and link diagram element. Using this approach you can link Node
diagram element with top-level Properties. This will be a different diagram
notation - you are representing association from Node to Property by a link
instead of visualizing corresponding properties in a Node's compartment,
but i can understand that sometimes requirements are a little bit different.

-----------------
Alex Shatalin

Report message to a moderator

Previous Topic:	Connecting only one Link between nodes
Next Topic:	Can't drag link to superclass of the destination

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 06:13:14 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter