Eclipse Community Forums: EMF » [XCORE] generated code changes on model size

Help

Home

Home » Modeling » EMF » [XCORE] generated code changes on model size

Show: Today's Messages :: Show Polls :: Message Navigator

[XCORE] generated code changes on model size [message #1311518]

Wed, 23 April 2014 21:18

Theo Weiß

Messages: 9
Registered: January 2014

Junior Member

Hi,

I have a model generated with Xcore version 1.0.2.v20130212-0719 using eclipse 4.2.2. The model holds about 50 class statements. Today I've added some new classes and the generated code changed unexpectedly:
- eStaticClass() of all impl classes changed. Now the function uses ModelPackage.eINSTANCE.getXYZ() instead of ModelPackage.Literals.XYZ.
- ModelPackageImpl needs the new import org.eclipse.emf.ecore.xmi.impl.EcoreResourceFactoryImpl.
- a model.ecore file is generated next to the impl java files.
- and many files changed

Why does this happen?
Should I worry about that?

Regards,
Theo

Report message to a moderator

Re: [XCORE] generated code changes on model size [message #1311941 is a reply to message #1311518]

Thu, 24 April 2014 03:01

Ed Merks

Messages: 33137
Registered: July 2009

Senior Member

Theo,

Comments below.

On 23/04/2014 11:18 PM, Theo Weiß wrote:
> Hi,
>
> I have a model generated with Xcore version 1.0.2.v20130212-0719 using
> eclipse 4.2.2. The model holds about 50 class statements. Today I've
> added some new classes and the generated code changed unexpectedly:
> - eStaticClass() of all impl classes changed. Now the function uses
> ModelPackage.eINSTANCE.getXYZ() instead of ModelPackage.Literals.XYZ.
This depends on the GenPackage property "Literals Interface".
> - ModelPackageImpl needs the new import
> org.eclipse.emf.ecore.xmi.impl.EcoreResourceFactoryImpl. - a
> model.ecore file is generated next to the impl java files.
This depends on the GenPackage property "Initialize by Loading"
> - and many files changed
>
> Why does this happen?
Those properties are initialized by analyzing the size of the model to
determine approximately when the generated Literals interface and the
generated logic for initializing the package in the XyzPackageImpl are
likely to exceed Java's 64K byte code limit.
> Should I worry about that?
You can add @GenModel(literalsInterface="true",
initializeByLoading="false") to your "package" header declaration in the
*.xcore resource; you can do via the properties view with the "package"
header selected. It is generally nicer to have the Literals interface
available when it doesn't actually exceed Java's byte code limit.
>
> Regards,
> Theo
>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: [XCORE] generated code changes on model size [message #1312969 is a reply to message #1311941]

Thu, 24 April 2014 16:14

Theo Weiß

Messages: 9
Registered: January 2014

Junior Member

Hi Ed,

thanks a lot for your explanation. Adding the @genModel annotation @GenModel(literalsInterface="true", loadInitialization="false") worked as you've described it. The properties view "Initialize by Loading" property added the "loadInitialization" property to the annotation, looks like it should be OK.
There is one thing that I still don't understand: having the annotation added, does the code generator however take care of the 64K limit or what will happen if this limit is reached?

Regards,
Theo

Report message to a moderator

Re: [XCORE] generated code changes on model size [message #1313029 is a reply to message #1312969]

Thu, 24 April 2014 16:59

Ed Merks

Messages: 33137
Registered: July 2009

Senior Member

Theo,

You'll get a compile error when the byte code limit is exceeded, that
that point you'll be forced to take action, i.e., change the flags to
turn off the generation of the things that are too big. Hopefully you
want reach that point...

On 24/04/2014 6:14 PM, Theo Weiß wrote:
> Hi Ed,
>
> thanks a lot for your explanation. Adding the @genModel annotation
> @GenModel(literalsInterface="true", loadInitialization="false") worked
> as you've described it. The properties view "Initialize by Loading"
> property added the "loadInitialization" property to the annotation,
> looks like it should be OK.
> There is one thing that I still don't understand: having the
> annotation added, does the code generator however take care of the 64K
> limit or what will happen if this limit is reached?
>
> Regards,
> Theo
>
>
>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator