Eclipse Community Forums: NatTable » Fix for Possible null pointer access

Help

Home

Home » Eclipse Projects » NatTable » Fix for Possible null pointer access

Show: Today's Messages :: Show Polls :: Message Navigator

Fix for Possible null pointer access [message #1272571]

Tue, 18 March 2014 08:30

Roland Meub

Messages: 1
Registered: March 2014

Junior Member

I've recently imported the NatTable source into my eclipse workspace and got two compiler errors about 'possible null pointer access'

Of course, this only occurs, when compiler settings for Null analysis are set to emit an error. the default is 'Ignore' but often, its really helpful to avoid those nasty NullPointerExceptions.

However, both possible null pointer accesses are easily to fix and I would like to submit a patch to be integrated into the source repository.

Is this the right place for this ?
I've attached the patch to this message.

Attachment: nattable_fix_possible_null_pointer_access.patch
(Size: 2.47KB, Downloaded 245 times)

Report message to a moderator

Re: Fix for Possible null pointer access [message #1272689 is a reply to message #1272571]

Tue, 18 March 2014 14:04

Dirk Fauth

Messages: 2902
Registered: July 2012

Senior Member

Quote:

Is this the right place for this ?

No, please provide patches via Gerrit. This way you can easily commit and the patches can be reviewed and merged into the repository.

Report message to a moderator

Re: Fix for Possible null pointer access [message #1272700 is a reply to message #1272689]

Tue, 18 March 2014 14:36

Dirk Fauth

Messages: 2902
Registered: July 2012

Senior Member

And to calm NatTable users, the possible null pointer access warnings are in the dataset project and the examples project. So there is no danger in the projects that are used to add NatTable to a customer project.

Report message to a moderator

Re: Fix for Possible null pointer access [message #1286924 is a reply to message #1272700]

Mon, 07 April 2014 07:43

Dirk Fauth

Messages: 2902
Registered: July 2012

Senior Member

As there is no further activity here, I pushed the proposed changes myself. As the dataset project is not published directly and the examples project is reworked ATM, that should be ok.

Please note that I'm very happy to add contributions from the community to NatTable. You just need to contribute via Gerrit for a clean and simple review process.

Thanks!

Report message to a moderator

Previous Topic:	Supported formats
Next Topic:	Modifications to tree rendering

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Apr 20 01:36:26 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter