Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc)  » [EMFStore] dirty state notifications
[EMFStore] dirty state notifications [message #1222079] Thu, 19 December 2013 16:14 Go to next message
Scott Dybiec is currently offline Scott DybiecFriend
Messages: 148
Registered: July 2009
Senior Member
I've noticed many unnecessary notifications generated by the
frequently-called ProjectSpaceBase.updateDirtyState() method:

public void updateDirtyState() {
setDirty(!getOperations().isEmpty());
}

This change removes the unnecessary notifications:

public void updateDirtyState() {
if (isDirty() != !getOperations().isEmpty()) {
setDirty(!getOperations().isEmpty());
}
}

Am I overlooking something? If not, could you add this change to the
next EMFStore release?

$cott
Re: [EMFStore] dirty state notifications [message #1222516 is a reply to message #1222079] Fri, 20 December 2013 16:41 Go to previous message
Edgar Mueller is currently offline Edgar MuellerFriend
Messages: 89
Registered: March 2011
Member
Hi Scott,

no, you are not overlooking anything. We'll add it to the next release.
I've created a BR (https://bugs.eclipse.org/bugs/show_bug.cgi?id=424545)
for it as well.

Thanks

Cheers
Edgar

Am 19.12.2013 17:14, schrieb scott@xxxxxxxx:
> I've noticed many unnecessary notifications generated by the
> frequently-called ProjectSpaceBase.updateDirtyState() method:
>
> public void updateDirtyState() {
> setDirty(!getOperations().isEmpty());
> }
>
> This change removes the unnecessary notifications:
>
> public void updateDirtyState() {
> if (isDirty() != !getOperations().isEmpty()) {
> setDirty(!getOperations().isEmpty());
> }
> }
>
> Am I overlooking something? If not, could you add this change to the
> next EMFStore release?
>
> $cott


--
Edgar Mueller

Get Professional Eclipse Support: http://eclipsesource.com/munich
Previous Topic:Declaration of super interfaces during code generation
Next Topic:How can i change loaded resource uri ?
Goto Forum:
  


Current Time: Tue Mar 09 05:06:27 GMT 2021

Powered by FUDForum. Page generated in 0.02296 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top