Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc)

Help

Home

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [EMFStore] dirty state notifications

Show: Today's Messages :: Show Polls :: Message Navigator

[EMFStore] dirty state notifications [message #1222079]

Thu, 19 December 2013 16:14

Scott Dybiec

Messages: 148
Registered: July 2009

Senior Member

I've noticed many unnecessary notifications generated by the
frequently-called ProjectSpaceBase.updateDirtyState() method:

public void updateDirtyState() {
setDirty(!getOperations().isEmpty());
}

This change removes the unnecessary notifications:

public void updateDirtyState() {
if (isDirty() != !getOperations().isEmpty()) {
setDirty(!getOperations().isEmpty());
}
}

Am I overlooking something? If not, could you add this change to the
next EMFStore release?

$cott

Report message to a moderator

Re: [EMFStore] dirty state notifications [message #1222516 is a reply to message #1222079]

Fri, 20 December 2013 16:41

Edgar Mueller

Messages: 89
Registered: March 2011

Member

Hi Scott,

no, you are not overlooking anything. We'll add it to the next release.
I've created a BR (https://bugs.eclipse.org/bugs/show_bug.cgi?id=424545)
for it as well.

Thanks

Cheers
Edgar

Am 19.12.2013 17:14, schrieb scott@xxxxxxxx:
> I've noticed many unnecessary notifications generated by the
> frequently-called ProjectSpaceBase.updateDirtyState() method:
>
> public void updateDirtyState() {
> setDirty(!getOperations().isEmpty());
> }
>
> This change removes the unnecessary notifications:
>
> public void updateDirtyState() {
> if (isDirty() != !getOperations().isEmpty()) {
> setDirty(!getOperations().isEmpty());
> }
> }
>
> Am I overlooking something? If not, could you add this change to the
> next EMFStore release?
>
> $cott

--
Edgar Mueller

Get Professional Eclipse Support: http://eclipsesource.com/munich

Report message to a moderator

Previous Topic:	Declaration of super interfaces during code generation
Next Topic:	How can i change loaded resource uri ?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Mar 09 05:06:27 GMT 2021

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter