Eclipse Community Forums: EMF » [CDO] queryXRefs and an EReference with EType 'EObject'

Help

Home

Home » Modeling » EMF » [CDO] queryXRefs and an EReference with EType 'EObject'

Show: Today's Messages :: Show Polls :: Message Navigator

[CDO] queryXRefs and an EReference with EType 'EObject' [message #1112877]

Fri, 20 September 2013 09:51

Per Sterner

Messages: 91
Registered: October 2011

Member

Hello!

we have/had one EClass which has an EReference with an EType 'EObject'. If an item is set here it is not found with CDOView.queryXRefs. I changed my model and defined an Interface and used this as the EType and it works.

The example fails, if the EType is 'EObject'

  public void testMyXref() throws Exception
  {
    PurchaseOrder purchaseOrder1 = getModel1Factory().createPurchaseOrder();

    Supplier supplier = getModel1Factory().createSupplier();
    supplier.setObject(purchaseOrder1);

    CDOSession session1 = openSession();
    CDOTransaction transaction1 = session1.openTransaction();

    CDOResource resource = transaction1.createResource(getResourcePath("/test1"));
    resource.getContents().add(supplier);
    resource.getContents().add(purchaseOrder1);

    transaction1.commit();

    /******************/

    List<CDOObjectReference> rc = transaction1.queryXRefs(CDOUtil.getCDOObject(purchaseOrder1), new EReference[] {});
    System.out.println(rc);
    assertEquals(1, rc.size());

  }

The 'Referential Integrity Check' is affected too on deleting the referenced item. The result is a stale object without a commit exception.

Perhaps a EType with EObject should not be allowed for performance reasons? At least there should be an exception/warning when using such an EClass Smile

Regards,

Per Sterner

Report message to a moderator

Re: [CDO] queryXRefs and an EReference with EType 'EObject' [message #1112890 is a reply to message #1112877]

Fri, 20 September 2013 10:20

Eike Stepper

Messages: 6680
Registered: July 2009

Senior Member

Am 20.09.2013 11:51, schrieb Per Sterner:
> Hello!
>
> we have/had one EClass which has an EReference with an EType 'EObject'. If an item is set here it is not found with
> CDOView.queryXRefs. I changed my model and defined an Interface and used this as the EType and it works.
>
> The example fails, if the EType is 'EObject'
I'm not exactly sure what you mean but we've recently fixed some bugs in the handling of inheritance and EObject:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=416285
https://bugs.eclipse.org/bugs/show_bug.cgi?id=416366

Maybe your problem is already fixed. Can you try that out in master/4.3?

Are you suggesting that the test case below fails as it is?

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

>
>
> public void testMyXref() throws Exception
> {
> PurchaseOrder purchaseOrder1 = getModel1Factory().createPurchaseOrder();
>
> Supplier supplier = getModel1Factory().createSupplier();
> supplier.setObject(purchaseOrder1);
>
> CDOSession session1 = openSession();
> CDOTransaction transaction1 = session1.openTransaction();
>
> CDOResource resource = transaction1.createResource(getResourcePath("/test1"));
> resource.getContents().add(supplier);
> resource.getContents().add(purchaseOrder1);
>
> transaction1.commit();
>
> /******************/
>
> List<CDOObjectReference> rc = transaction1.queryXRefs(CDOUtil.getCDOObject(purchaseOrder1), new EReference[] {});
> System.out.println(rc);
> assertEquals(1, rc.size());
>
> }
>
>
> The 'Referential Integrity Check' is affected too on deleting the referenced item. The result is a stale object
> without a commit exception.
>
> Perhaps a EType with EObject should not be allowed for performance reasons? At least there should be an
> exception/warning when using such an EClass :)
>
> Regards,
>
> Per Sterner
>

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator

Re: [CDO] queryXRefs and an EReference with EType 'EObject' [message #1113069 is a reply to message #1112890]

Fri, 20 September 2013 15:43

Per Sterner

Messages: 91
Registered: October 2011

Member

I updated to the current cdo-master branch in my testworkspace. And made another test-function which uses the Model6 Smile

The test fails.

The function EcoreUtil.UsageCrossReferencer.find returns one match as expected.

The code-snippet works directly in the class XRefTest.

public void testPer1() throws Exception
  {
    A itemA = getModel6Factory().createA();
    CanReferenceLegacy itemRefContainer = getModel6Factory().createCanReferenceLegacy();

    itemRefContainer.setSingleReference(itemA);

    CDOSession session1 = openSession();
    CDOTransaction transaction = session1.openTransaction();

    CDOResource resource = transaction.createResource(getResourcePath("/test1"));
    resource.getContents().add(itemA);
    resource.getContents().add(itemRefContainer);

    transaction.commit();

    List<CDOObjectReference> rc = transaction.queryXRefs(CDOUtil.getCDOObject(itemA), new EReference[] {});
//    Collection<Setting> rc2 = EcoreUtil.UsageCrossReferencer.find(itemA, (Resource)resource);
//    System.out.println(rc.size() + " ; " + rc2.size());
//    System.out.println(itemRefContainer.getSingleReference() + " <==> " + itemA);
    assertEquals(1, rc.size());
  }

Report message to a moderator

Re: [CDO] queryXRefs and an EReference with EType 'EObject' [message #1113104 is a reply to message #1113069]

Fri, 20 September 2013 16:48

Eike Stepper

Messages: 6680
Registered: July 2009

Senior Member

Am 20.09.2013 17:43, schrieb Per Sterner:
> I updated to the current cdo-master branch in my testworkspace. And made another test-function which uses the Model6 :)
>
> The test fails.
Ok, thanks for trying it out with master. Please submit a bugzilla and attach your test case there. I'll try to look at
it ASAP ;-)

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

>
> The function EcoreUtil.UsageCrossReferencer.find returns one match as expected.
>
> The code-snippet works directly in the class XRefTest.
>
>
> public void testPer1() throws Exception
> {
> A itemA = getModel6Factory().createA();
> CanReferenceLegacy itemRefContainer = getModel6Factory().createCanReferenceLegacy();
>
> itemRefContainer.setSingleReference(itemA);
>
> CDOSession session1 = openSession();
> CDOTransaction transaction = session1.openTransaction();
>
> CDOResource resource = transaction.createResource(getResourcePath("/test1"));
> resource.getContents().add(itemA);
> resource.getContents().add(itemRefContainer);
>
> transaction.commit();
>
> List<CDOObjectReference> rc = transaction.queryXRefs(CDOUtil.getCDOObject(itemA), new EReference[] {});
> // Collection<Setting> rc2 = EcoreUtil.UsageCrossReferencer.find(itemA, (Resource)resource);
> // System.out.println(rc.size() + " ; " + rc2.size());
> // System.out.println(itemRefContainer.getSingleReference() + " <==> " + itemA);
> assertEquals(1, rc.size());
> }
>

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator