Eclipse Community Forums: GMF (Graphical Modeling Framework) » Why DiagramPrinter does not take existing DiagramEditPart instance?

Home » Modeling » GMF (Graphical Modeling Framework) » Why DiagramPrinter does not take existing DiagramEditPart instance?

Show: Today's Messages :: Show Polls :: Message Navigator

Why DiagramPrinter does not take existing DiagramEditPart instance? [message #162149]

Thu, 22 November 2007 20:19

Li Ding

Messages: 29
Registered: July 2009

Junior Member

Hi,

When printing a diagram, DiagramPrinter calls PrinterHelper to create a
new DiagramEditPart. This is good for headless mode without opening an
editor. However, if editor does open already, why DiagramPrinter can not
simply take existing DiagramEditPart from the editor ? To me, creating a
new DiagramEditPart, its children EditParts and Figures adds lots of
overhead. More than that,the states set in existing editPart instances in
editor will be lost in the newly created editparts for printing.
I want to extend DiagramPrinter to take existing DiagramEditPart if it
exists but DiagramPrinter is internal. I am also afraid GMF runtime does
this way ( create new editparts ) with specific reason.
Any explanation for this will be appreciated.

Li

Report message to a moderator

Re: Why DiagramPrinter does not take existing DiagramEditPart instance? [message #162425 is a reply to message #162149]

Fri, 23 November 2007 18:25

Cherie Revells

Messages: 299
Registered: July 2009

Senior Member

Li,

DiagramPrinter was changed in September (in 2.1) to use the open diagram
editor if one exists for the reason you stated. See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=160731.

- Cherie

Li Ding wrote:
> Hi,
>
> When printing a diagram, DiagramPrinter calls PrinterHelper to create a
> new DiagramEditPart. This is good for headless mode without opening an
> editor. However, if editor does open already, why DiagramPrinter can
> not simply take existing DiagramEditPart from the editor ? To me,
> creating a new DiagramEditPart, its children EditParts and Figures adds
> lots of overhead. More than that,the states set in existing editPart
> instances in editor will be lost in the newly created editparts for
> printing.
> I want to extend DiagramPrinter to take existing DiagramEditPart if it
> exists but DiagramPrinter is internal. I am also afraid GMF runtime does
> this way ( create new editparts ) with specific reason.
> Any explanation for this will be appreciated.
>
> Li
>

Report message to a moderator