Eclipse Community Forums: Eclipse 4 » IEditorPart loses custom icon on detach/move

Home » Eclipse Projects » Eclipse 4 » IEditorPart loses custom icon on detach/move(After moving an Eclipse 3.x style editor to another stack or detach it, its icon moves to the default)

Show: Today's Messages :: Show Polls :: Message Navigator

IEditorPart loses custom icon on detach/move [message #1045007]

Fri, 19 April 2013 16:27

Norman Schoene

Messages: 5
Registered: April 2013

Junior Member

Hi,

we recently moved our application to Eclipse 4.2.2 to make use of the "detachable editors" feature (mainly for that).

Now I am facing the problem, that old Eclipse 3.x style editors implementing "IEditorPart" (we don't have any that use Injection) are losing their title icon when moved (i.e. detached or even just to another tab group).
If the editors have a default icon set via the extension defintion in the plugin.xml, they switch to that, otherwise they do not show any icon anymore.

Problem is that we are using the same editor for different contributor plug-ins, but they can specify the icons to show. The icon is set using "setTitleImage" in the editor's init() call.

I checked whether the active icon is disposed or something, but its not and I also tried overriding "getDefaultImage" / "getTitleImage" and things like that, but these never even get called on moving the editor window.

Since the issue is so "visible" it really gives a bad impression to the users.

Any ideas? I also could not find a known bug for this issue.

Thanks,
Norman

Report message to a moderator

Re: IEditorPart loses custom icon on detach/move [message #1045417 is a reply to message #1045007]

Sat, 20 April 2013 07:49

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

This sounds like a bug, when the editor is moved new CTabItem is created
for it and it sounds like the renderer is always using the default icon
(stored in the workbench.xmi).

Tom

On 19.04.13 18:53, Norman Schoene wrote:
> Hi,
>
> we recently moved our application to Eclipse 4.2.2 to make use of the
> "detachable editors" feature (mainly for that).
>
> Now I am facing the problem, that old Eclipse 3.x style editors
> implementing "IEditorPart" (we don't have any that use Injection) are
> losing their title icon when moved (i.e. detached or even just to
> another tab group).
> If the editors have a default icon set via the extension defintion in
> the plugin.xml, they switch to that, otherwise they do not show any icon
> anymore.
>
> Problem is that we are using the same editor for different contributor
> plug-ins, but they can specify the icons to show. The icon is set using
> "setTitleImage" in the editor's init() call.
>
> I checked whether the active icon is disposed or something, but its not
> and I also tried overriding "getDefaultImage" / "getTitleImage" and
> things like that, but these never even get called on moving the editor
> window.
> Since the issue is so "visible" it really gives a bad impression to the
> users.
>
> Any ideas? I also could not find a known bug for this issue.
>
> Thanks,
> Norman
>
>

Report message to a moderator