[RESOLVED] Empty "Post-commit hook failure notification" dialog is always raised [message #1016504] |
Wed, 06 March 2013 17:04 |
Guillaume P. Messages: 69 Registered: June 2010 Location: Toulouse, France |
Member |
|
|
I just updated subversive to 1.0.1 (org.eclipse.team.svn.ui_1.0.1.I20130301-1700), and I have now a warning message dialog "Post-commit hook failure notification" opened without any text inside after each commit.
After a quick look to the code, it seems to be a bug in the code of subversive. In the class ShowPostCommitErrorsOperation, there is the following check before opening the message dialog:
protected void runImpl(IProgressMonitor monitor) throws Exception {
SVNPostCommitError []errors = this.provider.getPostCommitErrors();
if (errors != null) {
... (display error message)
}
}
But, lokking a operation providing postCommitErrors, they always initialize the error array at the beginning, and then fill it if needed. So the above check always get an array (empty in there is no problem) instead of null, and so always displays the error message...
[Updated on: Wed, 13 March 2013 09:08] Report message to a moderator
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.03167 seconds