| Push a patch for approval? [message #875991] |
Wed, 23 May 2012 17:38  |
 Jeremie Bresson
Messages: 124
Registered: November 2010 |
Senior Member |
|
|
I am trying to work on bug 379783 (as casual individual contributor). It is on WikiText, but I understood the workflow is the same for all Mylyn projects.
I am very new to these modern technologies (git, gerrit, mylyn, ...). I am trying to use the contributor reference, but I did not understood everything.
I published a first patch on bugzilla.
David Green pushed it as a first review on gerrit: https://git.eclipse.org/r/#change,6020
We both agreed that my patch also needed a "loop detection" in the mediawiki template resolution.
I published a second patch... I assumed after some times, that I might had to pushed it myself on the gerrit server.
Therefore I made a checkout as proposed by gerrit:
git fetch git://git.eclipse.org/gitroot/mylyn/org.eclipse.mylyn.docs refs/changes/20/6020/1 && git checkout FETCH_HEAD
I applied my patch and commit it in my local repository (new commit, not as git amend)
Now I have this:
I have tried:
git push gerrit
fatal: 'gerrit' does not appear to be a git repository
but I need to define gerrit as remote repository (I did not do this, because I do not know how).
Some other questions:
- I am not a project commiter. Do I have right to push someting on gerrit ?
- How do I push a second change on gerrit, so that the change appears at the same place (in order to have a single point of discussion on gerrit) ?
NB: I am not sure that the section 4.8 Reviews is up to date... The gerrit instance http://review.mylyn.org/ is not used any longer, isn't it?
|
|
|
| Re: Push a patch for approval? [message #876253 is a reply to message #875991] |
Thu, 24 May 2012 08:36  |
Jeremie Bresson
Messages: 124
Registered: November 2010 |
Senior Member |
|
|
I just found here some inputs: http://wiki.eclipse.org/Gerrit
* I needed to "Confirm you agree" (Individual Contributor)
* I found my username on the page "jbresson"
* I found that the project is "mylyn/org.eclipse.mylyn.docs"
I tried:
git push ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git HEAD:refs/changes/20/6020/1
Got this back:
Counting objects: 38, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (22/22), 2.31 KiB, done.
Total 22 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 0% (0/6)
To ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git
! [remote rejected] HEAD -> refs/changes/20/6020/1 (prohibited by Gerrit)
error: failed to push some refs to 'ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git'
[Updated on: Thu, 24 May 2012 09:31] Report message to a moderator |
|
|
|
Powered by
FUDForum. Page generated in 0.02270 seconds
Search
Help
Register
Login
Home
