Skip to main content



      Home
Home » Eclipse Projects » Remote Application Platform (RAP) » Global Save Command Always Disabled(The global save command is always disabled even if there are dirty editors.)
Global Save Command Always Disabled [message #830883] Wed, 28 March 2012 03:11 Go to next message
Eclipse UserFriend
Hello everybody,

I do have a slight problem with my RCP application ported to Eclipse RAP. The application consists of a common Eclipse Workbench with a number of editors. Those editors handle their input's lifecycle correctly, i.e. the input can become dirty and the workbench is notified via firePropertyChange(PROP_INPUT). Now, the editor is marked with the usual * to indicate its dirty state to the user. But unfortunately, the global save command is not enabled, i.e. the toolbar button for save still remains disabled, as well as a corresponding menu entry.

Note that everything works fine on Eclipse RCP.

I assembled a small demo application in which the problem is the same. Since I am not sure whether I configured something wrong for Eclipse RAP, I did not open a bug directly, but am asking you for help.

For reproducing the problem with the attached demo application do the following:
- Create a new and empty workspace.
- Set up the RAP Target Components 1.4.2 Service Release as your target platform.
- Extract and import the attached project which contains the demo application.
- Launch the demo application via the included "RAPDemoEditor" launch configuration.
- Click on the toolbar element "Open Editor".
- Type something into the text field of the newly opened editor.
- Editor becomes dirty (is marked with *), but save command (first toolbar entry) still remains disabled.

Do you guys have any hints?

Thank you very much for any help.

Regards
Timo Rohrberg
Re: Global Save Command Always Disabled [message #830908 is a reply to message #830883] Wed, 28 March 2012 03:54 Go to previous messageGo to next message
Eclipse UserFriend
Hi Timo,
probably it's a bug in RAP. Please open a bugzilla and attach your demo
project there.
Thanks,
Ivan

On 3/28/2012 10:11 AM, Timo Rohrberg wrote:
> Hello everybody,
>
> I do have a slight problem with my RCP application ported to Eclipse RAP. The application consists of a common Eclipse Workbench with a number of editors. Those editors handle their input's lifecycle correctly, i.e. the input can become dirty and the workbench is notified via firePropertyChange(PROP_INPUT). Now, the editor is marked with the usual * to indicate its dirty state to the user. But unfortunately, the global save command is not enabled, i.e. the toolbar button for save still remains disabled, as well as a corresponding menu entry.
>
> Note that everything works fine on Eclipse RCP.
>
> I assembled a small demo application in which the problem is the same. Since I am not sure whether I configured something wrong for Eclipse RAP, I did not open a bug directly, but am asking you for help.
>
> For reproducing the problem with the attached demo application do the following:
> - Create a new and empty workspace.
> - Set up the RAP Target Components 1.4.2 Service Release as your target platform.
> - Extract and import the attached project which contains the demo application.
> - Launch the demo application via the included "RAPDemoEditor" launch configuration.
> - Click on the toolbar element "Open Editor".
> - Type something into the text field of the newly opened editor.
> - Editor becomes dirty (is marked with *), but save command (first toolbar entry) still remains disabled.
>
> Do you guys have any hints?
>
> Thank you very much for any help.
>
> Regards
> Timo Rohrberg
>

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: Global Save Command Always Disabled [message #830958 is a reply to message #830883] Wed, 28 March 2012 05:14 Go to previous messageGo to next message
Eclipse UserFriend
Timo,
in our Workbench Demo [1] "Save" and "Save All" actions are enabled
correctly. The difference is that the are created programmatically
(without extension point) in the ActionBarAdvisor:
saveAction = ActionFactory.SAVE.create( window );
register( saveAction );
saveAllAction = ActionFactory.SAVE_ALL.create( window );
register( saveAllAction );
Nevertheless, a bug report will be needed to track down the problem.

[ 1 ] http://rap.eclipsesource.com/rapdemo/workbench
Best,
Ivan

On 3/28/2012 10:11 AM, Timo Rohrberg wrote:
> Hello everybody,
>
> I do have a slight problem with my RCP application ported to Eclipse RAP. The application consists of a common Eclipse Workbench with a number of editors. Those editors handle their input's lifecycle correctly, i.e. the input can become dirty and the workbench is notified via firePropertyChange(PROP_INPUT). Now, the editor is marked with the usual * to indicate its dirty state to the user. But unfortunately, the global save command is not enabled, i.e. the toolbar button for save still remains disabled, as well as a corresponding menu entry.
>
> Note that everything works fine on Eclipse RCP.
>
> I assembled a small demo application in which the problem is the same. Since I am not sure whether I configured something wrong for Eclipse RAP, I did not open a bug directly, but am asking you for help.
>
> For reproducing the problem with the attached demo application do the following:
> - Create a new and empty workspace.
> - Set up the RAP Target Components 1.4.2 Service Release as your target platform.
> - Extract and import the attached project which contains the demo application.
> - Launch the demo application via the included "RAPDemoEditor" launch configuration.
> - Click on the toolbar element "Open Editor".
> - Type something into the text field of the newly opened editor.
> - Editor becomes dirty (is marked with *), but save command (first toolbar entry) still remains disabled.
>
> Do you guys have any hints?
>
> Thank you very much for any help.
>
> Regards
> Timo Rohrberg
>

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: Global Save Command Always Disabled [message #835477 is a reply to message #830883] Tue, 03 April 2012 05:15 Go to previous message
Eclipse UserFriend
Hello everybody,

thank you very much for your quick help. I filed a bug report (see Bug 375916) and am awaiting any further information Smile.

Best regards
Timo
Previous Topic:How to debug stalled UI?
Next Topic:Block Mouse/Key Events during server request
Goto Forum:
  


Current Time: Tue Jun 17 07:40:20 EDT 2025

Powered by FUDForum. Page generated in 0.06999 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top