Eclipse Community Forums: Graphiti » addGraphicalRepresentation returns null in dark mode

Help

Home

Home » Modeling » Graphiti » addGraphicalRepresentation returns null in dark mode

Show: Today's Messages :: Show Polls :: Message Navigator

addGraphicalRepresentation returns null in dark mode [message #797582]

Mon, 13 February 2012 17:07

Patrick Talbot

Messages: 36
Registered: November 2011

Member

I have AddFeatures that I used in dark mode within a Wizard to create a diagram.
In these features, I'm making use of addGraphicalRepresentation to add a container to later add other shapes in, like this:

PictogramElement pe = addGraphicalRepresentation(context, obj);

This was working fine in 0.8 but now breaks in 0.9 because addGraphicalRepresentation now systematically returns null.

I traced this to be coming from DiagramEditorDummy.executeFeature who is not realizing the IDiagramEditor interface fully, especially the method:

Object executeFeature(IFeature feature, IContext context);

DiagramEditorDummy implementation does:

public Object executeFeature(IFeature feature, IContext context) {
	if (feature != null && context != null && feature.canExecute(context)) {
		feature.execute(context);
	}

	return null;
}

This prevents me from using dark mode entirely.
Is there any way I could achieve the same behavior (getting back a PictogramElement that is created from another AddFeature), am I missing something or is this a bug?

Thanks for you help,
-Patrick

Report message to a moderator