Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc)  » [Transaction] Redo(Undo)ActionWrapper memory leak?
[Transaction] Redo(Undo)ActionWrapper memory leak? [message #84393] Tue, 22 May 2007 07:16 Go to next message
Grzegorz Bialek is currently offline Grzegorz BialekFriend
Messages: 43
Registered: July 2009
Member
Hello,

I use EMF workspace integration plugins in my App. (currently 1.1M7). Today
I discover strange behavior with my profiler. When I close any of my editors
I left in memory my TransactionalEditingDomainImpl. I create one ED for each
editor and dispose it after close. But my ED is held in memory by two
references from undo/redo action wrappers. I don't know how to release these
references.

Maybe someone can help me with this or maybe this is a small bug?

Stack from profiler looks like:
org.eclipse.emf.transaction.impl.TransactionalEditingDomainI mpl
domain of org.eclipse.emf.workspace.ui.actions.RedoActionWrapper
this$0 of org.eclipse.emf.workspace.ui.actions.RedoActionWrapper$1
ownerAccess of org.eclipse.emf.workspace.ui.actions.ActionWrapperHelper
this$0 of org.eclipse.emf.workspace.ui.actions.ActionWrapperHelper$2
[11] of java.lang.Object[12]
listeners of org.eclipse.core.runtime.ListenerList
listenerList of org.eclipse.ui.internal.PartListenerList
listeners of org.eclipse.ui.internal.PartService
partService of org.eclipse.ui.internal.WorkbenchPagePartList
partList of org.eclipse.ui.internal.WorkbenchPage
lastActivePage of
org.eclipse.ui.internal.ide.application.IDEWorkbenchWindowAd visor
windowAdvisor of org.eclipse.ui.internal.WorkbenchWindow
activeWorkbenchWindow of org.eclipse.ui.internal.Workbench [Stack
Local]
Re: [Transaction] Redo(Undo)ActionWrapper memory leak? [message #84425 is a reply to message #84393] Tue, 22 May 2007 07:35 Go to previous messageGo to next message
Grzegorz Bialek is currently offline Grzegorz BialekFriend
Messages: 43
Registered: July 2009
Member
Sorry,

I don't found setEditiongDomain() method on these actions. Now I call
setEditiongDomain(null) from dispose of my ActionBarContributor and ED is
gone. ;D
One strange thing in this is that EditingDomainActionBarContributor not
destroy this references in own default dispose.

Pozdrowienia
Grzesiek
Re: [Transaction] Redo(Undo)ActionWrapper memory leak? [message #84512 is a reply to message #84425] Tue, 22 May 2007 15:11 Go to previous message
Eclipse UserFriend
Originally posted by: merks.ca.ibm.com

This is a multi-part message in MIME format.
--------------030905090503040608080001
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Grzegorz,

The generated editors do this in their dispose, which should cause the
EditingDomainActionBarContributor to call deactivate().

if (getActionBarContributor().getActiveEditor() == this)
{
getActionBarContributor().setActiveEditor(null);
}

I'm not sure I understand exactly what you think the dispose method
should do for the EditingDomainActionBarContributor, but if you explain,
what you think is needed and why, it might be something we could add.

Also, please use the EMF newsgroup for asking about transaction now that
this component has graduated from EMFT and moved to EMF. (I've added it
to the "to" list.)


Grzegorz Bia
Re: [Transaction] Redo(Undo)ActionWrapper memory leak? [message #606758 is a reply to message #84393] Tue, 22 May 2007 07:35 Go to previous message
Grzegorz Bialek is currently offline Grzegorz BialekFriend
Messages: 43
Registered: July 2009
Member
Sorry,

I don't found setEditiongDomain() method on these actions. Now I call
setEditiongDomain(null) from dispose of my ActionBarContributor and ED is
gone. ;D
One strange thing in this is that EditingDomainActionBarContributor not
destroy this references in own default dispose.

Pozdrowienia
Grzesiek
Re: [Transaction] Redo(Undo)ActionWrapper memory leak? [message #606765 is a reply to message #84425] Tue, 22 May 2007 15:11 Go to previous message
Ed Merks is currently offline Ed MerksFriend
Messages: 31703
Registered: July 2009
Senior Member
This is a multi-part message in MIME format.
--------------030905090503040608080001
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Grzegorz,

The generated editors do this in their dispose, which should cause the
EditingDomainActionBarContributor to call deactivate().

if (getActionBarContributor().getActiveEditor() == this)
{
getActionBarContributor().setActiveEditor(null);
}

I'm not sure I understand exactly what you think the dispose method
should do for the EditingDomainActionBarContributor, but if you explain,
what you think is needed and why, it might be something we could add.

Also, please use the EMF newsgroup for asking about transaction now that
this component has graduated from EMFT and moved to EMF. (I've added it
to the "to" list.)


Grzegorz Bia


Ed Merks
Professional Support: https://www.macromodeling.com/
Previous Topic:[Teneo+Hibernate]Help! A hibernate mapping question
Next Topic:[Teneo] Where e_container come from?
Goto Forum:
  


Current Time: Thu Jan 21 16:03:12 GMT 2021

Powered by FUDForum. Page generated in 0.01702 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top