Eclipse Community Forums: GEF

Home » Eclipse Projects » GEF » Editor dispose

Wed, 28 May 2003 15:06

Eclipse User

Hello,

I noticed that the method unhookControl() in AbstractEditPartViewer is
calling:

getRootEditPart().deactivate()

instead of

getRootEditPart().removeChild()

is there a reason? I have some cleanup that I am doing in my
DiagramEditPart.removeNotify() that I don't get a chance to run when the
editor is closing. Any feedback is appreciated.

Maged

Re: Editor dispose [message #81492 is a reply to message #81465]

Wed, 28 May 2003 15:56

Eclipse User

Originally posted by: none.us.ibm.com

decactivate() is the method that we decided would be guaranteed to be
called. If you want removeNotify to be called, you could try calling
setContents((EditPart)null) afterwards.

removing children is slightly more expensive. It often results in selection
change notification.

"Maged Elaasar" <melaasar@ca.ibm.com> wrote in message
news:bb31bs$jkm$1@rogue.oti.com...
> Hello,
>
> I noticed that the method unhookControl() in AbstractEditPartViewer is
> calling:
>
> getRootEditPart().deactivate()
>
> instead of
>
> getRootEditPart().removeChild()
>
> is there a reason? I have some cleanup that I am doing in my
> DiagramEditPart.removeNotify() that I don't get a chance to run when the
> editor is closing. Any feedback is appreciated.
>
> Maged
>
>

Previous Topic:	draw2d.text bug
Next Topic:	SOS Editor

Goto Forum:

-=] Back to Top [=-

Current Time: Sun Nov 09 20:10:46 EST 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter