Eclipse Community Forums: Memory Analyzer (MAT) » Minor CSVOutputter patch

Home » Archived » Memory Analyzer (MAT) » Minor CSVOutputter patch - 1 attachment

Minor CSVOutputter patch - 1 attachment [message #7185]

Wed, 19 November 2008 15:19

Eclipse User

Originally posted by: cgrinds.us.ibm.com

I noticed that Export to CSV uses the semicolon as the field separator. I
understand this is the standard in parts (all?) of Europe, but isn't the
standard in the US. This patch asks the Locale and tries to use the most
approriate format.

CSV is an ill defined spec.

--
Chris Grindstaff
cgrinds@us.ibm.com

Attachment: CVSOutputter.patch
(Size: 0.89KB, Downloaded 407 times)

Re: Minor CSVOutputter patch - 1 attachment [message #7573 is a reply to message #7185]

Thu, 20 November 2008 07:29

Eclipse User

> I noticed that Export to CSV uses the semicolon as the field separator. I
> understand this is the standard in parts (all?) of Europe, but isn't the
> standard in the US. This patch asks the Locale and tries to use the most
> approriate format.

Hi Chris, for one reason or another, I cannot read the attached patch...
:-(

But your suggestion makes absolutely sense. I know changed the code to

private static final char SEPARATOR = new
DecimalFormatSymbols().getDecimalSeparator() == ',' ? ';' : ':';

I read that countries using the comma as decimal point are the ones that
use the semicolon as separator char.

Is this in line with the patch you suggest?

Andreas.

Re: Minor CSVOutputter patch - 1 attachment [message #7594 is a reply to message #7573]

Thu, 20 November 2008 07:30

Eclipse User

And, yes, it must read:

private static final char SEPARATOR = new
DecimalFormatSymbols().getDecimalSeparator() == ',' ? ';' : ',';

Re: Minor CSVOutputter patch - 1 attachment [message #7615 is a reply to message #7594]

Thu, 20 November 2008 08:16

Eclipse User

Originally posted by: cgrinds.us.ibm.com

andreas.buchen@sap.com (Andreas Buchen) wrote in
news:b806027f876b07d023ec6ba2db31aabf$1@www.eclipse.org:

> And, yes, it must read:
>
> private static final char SEPARATOR = new
> DecimalFormatSymbols().getDecimalSeparator() == ',' ? ';' : ',';
>

Hello Andreas,
Yes that's exactly my patch.
Thanks for applying,
Chris
--
Chris Grindstaff
cgrinds@us.ibm.com

Previous Topic:	Save Value to File
Next Topic:	New inspectors

Goto Forum:

-=] Back to Top [=-

Current Time: Fri Apr 25 06:32:42 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter