Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF » Null Pointer Exception during drag and drop in emf editor: appeared in 2.7
Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #736200] Thu, 13 October 2011 19:33 Go to next message
Eclipse UserFriend
<html>
<head>

<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which was not
before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based editor, I get a
null pointer exception.<br>
<br>
<img src="http://www.eclipse.org/forums/index.php?t=getfile&amp;id=4267" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so I would
like to know if any of you have the same problem. Same exception
appears with the generic editor generated by EMF since the null
pointer is really embedded into the EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="http://www.eclipse.org/forums/index.php?t=getfile&amp;id=4268" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</body>
</html>
  • Attachment: gijicdcf.png
    (Size: 2.27KB, Downloaded 105 times)
  • Attachment: aifbffhd.png
    (Size: 23.41KB, Downloaded 107 times)
Re: Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #736296 is a reply to message #736200] Thu, 13 October 2011 19:54 Go to previous messageGo to next message
Ed Merks is currently offline Ed MerksFriend
Messages: 33140
Registered: July 2009
Senior Member
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
That sounds like
<a class="moz-txt-link-freetext" href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043">https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043</a>.&nbsp; :-(&nbsp; A bad
regression.<br>
<br>
On 13/10/2011 9:33 PM, M Luchian wrote:
<blockquote cite="mid:j77dml$fgt$1@news.eclipse.org" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which was not
before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based editor, I get
a null pointer exception.<br>
<br>
<img src="cid:part1.05050106.09010305@gmail.com" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so I would
like to know if any of you have the same problem. Same exception
appears with the generic editor generated by EMF since the null
pointer is really embedded into the EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="cid:part2.05010505.01020803@gmail.com" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</blockquote>
</body>
</html>


Ed Merks
Professional Support: https://www.macromodeling.com/
Re: Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #736335 is a reply to message #736296] Thu, 13 October 2011 23:02 Go to previous messageGo to next message
Eclipse UserFriend
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Thanks Ed,<br>
<br>
That's the bug. Would you happen to know when the bug will be fixed
by the community? Would it be fixed in the next Eclipse service
release, or maybe available sooner via the dedicated EMF update
site?<br>
<br>
Mircea<br>
<br>
On 13/10/2011 15:54, Ed Merks wrote:
<blockquote cite="mid:j77evk$go2$3@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
That sounds like <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043">https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043</a>.&nbsp;
:-(&nbsp; A bad regression.<br>
<br>
On 13/10/2011 9:33 PM, M Luchian wrote:
<blockquote cite="mid:j77dml$fgt$1@news.eclipse.org" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which was
not before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based editor, I
get a null pointer exception.<br>
<br>
<img src="cid:part1.02000206.00070902@eclipse.org" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so I
would like to know if any of you have the same problem. Same
exception appears with the generic editor generated by EMF since
the null pointer is really embedded into the EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="cid:part2.05060309.02020801@eclipse.org" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</blockquote>
</blockquote>
<br>
</body>
</html>
Re: Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #736630 is a reply to message #736335] Fri, 14 October 2011 07:07 Go to previous messageGo to next message
Ed Merks is currently offline Ed MerksFriend
Messages: 33140
Registered: July 2009
Senior Member
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Mircea,<br>
<br>
Yes, I'll fix it in the next service release.&nbsp;&nbsp; I'll try to get a
build in place and on the update site for SR2 in the coming weeks;
I'll add a comment in the bug when that's done.&nbsp; You could use the
pre-SR1 version in the meantime...<br>
<br>
<br>
On 14/10/2011 1:02 AM, M Luchian wrote:
<blockquote cite="mid:j77pv0$37f$1@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Thanks Ed,<br>
<br>
That's the bug. Would you happen to know when the bug will be
fixed by the community? Would it be fixed in the next Eclipse
service release, or maybe available sooner via the dedicated EMF
update site?<br>
<br>
Mircea<br>
<br>
On 13/10/2011 15:54, Ed Merks wrote:
<blockquote cite="mid:j77evk$go2$3@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
That sounds like <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043">https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043</a>.&nbsp;

:-(&nbsp; A bad regression.<br>
<br>
On 13/10/2011 9:33 PM, M Luchian wrote:
<blockquote cite="mid:j77dml$fgt$1@news.eclipse.org" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which was
not before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based editor, I
get a null pointer exception.<br>
<br>
<img src="cid:part1.00000305.01060005@gmail.com" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so I
would like to know if any of you have the same problem. Same
exception appears with the generic editor generated by EMF
since the null pointer is really embedded into the EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="cid:part2.00060807.02090503@gmail.com" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>


Ed Merks
Professional Support: https://www.macromodeling.com/
Re: Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #736960 is a reply to message #736630] Fri, 14 October 2011 14:08 Go to previous messageGo to next message
Eclipse UserFriend
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Thanks Ed, <br>
<br>
Just to confirm, will the following update site
<a class="moz-txt-link-freetext" href="http://download.eclipse.org/modeling/emf/updates/releases/">http://download.eclipse.org/modeling/emf/updates/releases/</a> have the
fix as well or I would be safer to use the original indigo update
site for that? Strangely enough, the emf update site above has emf
until version 2.5...<br>
<br>
Mircea<br>
&nbsp;<br>
On 14/10/2011 03:07, Ed Merks wrote:
<blockquote cite="mid:j78mc7$kkl$2@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Mircea,<br>
<br>
Yes, I'll fix it in the next service release.&nbsp;&nbsp; I'll try to get a
build in place and on the update site for SR2 in the coming weeks;
I'll add a comment in the bug when that's done.&nbsp; You could use the
pre-SR1 version in the meantime...<br>
<br>
<br>
On 14/10/2011 1:02 AM, M Luchian wrote:
<blockquote cite="mid:j77pv0$37f$1@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Thanks Ed,<br>
<br>
That's the bug. Would you happen to know when the bug will be
fixed by the community? Would it be fixed in the next Eclipse
service release, or maybe available sooner via the dedicated EMF
update site?<br>
<br>
Mircea<br>
<br>
On 13/10/2011 15:54, Ed Merks wrote:
<blockquote cite="mid:j77evk$go2$3@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
That sounds like <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043">https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043</a>.&nbsp;


:-(&nbsp; A bad regression.<br>
<br>
On 13/10/2011 9:33 PM, M Luchian wrote:
<blockquote cite="mid:j77dml$fgt$1@news.eclipse.org"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which
was not before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based editor,
I get a null pointer exception.<br>
<br>
<img src="cid:part1.01070002.09050903@eclipse.org" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so I
would like to know if any of you have the same problem. Same
exception appears with the generic editor generated by EMF
since the null pointer is really embedded into the
EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="cid:part2.03000403.00000706@eclipse.org" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>
Re: Null Pointer Exception during drag and drop in emf editor: appeared in 2.7 [message #737570 is a reply to message #736960] Sat, 15 October 2011 06:28 Go to previous message
Ed Merks is currently offline Ed MerksFriend
Messages: 33140
Registered: July 2009
Senior Member
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Mircea,<br>
<br>
The aggregate site is probably the easiest:<br>
<blockquote><a class="moz-txt-link-freetext" href="http://www.eclipse.org/modeling/updates/">http://www.eclipse.org/modeling/updates/</a><br>
</blockquote>
<br>
<br>
On 14/10/2011 4:08 PM, M Luchian wrote:
<blockquote cite="mid:j79f2o$pcq$1@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Thanks Ed, <br>
<br>
Just to confirm, will the following update site <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://download.eclipse.org/modeling/emf/updates/releases/">http://download.eclipse.org/modeling/emf/updates/releases/</a>
have the fix as well or I would be safer to use the original
indigo update site for that? Strangely enough, the emf update site
above has emf until version 2.5...<br>
<br>
Mircea<br>
&nbsp;<br>
On 14/10/2011 03:07, Ed Merks wrote:
<blockquote cite="mid:j78mc7$kkl$2@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Mircea,<br>
<br>
Yes, I'll fix it in the next service release.&nbsp;&nbsp; I'll try to get
a build in place and on the update site for SR2 in the coming
weeks; I'll add a comment in the bug when that's done.&nbsp; You
could use the pre-SR1 version in the meantime...<br>
<br>
<br>
On 14/10/2011 1:02 AM, M Luchian wrote:
<blockquote cite="mid:j77pv0$37f$1@news.eclipse.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Thanks Ed,<br>
<br>
That's the bug. Would you happen to know when the bug will be
fixed by the community? Would it be fixed in the next Eclipse
service release, or maybe available sooner via the dedicated
EMF update site?<br>
<br>
Mircea<br>
<br>
On 13/10/2011 15:54, Ed Merks wrote:
<blockquote cite="mid:j77evk$go2$3@news.eclipse.org"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
That sounds like <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043">https://bugs.eclipse.org/bugs/show_bug.cgi?id=359043</a>.&nbsp;



:-(&nbsp; A bad regression.<br>
<br>
On 13/10/2011 9:33 PM, M Luchian wrote:
<blockquote cite="mid:j77dml$fgt$1@news.eclipse.org"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
I have a very strange bug in EMF with Eclipse 3.7.1 which
was not before in version 3.6. <br>
<br>
When I try to do a move of one node in my EMF based
editor, I get a null pointer exception.<br>
<br>
<img src="cid:part1.08050500.09030102@gmail.com" alt=""><br>
<br>
I have absolutely no exception from my custom packages, so
I would like to know if any of you have the same problem.
Same exception appears with the generic editor generated
by EMF since the null pointer is really embedded into the
EClassImpl<br>
<br>
<br>
Below is the stack trace and EMF plugins versions: <br>
<br>
<img src="cid:part2.00010400.03040602@gmail.com" alt=""><br>
<br>
Any help will be greatly appreciated<br>
<br>
Mircea<br>
<br>
<br>
java.lang.NullPointerException<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.impl.EClassImpl.getFeatureID(EClassImpl.java:1466)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.ecore.util.BasicExtendedMetaData.getAffiliation(BasicExtendedMetaData.java:1339)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.SetCommand.prepare(SetCommand.java:525)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.doCanExecute(AbstractOverrideableCommand.java:120)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.AbstractOverrideableCommand.canExecute(AbstractOverrideableCommand.java:113)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropLinkOn(DragAndDropCommand.java:801)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepareDropOn(DragAndDropCommand.java:707)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.command.DragAndDropCommand.prepare(DragAndDropCommand.java:307)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.common.command.AbstractCommand.canExecute(AbstractCommand.java:114)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.helper(EditingDomainViewerDropAdapter.java:324)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.emf.edit.ui.dnd.EditingDomainViewerDropAdapter.dragEnter(EditingDomainViewerDropAdapter.java:143)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:60)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:774)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget.DragEnter(DropTarget.java:297)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DropTarget$3.method3(DropTarget.java:243)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COMObject.callback3(COMObject.java:92)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native
Method)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.drag(DragSource.java:363)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:289)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:172)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)<br>
&nbsp;&nbsp;&nbsp; at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>


Ed Merks
Professional Support: https://www.macromodeling.com/
Previous Topic:Advanced EMF Databinding Tutorial
Next Topic:How to add ExtendedMetaData options to a sub ECore model
Goto Forum:
  


Current Time: Thu Apr 25 00:21:41 GMT 2024

Powered by FUDForum. Page generated in 0.03486 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top