Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » GMF (Graphical Modeling Framework) » Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo
Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo [message #691844] Sat, 02 July 2011 14:45 Go to next message
Ivar Refsdal is currently offline Ivar RefsdalFriend
Messages: 24
Registered: May 2011
Junior Member
Hi

Thanks for a nice framework so far!

However, I ran into a problem where the edges weren't restored on undo.
It can be reproduced in the ecore diagram editor like the following (I
suppose in any GMF editor):

1. Create two classes A and B.
2. Create an inheritance link from A to B, i.e. A -> B.
3. Hide B, then hide A separately (right click, filter, hide selection).
4. Do Ctrl-z two times.

Bug: The inheritance link/edge does not appear.

Solution:
Instead of using
org.eclipse.gmf.runtime.diagram.core.util.ViewUtil.get[Target|Source]ConnectionsConnectingVisibleViews(View)
as
org.eclipse.gmf.runtime.diagram.ui.editparts.ShapeNodeEditPart.getModel[Target|Source]Connections()
does, one can use
org.eclipse.gmf.runtime.diagram.core.util.ViewUtil.get[Target|Source]Connections(View)

I suppose there is a good reason for using the more complex VisibleViews
method.. Anyone knows why?

Should I file a bug-report for this?

Best regards,
Ivar Refsdal
Re: Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo [message #695719 is a reply to message #691844] Tue, 12 July 2011 11:59 Go to previous message
Ivar Refsdal is currently offline Ivar RefsdalFriend
Messages: 24
Registered: May 2011
Junior Member
Hi,

Well, I submitted a bug report:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=351824

Best,
Ivar
Previous Topic:Referencing figure, edit part from another plugin
Next Topic:Synchronization between model editor and diagram editor
Goto Forum:
  


Current Time: Thu Feb 25 16:55:32 GMT 2021

Powered by FUDForum. Page generated in 0.01909 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top