Eclipse Community Forums: Dynamic Languages Toolkit (DLTK)

Help

Home

Home » Eclipse Projects » Dynamic Languages Toolkit (DLTK) » (no subject)

Show: Today's Messages :: Show Polls :: Message Navigator

(no subject) [message #685498]

Fri, 17 June 2011 16:15

Bruno Medeiros

Messages: 16
Registered: July 2009

Junior Member

I was looking at ScriptElementImageDescriptor today, and I found this
code in the equals() method:

return (other.fFlags == this.fFlags) &&
(fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));

Is that a bug? Because if the fBaseImage is not equal, and the fSize is
not equal as well, then the equals result will be true. That doesn't
seem right.

- Bruno Medeiros
D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/

Report message to a moderator

Re: Bug in ScriptElementImageDescriptor ? [message #883026 is a reply to message #685498]

Thu, 07 June 2012 17:04

Alex Panchenko

Messages: 3
Registered: July 2009

Junior Member

Hi Bruno,

This bug was fixed.

Thanks,
Alex

On 06/17/2011 11:15 PM, Bruno Medeiros wrote:
> I was looking at ScriptElementImageDescriptor today, and I found this
> code in the equals() method:
>
> return (other.fFlags == this.fFlags) &&
> (fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));
>
> Is that a bug? Because if the fBaseImage is not equal, and the fSize is
> not equal as well, then the equals result will be true. That doesn't
> seem right.
>
> - Bruno Medeiros
> D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/

Report message to a moderator

Previous Topic:	Extend DLTK/JavaScript model
Next Topic:	TCL Templates (Snippets) not working

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 16:02:55 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter