Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » EMF » [CDO] Objectivity store
[CDO] Objectivity store [message #659762] Tue, 15 March 2011 14:22 Go to next message
kaab  is currently offline kaab Friend
Messages: 43
Registered: July 2009
Member
Hi all,

I've being doing some debug on CDO using Objectivity store and I would like to ask some questions around this implementation, mainly regarding its testing project and the expected test results from running the full suite.
I have tested the store on both CDO version 3 and 4 using AllTestsObjyBranching suite.
Both versions would not pass the full test suite of CDO, so I am wondering is that a normal situation or is there any upcoming fixes, also I would like to know if this can cause errors in the future and if this implementation is 'safe' to use and in which case it will not be.
As an example, the following test would not pass fully and have some errors or failures ComplexTest, BranchingTestWithCacheClear (testCommit, testCommitAddOrderDetail, testCommitRemoveOrderDetail).

I can provide the traces if required,

Thanks a lot,
Re: [CDO] Objectivity store [message #659812 is a reply to message #659762] Tue, 15 March 2011 16:52 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6446
Registered: July 2009
Senior Member
Hi Kaab,

I've cc'ed Ibe from Objectivity in the hope that he can answer your questions and confirm that the info on http://wiki.eclipse.org/CDO/Objectivity_Store is up to date...

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper



Am 15.03.2011 15:22, schrieb kaab:
> Hi all,
>
> I've being doing some debug on CDO using Objectivity store and I would like to ask some questions around this implementation, mainly regarding its testing project and the expected test results from running the full suite.
> I have tested the store on both CDO version 3 and 4 using AllTestsObjyBranching suite.
> Both versions would not pass the full test suite of CDO, so I am wondering is that a normal situation or is there any upcoming fixes, also I would like to know if this can cause errors in the future and if this implementation is 'safe' to use and in which case it will not be.
> As an example, the following test would not pass fully and have some errors or failures ComplexTest, BranchingTestWithCacheClear (testCommit, testCommitAddOrderDetail, testCommitRemoveOrderDetail).
>
> I can provide the traces if required,
>
> Thanks a lot,
>


Re: [CDO] Objectivity store [message #659843 is a reply to message #659762] Tue, 15 March 2011 18:48 Go to previous messageGo to next message
Ibrahim Sallam is currently offline Ibrahim SallamFriend
Messages: 2
Registered: July 2009
Junior Member
Hi Kaab,

Sorry about that, I haven't updated the store for almost a year now. I do have a new code base that I'll check into 3.0 sometime this week (hopefully), it should be more stable, and more performant. I'll check the tests and will make sure they pass.

I'll update the 4.0 base as well.

Cheers,
Ibrahim
Re: [CDO] Objectivity store [message #660016 is a reply to message #659843] Wed, 16 March 2011 14:50 Go to previous messageGo to next message
kaab  is currently offline kaab Friend
Messages: 43
Registered: July 2009
Member
Hi all,

Thanks for the fast reply,

I've been working on this yesterday, so I produced a small patch at least for the tests I mentioned, using this patch will help get rid of some errors in the handling of Deltas and should get the BranchingTest to pass more tests.
There's still an issue on the detach (BranchingTestWithCacheClear), but I didn't figure this one out yet,

You'll find the patch at the end of this message.

Please let me know what you think,

Thanks


Index: src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java
============================================================ =======
--- src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (revision 7110)
+++ src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (working copy)
@@ -423,15 +423,20 @@
if (getStore().isRequiredToSupportAudits())
{
// newObjyRevision = objySession.getObjectManager().copyRevision(this, objyRevision);
- objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
+
// objyRevision.setRevisedBranchId(branch.getID();
InternalCDORevision originalRevision = getStore().getRepository().getRevisionManager()
.getRevisionByVersion(delta.getID(), delta, 0, true);

InternalCDORevision newRevision = originalRevision.copy();

- newRevision.setVersion(deltaVersion + 1);
- newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
+ // newRevision.setVersion(deltaVersion + 1);
+ // newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
+ newRevision.adjustForCommit(branch, created);
+ if (newRevision.getVersion() != CDORevision.FIRST_VERSION)
+ {
+ objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
+ }
newObjyRevision = objySession.getObjectManager().newObject(newRevision.getECla ss(), objyRevision.ooId());
newObjyRevision.update(this, newRevision);
objyObject.addToRevisions(newObjyRevision);
Re: [CDO] Objectivity store [message #660065 is a reply to message #660016] Wed, 16 March 2011 17:20 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6446
Registered: July 2009
Senior Member
Hi Kaab,

I'm glad to see that you can help and want to. But it strikes me that a bugzilla would be a better place to exchange patches and capture discussions ;-)

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper



Am 16.03.2011 15:50, schrieb kaab:
> Hi all,
>
> Thanks for the fast reply,
>
> I've been working on this yesterday, so I produced a small patch at least for the tests I mentioned, using this patch will help get rid of some errors in the handling of Deltas and should get the BranchingTest to pass more tests.
> There's still an issue on the detach (BranchingTestWithCacheClear), but I didn't figure this one out yet,
>
> You'll find the patch at the end of this message.
>
> Please let me know what you think,
>
> Thanks
>
>
> Index: src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java
> ============================================================ =======
> --- src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (revision 7110)
> +++ src/org/eclipse/emf/cdo/server/internal/objectivity/Objectiv ityStoreAccessor.java (working copy)
> @@ -423,15 +423,20 @@
> if (getStore().isRequiredToSupportAudits())
> {
> // newObjyRevision = objySession.getObjectManager().copyRevision(this, objyRevision);
> - objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
> +
> // objyRevision.setRevisedBranchId(branch.getID();
> InternalCDORevision originalRevision = getStore().getRepository().getRevisionManager()
> .getRevisionByVersion(delta.getID(), delta, 0, true);
>
> InternalCDORevision newRevision = originalRevision.copy();
>
> - newRevision.setVersion(deltaVersion + 1);
> - newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
> + // newRevision.setVersion(deltaVersion + 1);
> + // newRevision.setBranchPoint(delta.getBranch().getPoint(create d));
> + newRevision.adjustForCommit(branch, created);
> + if (newRevision.getVersion() != CDORevision.FIRST_VERSION)
> + {
> + objyRevision.setRevisedTime(branch.getPoint(created).getTime Stamp() - 1);
> + }
> newObjyRevision = objySession.getObjectManager().newObject(newRevision.getECla ss(), objyRevision.ooId());
> newObjyRevision.update(this, newRevision);
> objyObject.addToRevisions(newObjyRevision);


Re: [CDO] Objectivity store [message #660081 is a reply to message #660065] Wed, 16 March 2011 18:21 Go to previous messageGo to next message
kaab  is currently offline kaab Friend
Messages: 43
Registered: July 2009
Member
Hi Eike,

My bad,

I'd be happy to help as much as I can.

The bug reported is created :
https://bugs.eclipse.org/bugs/show_bug.cgi?id=340205

Cheers,
Re: [CDO] Objectivity store [message #660086 is a reply to message #660081] Wed, 16 March 2011 18:33 Go to previous message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6446
Registered: July 2009
Senior Member
Am 16.03.2011 19:21, schrieb kaab:
> Hi Eike,
>
> My bad,
No worries!

> I'd be happy to help as much as I can.
>
> The bug reported is created : https://bugs.eclipse.org/bugs/show_bug.cgi?id=340205
Thank you ;-)

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper


Previous Topic:EMF Support for xsd:override
Next Topic:De-serialization of extended eCore models
Goto Forum:
  


Current Time: Sun Oct 20 16:30:04 GMT 2019

Powered by FUDForum. Page generated in 0.01637 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top