Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Graphiti » dealing with canceled commands (or ones that didn't apply changes)
dealing with canceled commands (or ones that didn't apply changes) [message #632523] Wed, 13 October 2010 09:50 Go to next message
Henrik Rentz-Reichert is currently offline Henrik Rentz-ReichertFriend
Messages: 251
Registered: July 2009
Senior Member
Hi,

in the tutorial example you introduced a renaming of an EClass as a
custom feature.
When the input is canceled then a null result is returned by the input
dialog and no change is performed to the business object.
I observed that nevertheless the editor is marked dirty.

It seems that also the method
boolean hasDoneChanges()
is not considered.

Is there a way to ignore canceled commands?

Thanks,
Henrik
Re: dealing with canceled commands (or ones that didn't apply changes) [message #632571 is a reply to message #632523] Wed, 13 October 2010 13:33 Go to previous messageGo to next message
Michael Wenz is currently offline Michael WenzFriend
Messages: 1914
Registered: July 2009
Location: Walldorf, Germany
Senior Member
This is a bug. In this case a CommandContainer is processed in the command
stack but only for FeatureCommands the check hasDoneChanges is performed.
Inside the container are again FeatureCommands, so the unpackking of the
container is missing.

Could you please open a Bugzilla for that?

Thanks,
Michael


"Henrik Rentz-Reichert" <hrr@protos.de> wrote in message
news:i93v6e$55b$1@news.eclipse.org...
> Hi,
>
> in the tutorial example you introduced a renaming of an EClass as a
> custom feature.
> When the input is canceled then a null result is returned by the input
> dialog and no change is performed to the business object.
> I observed that nevertheless the editor is marked dirty.
>
> It seems that also the method
> boolean hasDoneChanges()
> is not considered.
>
> Is there a way to ignore canceled commands?
>
> Thanks,
> Henrik
Re: dealing with canceled commands (or ones that didn't apply changes) [message #632794 is a reply to message #632571] Thu, 14 October 2010 09:54 Go to previous messageGo to next message
VincentL is currently offline VincentLFriend
Messages: 88
Registered: July 2009
Member
Hi,

I also want to mention that, even if the command is cancel, the command is stored in the
command history for undo/redo...

Vincent
Re: dealing with canceled commands (or ones that didn't apply changes) [message #632810 is a reply to message #632794] Thu, 14 October 2010 10:38 Go to previous messageGo to next message
Michael Wenz is currently offline Michael WenzFriend
Messages: 1914
Registered: July 2009
Location: Walldorf, Germany
Senior Member
Yes, that is a direct result from the above mentioned bug.

Michael

"Vincent L." <lapointe_vincent_1975@hotmail.com> wrote in message
news:i96jqv$npu$1@news.eclipse.org...
>
> Hi,
>
> I also want to mention that, even if the command is cancel, the command is
> stored in the command history for undo/redo...
>
> Vincent
Re: dealing with canceled commands (or ones that didn't apply changes) [message #632820 is a reply to message #632810] Thu, 14 October 2010 11:10 Go to previous message
Henrik Rentz-Reichert is currently offline Henrik Rentz-ReichertFriend
Messages: 251
Registered: July 2009
Senior Member
I filed

https://bugs.eclipse.org/bugs/show_bug.cgi?id=327756

Henrik

Am 14.10.2010 12:38, schrieb Michael Wenz:
> Yes, that is a direct result from the above mentioned bug.
>
> Michael
>
> "Vincent L." <lapointe_vincent_1975@hotmail.com> wrote in message
> news:i96jqv$npu$1@news.eclipse.org...
>>
>> Hi,
>>
>> I also want to mention that, even if the command is cancel, the command is
>> stored in the command history for undo/redo...
>>
>> Vincent
>
>
Previous Topic:Listening selection change
Next Topic:Rendering decorators for connections
Goto Forum:
  


Current Time: Sun Apr 05 18:02:11 GMT 2020

Powered by FUDForum. Page generated in 0.01939 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top