Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Graphiti » PlatformGraphicsAlgorithm update and IGraphicsAlgorithmRenderer refresh
PlatformGraphicsAlgorithm update and IGraphicsAlgorithmRenderer refresh [message #629046] Sun, 26 September 2010 18:42 Go to next message
Romain Raugi is currently offline Romain RaugiFriend
Messages: 15
Registered: July 2009
Junior Member
Hi,

I've started to use PlatformGraphicsAlgorithms that I render through
IGraphicsAlgorithmRenderers with Draw2D IFigures. I can't use the
provided graphics algorithms, I have some specific needs. The rendering
is fine, but there is an issue with the refresh.

When the PlatformGraphicsAlgorithm is updated (following a change in its
bounds or in its IProperties), the corresponding IFigure is not
invalidated/repainted.

I think there is an issue in
PictogramElementDelegate.refreshFigureForGraphicsAlgorithm. The
PlatformGraphicsAlgorithm case is not handled.

Best regards,

Romain
Re: PlatformGraphicsAlgorithm update and IGraphicsAlgorithmRenderer refresh [message #629053 is a reply to message #629046] Sun, 26 September 2010 19:45 Go to previous messageGo to next message
Romain Raugi is currently offline Romain RaugiFriend
Messages: 15
Registered: July 2009
Junior Member
In fact there are two things:

1- The refresh following a change in the bounds of GraphicsAlgorithm
figures is not handled in
PictogramElementDelegate.refreshFigureForGraphicsAlgorithm, in fact
there is no issue at this level.

But I don't understand that with standard GraphicsAlgorithms
(RoundedRectangle, Ellipe...) and corresponding GFShapes, the refresh is
perfect, and not with custom IFigures. Mainly when you start moving
several shapes and do undo/redo, although with simple drawings like
rectangles or ellipses. Do you have any idea? Did you notice such issue?

2- More a limitation: the IProperty collection is a way to store
graphical data in the PlatformGraphicsAlgorithm to be used by the
renderer. By this way, there is no need to extend the notational
metamodel for this purpose. But an update in these properties is not
handled and does not trigger any refresh of the renderer. Do you plan to
support this?

Best regards,

Romain

Le 26/09/2010 20:42, Romain Raugi a écrit :
> Hi,
>
> I've started to use PlatformGraphicsAlgorithms that I render through
> IGraphicsAlgorithmRenderers with Draw2D IFigures. I can't use the
> provided graphics algorithms, I have some specific needs. The rendering
> is fine, but there is an issue with the refresh.
>
> When the PlatformGraphicsAlgorithm is updated (following a change in its
> bounds or in its IProperties), the corresponding IFigure is not
> invalidated/repainted.
>
> I think there is an issue in
> PictogramElementDelegate.refreshFigureForGraphicsAlgorithm. The
> PlatformGraphicsAlgorithm case is not handled.
>
> Best regards,
>
> Romain
Re: PlatformGraphicsAlgorithm update and IGraphicsAlgorithmRenderer refresh [message #630199 is a reply to message #629053] Fri, 01 October 2010 04:27 Go to previous message
Romain Raugi is currently offline Romain RaugiFriend
Messages: 15
Registered: July 2009
Junior Member
Hi,

Here are the bug reports, with the tutorial modified to add the usage of
GraphicsAlgorithmRenderers:

1- Refresh issues with IGraphicsAlgorithmRenderer (clearly a bug)

https://bugs.eclipse.org/bugs/show_bug.cgi?id=326730

2- GraphicsAlgorithm properties update and IGraphicsAlgorithmRenderer
repaint (enhancement)

https://bugs.eclipse.org/bugs/show_bug.cgi?id=326733

I've also reported a regression about the management of domain model
updates outside the editor: Exception when undoing a domain model update
done through EMF.Edit

https://bugs.eclipse.org/bugs/show_bug.cgi?id=326731

Thanks,

Romain

Le 26/09/2010 21:45, Romain Raugi a écrit :
> In fact there are two things:
>
> 1- The refresh following a change in the bounds of GraphicsAlgorithm
> figures is not handled in
> PictogramElementDelegate.refreshFigureForGraphicsAlgorithm, in fact
> there is no issue at this level.
>
> But I don't understand that with standard GraphicsAlgorithms
> (RoundedRectangle, Ellipe...) and corresponding GFShapes, the refresh is
> perfect, and not with custom IFigures. Mainly when you start moving
> several shapes and do undo/redo, although with simple drawings like
> rectangles or ellipses. Do you have any idea? Did you notice such issue?
>
> 2- More a limitation: the IProperty collection is a way to store
> graphical data in the PlatformGraphicsAlgorithm to be used by the
> renderer. By this way, there is no need to extend the notational
> metamodel for this purpose. But an update in these properties is not
> handled and does not trigger any refresh of the renderer. Do you plan to
> support this?
>
> Best regards,
>
> Romain
>
> Le 26/09/2010 20:42, Romain Raugi a écrit :
>> Hi,
>>
>> I've started to use PlatformGraphicsAlgorithms that I render through
>> IGraphicsAlgorithmRenderers with Draw2D IFigures. I can't use the
>> provided graphics algorithms, I have some specific needs. The rendering
>> is fine, but there is an issue with the refresh.
>>
>> When the PlatformGraphicsAlgorithm is updated (following a change in its
>> bounds or in its IProperties), the corresponding IFigure is not
>> invalidated/repainted.
>>
>> I think there is an issue in
>> PictogramElementDelegate.refreshFigureForGraphicsAlgorithm. The
>> PlatformGraphicsAlgorithm case is not handled.
>>
>> Best regards,
>>
>> Romain
>
Previous Topic:Graphiti has successfully passed its release review
Next Topic:Separator in Palette Compartment
Goto Forum:
  


Current Time: Thu Apr 02 07:42:09 GMT 2020

Powered by FUDForum. Page generated in 0.01328 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top