Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Plugin Development Environment (PDE) » Re: Eclipse 3.4 RC4 Headless Build Icon Problems
Re: Eclipse 3.4 RC4 Headless Build Icon Problems [message #569421] Fri, 20 June 2008 13:15
Martin Woodward is currently offline Martin WoodwardFriend
Messages: 11
Registered: July 2009
Junior Member
I think I have found the problem. Looks like a pretty high impact bug
affecting all branding of RCP applications by PDE at 3.4 RC4?

In org.eclipse.pde.build:

On line 389 of AbstractScriptGenerator the method loadProduct returns a
product file of

new ProductFile(f.getAbsolutePath(), null)

i.e, no OS is specified and so the getIcons method of the ProductFile
will return an empty string array.

This product file is later used by AssembleConfigScriptGenerator in
computeIconsList() where it does a productFile.getIcons expecting some
results and when it doesn't find any it simply returns
"${launcherIcons}" which is then all that is inserted into the generated
eclipse.brand call like this:

<eclipse.brand
root="${eclipse.base}/win32.win32.x86/${collectingFolder}"
icons="${launcherIcons}"
name="${launcherName}"
os="${os}" />

If a write a little unit test that contructs a new ProductFile from my
RCP applications .product, it will correctly pass my icon lists back so
long as I have listed an OS in the constructor. However if I pass null
in for the contructor as the AssembleConfigScriptGenerator does I get
back an empty array.

Seems to me like a pretty clear bug in PDE that will affect anyone
trying to build branded RCP applications.

Would like to confirm that I am not missing something and this is indeed
a bug?

What do people think the likelyhood of this getting fixed for the 3.4
release is??

Many thanks,

Martin.






Martin Woodward wrote:
> Hi All,
>
> I'm trying to move our headless build system over from Eclipse 3.3 to
> Eclipse 3.4 RC4 to get ready for the release. However, I am having
> trouble with the icons in the branding of our RCP app. The
> eclipse.brand task is being called and everything in BrandingIron seems
> to be getting called (For example I had to correctly specify some
> additional properties in the Mac launcher args that I didn't have to
> before due to a bug fix in BrandingIron between 3.3 and 3.4)
>
> However, the launcher icon is missing from all platforms. It's as if
> the branding code cannot find the launcher icons.
>
> The relevant section from the .product file is:
>
> <launcher name="MyApp">
> <linux icon="/com.foobar.rcpapp/icons/icon.xpm"/>
> <macosx icon="/com.foobar.rcpapp/icons/icon.icns"/>
> <solaris/>
> <win useIco="true">
> <ico path="/com.foobar.rcpapp/icons/icon.ico"/>
> <bmp/>
> </win>
> </launcher>
>
> And works fine under 3.3. Any ideas what I might be doing wrong or any
> techniques for debugging the issue? (Obviously it works ok under PDE.UI
> because that seems to set the launcherIcons property)
>
> Many thanks,
>
> Martin.
Previous Topic:jopjwDAIIAwSivhX
Next Topic:Extension points show "Generic" under the context menu
Goto Forum:
  


Current Time: Fri Mar 29 01:23:53 GMT 2024

Powered by FUDForum. Page generated in 0.05047 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top