Shared Editing Domain - Exception when closing a diagram [message #558916] |
Tue, 14 September 2010 20:43 |
Luis Rocha Messages: 8 Registered: February 2010 |
Junior Member |
|
|
Hi all,
I am trying to implement a shared editing domain using the steps described in GMF Tips Sharing Single Editing Domain Instance Across Several Diagrams.
However, whenever I close a diagram, I get an java.lang.IllegalArgumentException: Cannot remove statically registered editing domain DiagramPartitioning.diagram.EditingDomain. See stack trace below.
The last step of this guide (#12) is to add method to the ???DocumentProvide class to correctly unload (model) resources associated with diagram. However, this method is already auto-generated by GMF tooling as:
/**
* @generated
*/
protected void disposeElementInfo(Object element, ElementInfo info) {
if (info instanceof ResourceSetInfo) {
ResourceSetInfo resourceSetInfo = (ResourceSetInfo) info;
resourceSetInfo.dispose();
}
super.disposeElementInfo(element, info);
}
The exception happens when calling resourceSetInfo.dispose(). In order to fix this problem, I am thinking about changing the dispose() method of ???DocumentProvide class to not dispose the editing domain when it is statically registered.
Change from:
/**
* @generated
*/
public void dispose() {
...
getEditingDomain().dispose();
}
To:
/**
* @generated NOT
*/
public void dispose() {
...
// Only dispose the editing domain if it was not statically registered.
String id = getEditingDomain().getID();
if (id==null || !EditingDomainManager.getInstance().isStaticallyRegistered(id)) {
getEditingDomain().dispose();
}
}
It seems to be working fine now, but I would like to know if anyone has a better solution for this problem.
Thanks,
Luis
Stack Trace:
java.lang.IllegalArgumentException: Cannot remove statically registered editing domain DiagramPartitioning.diagram.EditingDomain
at org.eclipse.emf.transaction.impl.EditingDomainManager.assertDynamicallyRegistered(EditingDomainManager.java:159)
at org.eclipse.emf.transaction.impl.TransactionalEditingDomainImpl.dispose(TransactionalEditingDomainImpl.java:886)
at diagram.diagram.part.DiagramDocumentProvider$ResourceSetInfo.dispose(DiagramDocumentProvider.java:904)
at diagram.diagram.part.DiagramDocumentProvider.disposeElementInfo(DiagramDocumentProvider.java:343)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.document.AbstractDocumentProvider.disconnect(AbstractDocumentProvider.java:425)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.parts.DiagramDocumentEditor.disposeDocumentProvider(DiagramDocumentEditor.java:515)
at org.eclipse.gmf.runtime.diagram.ui.resources.editor.parts.DiagramDocumentEditor.dispose(DiagramDocumentEditor.java:209)
at org.eclipse.ui.internal.WorkbenchPartReference.doDisposePart(WorkbenchPartReference.java:737)
at org.eclipse.ui.internal.EditorReference.doDisposePart(EditorReference.java:324)
at org.eclipse.ui.internal.WorkbenchPartReference.dispose(WorkbenchPartReference.java:684)
at org.eclipse.ui.internal.WorkbenchPage.disposePart(WorkbenchPage.java:1715)
at org.eclipse.ui.internal.WorkbenchPage.handleDeferredEvents(WorkbenchPage.java:1422)
at org.eclipse.ui.internal.WorkbenchPage.deferUpdates(WorkbenchPage.java:1406)
at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1380)
at org.eclipse.ui.internal.WorkbenchPage.closeEditor(WorkbenchPage.java:1435)
at org.eclipse.ui.internal.EditorPane.doHide(EditorPane.java:61)
at org.eclipse.ui.internal.PartStack.close(PartStack.java:543)
at org.eclipse.ui.internal.EditorStack.close(EditorStack.java:206)
at org.eclipse.ui.internal.PartStack$1.close(PartStack.java:122)
at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation$1.handleEvent(TabbedStackPresentation.java:83)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:270)
at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:279)
at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder.access$1(DefaultTabFolder.java:1)
at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder$1.closeButtonPressed(DefaultTabFolder.java:70)
at org.eclipse.ui.internal.presentations.PaneFolder.notifyCloseListeners(PaneFolder.java:626)
at org.eclipse.ui.internal.presentations.PaneFolder$3.close(PaneFolder.java:206)
at org.eclipse.swt.custom.CTabFolder.onMouse(CTabFolder.java:2199)
at org.eclipse.swt.custom.CTabFolder$1.handleEvent(CTabFolder.java:327)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3910)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3503)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
[Updated on: Tue, 14 September 2010 20:44] Report message to a moderator
|
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.02930 seconds