Eclipse Community Forums: TMF (Xtext) » Why is injection of IImageHelper private in AbstractLabelProvider?

Help

Home

Home » Modeling » TMF (Xtext) » Why is injection of IImageHelper private in AbstractLabelProvider?

Show: Today's Messages :: Show Polls :: Message Navigator

Why is injection of IImageHelper private in AbstractLabelProvider? [message #555737]

Sat, 28 August 2010 00:52

Henrik Lindberg

Messages: 2509
Registered: July 2009

Senior Member

An IImageHelper is injected in AbstractLabelProvider
@Inject
private IImageHelper imageHelper;

It would be very helpful if this was protected so a subclass does not
have to inject the helper a second time (or provided via a getter).

Or is this done on purpose to prevent it from being API?

Regards
- henrik

Report message to a moderator

Re: Why is injection of IImageHelper private in AbstractLabelProvider? [message #555753 is a reply to message #555737]

Sat, 28 August 2010 08:59

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

Hello Hendik,

i don't see any need for this:

here is the IImageHelper Interface:

public interface IImageHelper {

	Image getImage(String name);
	
	Image getImage(ImageDescriptor imageDescriptor);

}

and here the convertToImage method from AbstractLabelProvider

	protected Image convertToImage(Object imageDescription) {
		if (imageDescription instanceof Image) {
			return (Image) imageDescription;
		} else if (imageDescription instanceof ImageDescriptor) {
			return imageHelper.getImage((ImageDescriptor) imageDescription);
		} else if (imageDescription instanceof String) {
			return imageHelper.getImage((String) imageDescription);
		}
		return null;
	}

so everything the Injected IImageHelper does you can do by calling the convertToImage method.

Regards
~Christian

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Previous Topic:	Problem with Xtext 1.0 tutorial in Documentation
Next Topic:	[Grammar] How to create multiple return types?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 04:20:36 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter