Eclipse Community Forums: JFace » PresentationReconciler getDamage

Home » Eclipse Projects » JFace » PresentationReconciler getDamage(Partitioning change coverage wrongly used in getDamage method)

Show: Today's Messages :: Show Polls :: Message Navigator

PresentationReconciler getDamage [message #496941]

Wed, 11 November 2009 19:53

henrik sorensen

Messages: 2
Registered: July 2009

Junior Member

I am not sure this is the correct forum.

For my editor I was experimenting with dynamic update of my outlinePage. To my surprise the outlinePage did not get updated as I would expect. After some debugging and reading of many lines of codes within the org.eclipse.jface.text plugin, I finally discovered that the PresentationReconciler class might be at fault.

I noticed that my partitioning scanner functioned as expected and also saw the correct document range that needed to be repaired in the getCoverage method of the DocumentPartitioningChangedEvent.

At the start of the PresentationReconciler getDamage method I added the following lines of code, and after that my dynamic update of the outline page worked as I would expect.

In package org.eclipse.jface.text.presentation.

[private IRegion getDamage(DocumentEvent e, boolean optimize) 
{ if ( optimize
    && fDocumentPartitioningChanged
    && fChangedDocumentPartitions!=null)
       return new Region(fChangedDocumentPartitions.getOffset()
                        ,fChangedDocumentPartitions.getLength());

Can someone with more experience with the PresentationReconciler class comment on this?

What is the procedure to have this change accepted by the JFace project ?

thanks for your help
Henrik

Report message to a moderator

Re: PresentationReconciler getDamage [message #497750 is a reply to message #496941]

Fri, 13 November 2009 11:48

henrik sorensen

Messages: 2
Registered: July 2009

Junior Member

Quote:

I am not sure this is the correct forum

well given the number of replies, I think I can figure this out myself.

I created a bug report instead:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=295059

have fun
Henrik

Report message to a moderator

Previous Topic:	Cannot see image decorator
Next Topic:	Re: Looking for JFace Databinding Approach

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Apr 24 19:10:21 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter