| Feedback line on a move (BUGFIX) [message #489768] |
Mon, 05 October 2009 20:17  |
|
Hi,
In GMF recipes (http://wiki.eclipse.org/GMF/Recipes), in the example of move a child there is a TODO :
[CODE
]//TODO ev. reintroduce target feedback (actual problem: line is not deleted after dropping)
eraseLayoutTargetFeedback(null);
[/CODE]
I found why the layoutTargetFeedback was not deleted :
To do the move a ChangeBoundRequest is created using REQ_DROP as type.
But in LayoutEditPolicy.eraseTargetFeedback()
The feedback is erased dependly and conditionnally of the Request type and our case case is not handle.
The cases arez all taken from GEF RequestConstants although REQ_DROP is part of GMF RequestConstants.
Now I don't know what would be the best way to correct this bug :
- integrate the REQ_DROP inside GEF RequestConstants and add this case in LayoutEditPolicy.eraseTargetFeedback (GEF)
- only add this case in LayoutEditPolicy.eraseTargetFeedback (GEF)
- override erasetargetFeedback in each GMF layoutEditPolicy (ToolbarLayoutPolicy, FlowLayoutPolicy,...)
- only update the wiki and add the override of eraseTargetFeedback
What do you think about it?
And, a while ago, I thought the related bug for this was : http://bugs.eclipse.org/bugs/show_bug.cgi?id=276033
But it tells in it that it didn't happen at each time...
So is there already a bug open? (I didn't find yet)
Regards,
Aurelien Pupier
Aurélien Pupier - Red Hat
Senior Software Engineer in Fuse Tooling team
|
|
|
| Re: Feedback line on a move (BUGFIX) [message #489845 is a reply to message #489768] |
Tue, 06 October 2009 08:38  |
 Mariot Chauvin
Messages: 174
Registered: July 2009 |
Senior Member |
|
|
Hi Aurelien,
Comments below.
Aurelien Pupier a écrit :
> Hi,
>
> In GMF recipes (http://wiki.eclipse.org/GMF/Recipes), in the example of
> move a child there is a TODO :
> [CODE
> ]//TODO ev. reintroduce target feedback (actual problem: line is not
> deleted after dropping)
> eraseLayoutTargetFeedback(null);
> [/CODE]
>
> I found why the layoutTargetFeedback was not deleted :
> To do the move a ChangeBoundRequest is created using REQ_DROP as type.
>
> But in LayoutEditPolicy.eraseTargetFeedback()
> The feedback is erased dependly and conditionnally of the Request type
> and our case case is not handle.
> The cases arez all taken from GEF RequestConstants although REQ_DROP is
> part of GMF RequestConstants.
>
Thanks for taking to time to debug it !
> Now I don't know what would be the best way to correct this bug :
> - integrate the REQ_DROP inside GEF RequestConstants and add this case
> in LayoutEditPolicy.eraseTargetFeedback (GEF)
REQ_DROP is only used in GMF so I think it should not be moved in GEF RequestConstants.
> - only add this case in LayoutEditPolicy.eraseTargetFeedback (GEF)
If REQ_DROP is defined in GEF RequestConstants it will not be possible.
> - override erasetargetFeedback in each GMF layoutEditPolicy
> (ToolbarLayoutPolicy, FlowLayoutPolicy,...)
That seems to me the best to do. We could add a GMF LayoutEditPolicy abstract class which only overrides GEF LayoutEditPolicy#eraseTargetFeedback.
> - only update the wiki and add the override of eraseTargetFeedback
>
> What do you think about it?
>
> And, a while ago, I thought the related bug for this was :
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=276033
> But it tells in it that it didn't happen at each time...
> So is there already a bug open? (I didn't find yet)
>
I think http://bugs.eclipse.org/bugs/show_bug.cgi?id=276033 is the appropriate bug.
I will investigate this week.
>
> Regards,
>
> Aurelien Pupier
>
Best Regards,
Mariot
|
|
|
| Re: Feedback line on a move (BUGFIX) [message #489847 is a reply to message #489845] |
Tue, 06 October 2009 08:55 |
|
| Mariot Chauvin wrote on Tue, 06 October 2009 04:38 |
Thanks for taking to time to debug it !
|
| Mariot Chauvin wrote on Tue, 06 October 2009 04:38 |
> - override erasetargetFeedback in each GMF layoutEditPolicy
> (ToolbarLayoutPolicy, FlowLayoutPolicy,...)
That seems to me the best to do. We could add a GMF LayoutEditPolicy abstract class which only overrides GEF LayoutEditPolicy#eraseTargetFeedback.
|
I also think that it is the best way.
Regards,
Aurelien Pupier
Aurélien Pupier - Red Hat
Senior Software Engineer in Fuse Tooling team
|
|
|
Powered by
FUDForum. Page generated in 1.42829 seconds
] 
Search
Help
Register
Login
Home
