| Enhancement suggestions for the WithId matcher [message #488943] |
Wed, 30 September 2009 15:24 |
Eclipse User |
|
|
|
(1) org.eclipse.swtbot.swt.finder.matchers.WithId<T> assumes that both
key and value are of type String. But since
org.eclipse.swt.widgets.Widget.getData(String) returns an Object, WithId
should also work with values of type Object.
(2) WithId does not work with Widget.getData() (the version with no
parameters). It only looks for key-value pair type data. There should be
a variation of WithId that tries to match with the value in
Widget.getData().
WithId.withId(String) currently uses the default key
(SWTBotPreferences.DEFAULT_KEY). But I think it is more appropriate that
this variation of the withId() method should use Widget.getData().
If you agree to the proposed changes, I can provide a patch, including
test cases.
- Vasanth
|
|
|
Powered by
FUDForum. Page generated in 0.03948 seconds
Home