Eclipse Community Forums: Standard Widget Toolkit (SWT) » New Data binding: Missing event deregistration?

Help

Home

Home » Eclipse Projects » Standard Widget Toolkit (SWT) » New Data binding: Missing event deregistration?

Show: Today's Messages :: Show Polls :: Message Navigator

New Data binding: Missing event deregistration? [message #465784]

Tue, 20 December 2005 13:37

Daniel KrÃ¼gler

Messages: 853
Registered: July 2009

Senior Member

Hello,

I am just studying the new and very promising data binding
library. In org.eclipse.jface.databinding.internal.NestedUpdatableValue
I stumbled across the c'tor:

public NestedUpdatableValue(IDataBindingContext databindingContext,
final IUpdatableValue outerUpdatableValue,
Object feature, Class featureType) {
this.databindingContext = databindingContext;
this.feature = feature;
this.featureType = featureType;
updateInnerUpdatableValue(outerUpdatableValue);
IChangeListener outerChangeListener = new IChangeListener() {
public void handleChange(ChangeEvent changeEvent) {
Object oldValue = getValue();

updateInnerUpdatableValue(outerUpdatableValue);
fireChangeEvent(ChangeEvent.CHANGE, oldValue, getValue());
}
};
outerUpdatableValue.addChangeListener(outerChangeListener);
}

which registers an IChangeListener on its argument outerUpdatableValue.
According to usual resource management rules, the class
NestedUpdatableValue should ensure that removeChangeListener is
correctly envoked, but I could not find any corresponding
deregistration. Is this a bug or just my ignorance?

Greetings from Bremen,

Daniel Krügler

Report message to a moderator