Eclipse Community Forums: Rich Client Platform (RCP) » Can FindReplaceAction use IFindReplaceTarget.isEditable?

Help

Home

Home » Eclipse Projects » Rich Client Platform (RCP) » Can FindReplaceAction use IFindReplaceTarget.isEditable?

Show: Today's Messages :: Show Polls :: Message Navigator

Can FindReplaceAction use IFindReplaceTarget.isEditable? [message #464451]

Wed, 07 March 2007 03:08

Peter Nehrer

Messages: 241
Registered: July 2009

Senior Member

Hi,

is there any reason why FindReplaceAction uses the part's
ITextEditorExtension2.isEditorInputModifiable instead of
IFindReplaceTarget.isEditable to determine whether to enable replacing?
In 3.3 it was patched to do just that, but only if used with a Shell and
not IWorkbenchPart. Using IFindReplaceTarget.isEditable would make it
possible to provide Find/Replace support for non-text editors (if they
know how to produce a valid adapter). Any insight would be appreciated.
Thanks.

--Peter

Report message to a moderator

Re: Can FindReplaceAction use IFindReplaceTarget.isEditable? [message #464594 is a reply to message #464451]

Mon, 12 March 2007 12:18

Dani Megert

Messages: 3802
Registered: July 2009

Senior Member

Peter Nehrer wrote:

> Hi,
>
> is there any reason why FindReplaceAction uses the part's
> ITextEditorExtension2.isEditorInputModifiable instead of
> IFindReplaceTarget.isEditable to determine whether to enable
> replacing? In 3.3 it was patched to do just that, but only if used
> with a Shell and not IWorkbenchPart. Using
> IFindReplaceTarget.isEditable would make it possible to provide
> Find/Replace support for non-text editors (if they know how to produce
> a valid adapter). Any insight would be appreciated. Thanks.

If the part is a text editor (implements ITextEditorExtension2 to be
more precise) it has to go through the more specific code. I've now
fixed the code to use IFindReplaceTarget.isEditable() if the part isn't
a ITextEditorExtension2.

HTH
Dani

>
> --Peter

Report message to a moderator