| [EMF Index] Re: A proposal for improving the WorkspaceSynchronizer. [message #442041] |
Fri, 31 July 2009 11:44 |
 Juergen Aschenbrenner
Messages: 25
Registered: July 2009 |
Junior Member |
|
|
done,
BTW couldn't help but noticing that there exists some commonalities
between WorkspaceSynchronizer and the EMF Index effort.
The WS falls short notifying events connected to resources added to the
workspace.
Maybe the WS would be more useful when it would no be final and one
could avoid editor inheritance in order to extend it.
Cheers
Juergen
Boris Gruschko schrieb:
> Hi Juergen,
>
> could you please file a bug on EMF Transaction.
>
> I'll have to evaluate the impact of the proposed change.
>
> Thanks,
> Boris
>
> "Juergen Aschenbrenner" <juergen.aschenbrenner@gmail.com> wrote in
> message news:h4ubcp$5ep$1@build.eclipse.org...
>> When deleting a resource from workspace, the workspace synchronizer
>> will fire handleResourceChanged events events on all resources though
>> they havent been changed.
>>
>> This is because in the workspace synchronizer in the processDelta
>> operation in the IResourceDelta.CHANGED case does not check if the
>> contents actually have been changed.
>>
>> I find this a bit myself esoteric but it seems thats the eay how
>> resource change events work with eclipse: When a resource is deleted
>> the ResourcePlugin puts the entire workspace into the resource delta
>> one is required to visit in order to figure out in what the actual
>> change consists in.
>>
>> To check if a resource has actualy changed on has the check
>>
>> if ((delta.getFlags() & IResourceDelta.CONTENT) != 0) [1]
>>
>> This would avoid a lot of unload and reload operations, especialy when
>> it comes to GMF after a diagram is deleted and this events ripples
>> through all editing domains with their attached resource sets causing
>> the lag
>>
>>
>>
>> [1]
>> http://www.eclipse.org/articles/Article-Resource-deltas/reso urce-deltas.html
>
>
|
|
|
Powered by
FUDForum. Page generated in 0.01296 seconds
] 
Search
Help
Register
Login
Home
