|
| Re: [CDO] CDOStore - Question [message #422509 is a reply to message #422505] |
Mon, 08 September 2008 07:16   |
|
Hi Simon,
At a first glance it looks like a bug that it is missing in CDOStore.set().
I only wonder why no test has caught this...
Do you have an example of misbehaviour?
Cheers
/Eike
Simon McDuff schrieb:
> Hi Eike,
>
> I noticed in CDOStore that:
>
> - When CDOStore.add is called we convert the new value by calling
> convertObjectToID.
> - When we attach an object to view we will call convertObjectToID for every
> attributes.
>
> - When CDOStore.set is called... we do not call convertObjectToID.
>
> I know at the end we will call provideCDOID... but do we have a reason why
> we do not call convertObjectToID ?
>
> Thank you
>
> Simon
>
>
>
>
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
|
|
| Re: [CDO] CDOStore - Question [message #422529 is a reply to message #422528] |
Mon, 08 September 2008 16:08 |
|
Simon McDuff schrieb:
> Testcase will not get that since the behavior will be as expected since in
> commit process we convert it in CDOID.
>
> The only problem it will occured is if the refer object is already
> persisted.... we cannot garbage collect that object :-(
>
> I will add a testcase and a bugzilla entry for that. Ok ?
>
Yes, that's fine.
Thx
/Eike
>
> "Eike Stepper" <stepper@esc-net.de> a écrit dans le message de news:
> ga2jhf$il6$3@build.eclipse.org...
>
>> Hi Simon,
>>
>> At a first glance it looks like a bug that it is missing in
>> CDOStore.set().
>> I only wonder why no test has caught this...
>> Do you have an example of misbehaviour?
>>
>> Cheers
>> /Eike
>>
>>
>> Simon McDuff schrieb:
>>
>>> Hi Eike,
>>>
>>> I noticed in CDOStore that:
>>>
>>> - When CDOStore.add is called we convert the new value by calling
>>> convertObjectToID.
>>> - When we attach an object to view we will call convertObjectToID for
>>> every attributes.
>>>
>>> - When CDOStore.set is called... we do not call convertObjectToID.
>>>
>>> I know at the end we will call provideCDOID... but do we have a reason
>>> why we do not call convertObjectToID ?
>>>
>>> Thank you
>>>
>>> Simon
>>>
>>>
>>>
>>>
>>>
>
>
>
Cheers
/Eike
----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper
|
|
|
Powered by
FUDForum. Page generated in 0.03239 seconds
] 
Search
Help
Register
Login
Home
