Eclipse Community Forums: EMF » Validation constraints on annotated Java

Help

Home

Home » Modeling » EMF » Validation constraints on annotated Java

Show: Today's Messages :: Show Polls :: Message Navigator

Validation constraints on annotated Java [message #420870]

Tue, 15 July 2008 12:43

J F

Messages: 256
Registered: July 2009

Senior Member

Hi,

I tried following the tutorial on the EMF Validation framework at
http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclips e.emf.doc/references/overview/EMF.Validation.html

I created a dymmy project based on the annotated Java Library example and
annotated my Library as follows;

/**
* @model
annotation="http://www.eclipse.org/emf/2002/Ecore
constraints='NonNegativeQuantity ValidShipDate'"

*/
public interface Library extends EObject
{
/**
* @model
*/
String getName();

/**
* Sets the value of the '{@link model.Library#getName Name}'
attribute.
* 
* 
* @param value the new value of the 'Name' attribute.
* @see #getName()
* @generated
*/
void setName(String value);

/**
* @model type="Writer" containment="true"
*/
EList getWriters();

/**
* @model type="Book" containment="true"
*/
EList getBooks();

/**
* @model
*/
boolean hasUSState(
DiagnosticChain diagnostics,
Map context);

}

This leads to a single validator for the whole model being generated ( not
one per interface ). Also there is nothing generated for the constraints
that I can see.

Is this what is meant to occur now? i.e. If I want to do something special
I just override methods in the single package level validator?

Thanks

Report message to a moderator

Re: Validation constraints on annotated Java [message #420871 is a reply to message #420870]

Tue, 15 July 2008 12:50

Eclipse User

Originally posted by: cdamus.zeligsoft.com

--=-6Q0hJF0iPQMxaNVTm/EU
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi, JF,

That is correct. All of the constraints in your package are generated
into a single validator class (like the single package, factory, switch,
adapter factory, etc.).

Just fill in the TODOs in the methods in your generated validator and
remember to mark them @generated NOT

HTH,

Christian

On Tue, 2008-07-15 at 12:43 +0000, JF wrote:

> Hi,
>
> I tried following the tutorial on the EMF Validation framework at
> http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclips e.emf.doc/references/overview/EMF.Validation.html
>
> I created a dymmy project based on the annotated Java Library example and
> annotated my Library as follows;
>
>
> /**
> * @model
> annotation="http://www.eclipse.org/emf/2002/Ecore
> constraints='NonNegativeQuantity ValidShipDate'"
>
> */
> public interface Library extends EObject
> {
> /**
> * @model
> */
> String getName();
>
> /**
> * Sets the value of the '{@link model.Library#getName Name}'
> attribute.
> * 
> * 
> * @param value the new value of the 'Name' attribute.
> * @see #getName()
> * @generated
> */
> void setName(String value);
>
> /**
> * @model type="Writer" containment="true"
> */
> EList getWriters();
>
> /**
> * @model type="Book" containment="true"
> */
> EList getBooks();
>
> /**
> * @model
> */
> boolean hasUSState(
> DiagnosticChain diagnostics,
> Map context);
>
> }
>
>
> This leads to a single validator for the whole model being generated ( not
> one per interface ). Also there is nothing generated for the constraints
> that I can see.
>
> Is this what is meant to occur now? i.e. If I want to do something special
> I just override methods in the single package level validator?
>
> Thanks
>

--=-6Q0hJF0iPQMxaNVTm/EU
Content-Type: text/html; charset=utf-8

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.16.0">
</HEAD>
<BODY>
Hi, JF, 
 
That is correct.  All of the constraints in your package are generated into a single validator class (like the single package, factory, switch, adapter factory, etc.). 
 
Just fill in the TODOs in the methods in your generated validator and remember to mark them @generated NOT 
 
HTH, 
 
Christian 
 
On Tue, 2008-07-15 at 12:43 +0000, JF wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Hi, 

I tried following the tutorial on the EMF Validation framework at 
<A HREF=" http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclips e.emf.doc/references/overview/EMF.Validation.html"> http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclips e.emf.doc/references/overview/EMF.Validation.html</A>

I created a dymmy project based on the annotated Java Library example and 
annotated my Library as follows;

/**
 * @model 
 annotation="<A HREF="http://www.eclipse.org/emf/2002/Ecore">http://www.eclipse.org/emf/2002/Ecore</A> 
 constraints='NonNegativeQuantity ValidShipDate'"

 */
public interface Library extends EObject
{
 /**
 * @model
 */
 String getName();

 /**
 * Sets the value of the '{@link model.Library#getName Name}' 
attribute.
 * 
 * 
 * @param value the new value of the 'Name' attribute.
 * @see #getName()
 * @generated
 */
 void setName(String value);

 /**
 * @model type="Writer" containment="true"
 */
 EList getWriters();

 /**
 * @model type="Book" containment="true"
 */
 EList getBooks();
 
 /**
 * @model
 */
 boolean hasUSState(
 DiagnosticChain diagnostics, 
 Map context);

}

This leads to a single validator for the whole model being generated ( not 
one per interface ). Also there is nothing generated for the constraints 
that I can see.

Is this what is meant to occur now? i.e. If I want to do something special 
I just override methods in the single package level validator?

Thanks

</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>

--=-6Q0hJF0iPQMxaNVTm/EU--

Report message to a moderator

Re: Validation constraints on annotated Java [message #420872 is a reply to message #420871]

Tue, 15 July 2008 12:55

J F

Messages: 256
Registered: July 2009

Senior Member

Thanks...

So the

@model annotation="http://www.eclipse.org/emf/2002/Ecore
constraints='NonNegativeQuantity ValidShipDate'"

stuff is obsolete? - I don't get a Validator for the annotated class in
the generated util directory, with a method per constraint name?

What is the relationship of this with the validation framework?

Report message to a moderator

Re: Validation constraints on annotated Java [message #420874 is a reply to message #420872]

Tue, 15 July 2008 13:03

Eclipse User

Originally posted by: cdamus.zeligsoft.com

--=-o4/ozQ4W7jNapWpDdTXy
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi, JF,

These annotations aren't obsolete. As far as I know, you should be
getting a validator in your model's *.util package. Perhaps Ed would be
able to advise on why this doesn't seem to be working.

This *is* the intrinsic (generative) validation framework provided by
the EMF Core component. The EMF Validation Framework component (the
separate one) provides an altogether different solution based on
contribution of constraints externally to the model definition.

Cheers,

Christian

On Tue, 2008-07-15 at 12:55 +0000, JF wrote:

> Thanks...
>
> So the
>
> @model annotation="http://www.eclipse.org/emf/2002/Ecore
> constraints='NonNegativeQuantity ValidShipDate'"
>
>
> stuff is obsolete? - I don't get a Validator for the annotated class in
> the generated util directory, with a method per constraint name?
>
> What is the relationship of this with the validation framework?
>

--=-o4/ozQ4W7jNapWpDdTXy
Content-Type: text/html; charset=utf-8

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.16.0">
</HEAD>
<BODY>
Hi, JF, 
 
These annotations aren't obsolete.  As far as I know, you should be getting a validator in your model's *.util package.  Perhaps Ed would be able to advise on why this doesn't seem to be working. 
 
This *is* the intrinsic (generative) validation framework provided by the EMF Core component.  The EMF Validation Framework component (the separate one) provides an altogether different solution based on contribution of constraints externally to the model definition. 
 
Cheers, 
 
Christian 
 
On Tue, 2008-07-15 at 12:55 +0000, JF wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Thanks...

So the

@model annotation="<A HREF="http://www.eclipse.org/emf/2002/Ecore">http://www.eclipse.org/emf/2002/Ecore</A> 
 constraints='NonNegativeQuantity ValidShipDate'"

stuff is obsolete? - I don't get a Validator for the annotated class in 
the generated util directory, with a method per constraint name?

What is the relationship of this with the validation framework?

</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>

--=-o4/ozQ4W7jNapWpDdTXy--

Report message to a moderator

Re: Validation constraints on annotated Java [message #420875 is a reply to message #420874]

Tue, 15 July 2008 13:09

J F

Messages: 256
Registered: July 2009

Senior Member

Thanks Christian,

I don't seem to be getting the ***Validator class generated.

I started with the Empty EMF Project wizard, copied across the Java
interfaces from the library example, added the invariant method and
constraint annotation from the tutorial to the Library interface, as per
the code I posted, and nothing is being generated ...

BTW, I don't want to use the annotated Java, I would prefer to add
annotations directly to my EClass model which I extract from somewhere
else, I was trying to find out what "shape" the annotations would look
like in the ecore model, but ofcourse these don't seem to be generated
either. I'd be grateful of any hints, thanks...

Report message to a moderator

Re: Validation constraints on annotated Java [message #420876 is a reply to message #420875]

Tue, 15 July 2008 13:47

J F

Messages: 256
Registered: July 2009

Senior Member

Hi,

It seems to have been a problem with whitespace or new lines during the
annotation parsing, as I now get code for the constraints, though always
in the single ***Validator class in the generated util directory. My
source code level is antediluvian at 1.4 , so is that a possibel problem?

Report message to a moderator

Re: Validation constraints on annotated Java [message #420878 is a reply to message #420876]

Tue, 15 July 2008 13:51

Ed Merks

Messages: 33141
Registered: July 2009

Senior Member

JF,

It's supposed to generate a single validator. That validator traverses
the model hierarchy to enforce each constraint. There are also
invariants you can define that are generated as methods on the actual
instance classes...

JF wrote:
> Hi,
>
> It seems to have been a problem with whitespace or new lines during
> the annotation parsing, as I now get code for the constraints, though
> always in the single ***Validator class in the generated util
> directory. My source code level is antediluvian at 1.4 , so is that a
> possibel problem?
>

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator