Eclipse Community Forums: EMF » Default child creation setting for [1] Containment reference

Help

Home

Home » Modeling » EMF » Default child creation setting for [1] Containment reference

Show: Today's Messages :: Show Polls :: Message Navigator

Default child creation setting for [1] Containment reference [message #417165]

Thu, 28 February 2008 15:30

Eclipse User

Originally posted by: cdamus.ca.ibm.com

Hi,

I am seeing, in importing a generator model, that for containment
EReferences that have multiplicity 1, the "Edit / Children" and "Edit /
Create Child" properties default to false.

As expected, when I generate my edit plug-in, the item provider for my
EClass doesn't have a new-child-descriptor for this EReference. However,
when I run the generated editor, I get a New Child menu item to create the
contained object in this EReference.

Why does this seem to work? Should I set my Children and Create Child
properties to true anyway? Or would that break something else?

Thanks,

Christian

Report message to a moderator

Re: Default child creation setting for [1] Containment reference [message #417166 is a reply to message #417165]

Thu, 28 February 2008 16:05

Ed Merks

Messages: 33140
Registered: July 2009

Senior Member

This is a multi-part message in MIME format.
--------------060804050700040401020102
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Christian,

I'm not seeing that. Are you sure you didn't just change the model from
non-containment to containment after the fact? You can verify that the
multiplicity is not considered when initializing a new GenFeature:

| *public **void *initialize(EStructuralFeature eFeature)
{
*if *(eFeature != getEcoreFeature())
{
setEcoreFeature(eFeature);

*if *(eFeature *instanceof *EReference)
{
EReference eReference = (EReference)eFeature;
*if *(!eReference.isContainer() && !eReference.isContainment())
{
setProperty(eFeature.isChangeable() ? GenPropertyKind.EDITABLE_LITERAL : GenPropertyKind.READONLY_LITERAL);
}
*else*
{
setProperty(GenPropertyKind.NONE_LITERAL);
}
setChildren
(eReference.isContainment() &&
(getGenClass().isDocumentRoot() ?
getExtendedMetaData().getFeatureKind(eFeature) == ExtendedMetaData.ELEMENT_FEATURE :
!hasDelegateFeature()));
setCreateChild(isChildren() && isChangeable());
setNotify(isChildren());
}
*else if *(isFeatureMapType())
{
setProperty(GenPropertyKind.NONE_LITERAL);
setChildren(!getGenClass().isDocumentRoot() && !hasDelegateFeature());
setCreateChild(isChildren() && isChangeable());
setNotify(isChildren());
}
*else*
{
setProperty(eFeature.isChangeable() ? GenPropertyKind.EDITABLE_LITERAL : GenPropertyKind.READONLY_LITERAL);
setChildren(*false*);
setCreateChild(*false*);
setNotify(*true*);
}

*if *(getProperty() == GenPropertyKind.EDITABLE_LITERAL && isReferenceType())
{
setPropertySortChoices(*true*);
}
}
}|

You're not having an extended lunch break are you? :-P

Christian W. Damus wrote:
> Hi,
>
> I am seeing, in importing a generator model, that for containment
> EReferences that have multiplicity 1, the "Edit / Children" and "Edit /
> Create Child" properties default to false.
>
> As expected, when I generate my edit plug-in, the item provider for my
> EClass doesn't have a new-child-descriptor for this EReference. However,
> when I run the generated editor, I get a New Child menu item to create the
> contained object in this EReference.
>
> Why does this seem to work? Should I set my Children and Create Child
> properties to true anyway? Or would that break something else?
>
> Thanks,
>
> Christian
>

--------------060804050700040401020102
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Christian, 
 
I'm not seeing that.  Are you sure you didn't just change the model
from non-containment to containment after the fact?  You can verify
that the multiplicity is not considered when initializing a new
GenFeature: 
<blockquote>
<title></title>
<style type="text/css">

</style>
<meta http-equiv="Content-Type"
content="text/html; charset=iso-8859-1">


<div class="java" align="left">
<table bgcolor="#ffffff" border="0" cellpadding="3" cellspacing="0">
<tbody>
<tr>
 <td align="left" nowrap="nowrap"
valign="top"> <code>  public void initialize(EStructuralFeature eFeature) 
  { 
    if (eFeature != getEcoreFeature ()) 
    { 
        setEcoreFeature(eFeature); 
   
        if (eFeature instanceof EReference) 
        { 
           EReference eReference =  (EReference)eFeature; 
           if (!eReference.isContainer() && !eReference.isContainment ()) 
           { 
             setProperty(eFeature.isChangeable()  ? GenPropertyKind.EDITABLE_LITERAL :&n bsp;GenPropertyKind.READONLY_LITERAL ); 
           } 
           else 
           { 
             setProperty(GenPropertyKind.NONE_LITERAL); 
           } 
           setChildren 
             (eReference.isContainment() &&  
                 (getGenClass().isDocumentRoot() ?  
                    getExtendedMetaData().getFeatureKind(eFeature)  == ExtendedMetaData.ELEMENT_FEATURE :& nbsp; 
                    !hasDelegateFeature())); 
           setCreateChild(isChildren() && isChangeable()); 
           setNotify(isChildren()); 
        } 
        else if (isFeatureMapType()) 
        { 
           setProperty(GenPropertyKind.NONE_LITERAL); 
           setChildren(!getGenClass().isDocumentRoot() && !hasDelegateFeature ()); 
           setCreateChild(isChildren() && isChangeable()); 
           setNotify(isChildren()); 
        } 
        else 
        { 
           setProperty(eFeature.isChangeable()  ? GenPropertyKind.EDITABLE_LITERAL :&n bsp;GenPropertyKind.READONLY_LITERAL ); 
           setChildren(false); 
           setCreateChild(false); 
           setNotify(true); 
        } 
 
        if (getProperty()  == GenPropertyKind.EDITABLE_LITERAL &a mp;& isReferenceType ()) 
        { 
           setPropertySortChoices(true); 
        } 
    } 
  }</code>
</td>
 </tr>
</tbody>
</table>
</div>

</blockquote>
You're not having an extended lunch break are you?  :-P 
 
 
Christian W. Damus wrote:
<blockquote cite="mid:fq6lk7$tdt$1@build.eclipse.org" type="cite">
<pre wrap="">Hi,

I am seeing, in importing a generator model, that for containment
EReferences that have multiplicity 1, the "Edit / Children" and "Edit /
Create Child" properties default to false.

As expected, when I generate my edit plug-in, the item provider for my
EClass doesn't have a new-child-descriptor for this EReference. However,
when I run the generated editor, I get a New Child menu item to create the
contained object in this EReference.

Why does this seem to work? Should I set my Children and Create Child
properties to true anyway? Or would that break something else?

Thanks,

Christian
</pre>
</blockquote>
 
</body>
</html>

--------------060804050700040401020102--

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Default child creation setting for [1] Containment reference [message #417181 is a reply to message #417166]

Thu, 28 February 2008 19:55

Eclipse User

Originally posted by: cdamus.ca.ibm.com

Hi, Ed,

I'm batting a pretty low average, lately.

I thought this might have something to do with the UML model importer, but
it's just an extended lunch break, as you say. I must have had this
genmodel before my property changed to composite aggregation, and reloading
the genmodel didn't change the edit attributes.

The funny thing is, that the generated code has providers that don't seem to
create all of the new-child-descriptors that I see in the editor. I guess
something reflective is kicking in to save the day.

I'll fix my genmodel.

Thanks!

Christian

Ed Merks wrote:

> Christian,
>
> I'm not seeing that. Are you sure you didn't just change the model from
> non-containment to containment after the fact? You can verify that the
> multiplicity is not considered when initializing a new GenFeature:

-----8<-----

> You're not having an extended lunch break are you? :-P
>
>
> Christian W. Damus wrote:
>> Hi,
>>
>> I am seeing, in importing a generator model, that for containment
>> EReferences that have multiplicity 1, the "Edit / Children" and "Edit /
>> Create Child" properties default to false.
>>
>> As expected, when I generate my edit plug-in, the item provider for my
>> EClass doesn't have a new-child-descriptor for this EReference. However,
>> when I run the generated editor, I get a New Child menu item to create
>> the contained object in this EReference.
>>
>> Why does this seem to work? Should I set my Children and Create Child
>> properties to true anyway? Or would that break something else?
>>
>> Thanks,
>>
>> Christian
>>

Report message to a moderator

Previous Topic:	Load a Model Read Only
Next Topic:	Updating the properties view?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 12:00:20 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter