Eclipse Community Forums: SWTBot » Toggle Button isn't checked

Help

Home

Home » Eclipse Projects » SWTBot » Toggle Button isn't checked

Show: Today's Messages :: Show Polls :: Message Navigator

Toggle Button isn't checked [message #41989]

Tue, 07 July 2009 09:46

Benjamin Glaser

Messages: 17
Registered: July 2009

Junior Member

Hi everyone,

Im new to SWTBot and Im trying to test an RCP application.
The application has a toogle-button in a coolbar.
Im able to find the widget and performe a click() on it:

bot.viewByTitle("title").toolbarButton("tooltip").click();

But I dont get it working that the toggle-button is checked after the
click.

My application checks if button.isChecked() and if not it wont work as
expected.

I searched the web and the newsgroup and found, that toggle-buttons are
supported by SWTBot according to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=269919

Im running the latest nightly build of SWTBot.

What do you think is my fault?

Thank you
Benjamin

Report message to a moderator

Re: Toggle Button isn't checked [message #42116 is a reply to message #41989]

Tue, 07 July 2009 18:15

Derek

Messages: 30
Registered: July 2009

Member

Benjamin Glaser wrote:

> bot.viewByTitle("title").toolbarButton("tooltip").click();

To select checkboxes I have used:

bot.checkBox("Title").select();

and similarly to uncheck the checkbox:

bot.checkBox("Title").deselect();

~Derek

Report message to a moderator

Re: Toggle Button isn't checked [message #42147 is a reply to message #42116]

Tue, 07 July 2009 18:22

Derek

Messages: 30
Registered: July 2009

Member

Derek wrote:

> Benjamin Glaser wrote:

>> bot.viewByTitle("title").toolbarButton("tooltip").click();

> To select checkboxes I have used:

> bot.checkBox("Title").select();

> and similarly to uncheck the checkbox:

> bot.checkBox("Title").deselect();

Oops, I don't think I read that enough. I saw you say something about
"Toggle" and instantly thought of a checkbox.

For toolbar I've just used:

bot.toolbarButton("ButtonTitle").click();

~Derek

Report message to a moderator

Re: Toggle Button isn't checked [message #42234 is a reply to message #42147]

Wed, 08 July 2009 06:49

Benjamin Glaser

Messages: 17
Registered: July 2009

Junior Member

> For toolbar I've just used:
> bot.toolbarButton("ButtonTitle").click();
> ~Derek

Hi Derek,

thanks for your fast reply.

Your suggestion is almont the same way I tried to handle it.
xxx.click() works so far for me, that it does perform a click.

But that click don't sets the toggle-button-state to "checked", as a
normal mouseclick by an user does.

It would be great if SWTBot sets the toggleButton to checked after it as
been clicked, but in my case it won't work.

Any suggestions?

Benjamin

Report message to a moderator

Re: Toggle Button isn't checked [message #42271 is a reply to message #42234]

Wed, 08 July 2009 10:54

Ketan Padegaonkar

Messages: 873
Registered: July 2009

Senior Member

Please file a bug, and I'll take a look at it. It would be great if you
could submit a patch for doing so. You may look at an existing
SWTBotToolbarButton implementation on how this is done.

--
Ketan
http://studios.thoughtworks.com/twist | http://twitter.com/ketanpkr

On 8/7/09 12:19, Benjamin Glaser wrote:
>> For toolbar I've just used:
>> bot.toolbarButton("ButtonTitle").click();
>> ~Derek
>
> Hi Derek,
>
> thanks for your fast reply.
>
> Your suggestion is almont the same way I tried to handle it.
> xxx.click() works so far for me, that it does perform a click.
>
> But that click don't sets the toggle-button-state to "checked", as a
> normal mouseclick by an user does.
>
> It would be great if SWTBot sets the toggleButton to checked after it as
> been clicked, but in my case it won't work.
>
> Any suggestions?
>
> Benjamin
>
>
>
>

Report message to a moderator

Re: Toggle Button isn't checked [message #42295 is a reply to message #42271]

Wed, 08 July 2009 12:18

Pascal G

Messages: 157
Registered: July 2009

Senior Member

Ketan Padegaonkar wrote:
> Please file a bug, and I'll take a look at it. It would be great if you
> could submit a patch for doing so. You may look at an existing
> SWTBotToolbarButton implementation on how this is done.
>

Maybe a solution would be to make the click() method use the
Display.post()? Or maybe give an API to leave the choice to the
programmer, such as click(boolean)? Then you wouldn't even need to
replicate the behavior of the button(s).

--
Pascal Gélinas | Software Developer
*Nu Echo Inc.*
http://www.nuecho.com/ | http://blog.nuecho.com/

*Because performance matters.*

Report message to a moderator

Re: Toggle Button isn't checked [message #42500 is a reply to message #42271]

Thu, 09 July 2009 09:11

Benjamin Glaser

Messages: 17
Registered: July 2009

Junior Member

I made a bug report:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=282982

I hope I described it enough.

What else can I do?

Benjamin

Report message to a moderator

Re: Toggle Button isn't checked [message #43394 is a reply to message #42500]

Tue, 14 July 2009 09:21

Benjamin Glaser

Messages: 17
Registered: July 2009

Junior Member

Hi Ketan,

thanks again for the quick bug fixing.
But it doesn't solve my issue completely.

I looked at the sourcecode you implemented:

notify(SWT.MouseEnter);
notify(SWT.MouseMove);
notify(SWT.Activate);
notify(SWT.MouseDown); //think this does the actual click
notify(SWT.MouseUp);
notify(SWT.Selection);
notify(SWT.MouseHover);
notify(SWT.MouseMove);
notify(SWT.MouseExit);
notify(SWT.Deactivate);
notify(SWT.FocusOut);
internalToggle(); // sets the button-state to checked

If I click on a button, the run() methode which is definied for this
button is called. This methode checks the state of the button.
But the state wasn't changed at this moment because it is changed after
the actual click.

I would recommend to do the internalToggle() before the notify(...).
I changed it in my code and now it works for me.
I think it would be helpful for other users too.

What do you think?

Benjamin

Report message to a moderator

Previous Topic:	Custom Widgets
Next Topic:	CTabItem

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Apr 23 11:21:18 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter