Eclipse Community Forums: EMF » CopyToClipboardCommand makes editor dirty

Home » Modeling » EMF » CopyToClipboardCommand makes editor dirty(Using the EMF CopyAction in a tree and the WorkspaceCommandStack makes the editor dirty)

Show: Today's Messages :: Show Polls :: Message Navigator

CopyToClipboardCommand makes editor dirty [message #1814570]

Fri, 13 September 2019 11:33

Marcus Höpfner

Messages: 56
Registered: February 2014

Member

Hi,

we are using TransactionalEditingDomain with a WorkspaceCommandStack.
org.eclipse.emf.edit.ui.action.CopyAction (or the used CopyCommand) makes the editor dirty.

In the editor a CommandStackListener is registered. When an event is raised, it tells the editor to check it's dirty property. The editor then calls WorkspaceCommandStack.isSaveNeeded(). Which always returns true, even for a copy command which does not change the editor's content.
In comparison the BasicCommandStack.isSaveNeeded() method asks the command whether it has changed the model.

Are we using some of the above objects in a wrong way or do we just have to create our own CopyAction, which is not added to the CommandStack. I find it weird anyway that a Copy action can be undone.

Thanks, Marcus

Report message to a moderator

Re: CopyToClipboardCommand makes editor dirty [message #1814654 is a reply to message #1814570]

Mon, 16 September 2019 07:16

Marcus Höpfner

Messages: 56
Registered: February 2014

Member

It seems that it was fixed in the BasicCommandStack.isSaveNeeded().

It was a bug in the generated editor as well, then it was discussed here: https://www.eclipse.org/forums/index.php/t/124173/.
And it seems that afterwards the marker interface AbstractCommand.NonDirtying was introduced and used in isSaveNeeded().

Is there something missing in WorkspaceCommandStack? Shall I open a bug?

Report message to a moderator

Re: CopyToClipboardCommand makes editor dirty [message #1814667 is a reply to message #1814654]

Mon, 16 September 2019 08:27

Ed Merks

Messages: 33140
Registered: July 2009

Senior Member

I was using the transactional framework at a customer earlier this year and I don't recall seeing such a problem. But perhaps they specialized it to avoid the problem. I wonder though if you are using the latest version. If so, yes, open a Bugzilla.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator