Eclipse Community Forums: Compare » Unsettable Features

Help

Home

Home » Modeling » Compare » Unsettable Features(Change of unsettable feature not detected)

Show: Today's Messages :: Show Polls :: Message Navigator

Unsettable Features [message #1781361]

Tue, 06 February 2018 12:31

Janik S

Messages: 12
Registered: November 2017

Junior Member

Hey guys,

I just stumbled over an issue, when comparing objects with an unsettable enum feature. If I compare an object with the feature being unset and another object with the feature being set to the default value, no difference is detected.

I have not set an explicit default value in my ecore model, but EMF chooses the first enum literal as a default https://www.eclipse.org/forums/index.php?t=msg&th=168434/

I guess, I can avoid this by explicitly setting the default to null in my model, but shouldn't the diff engine detect such a change?

In our case a default will not be serialized, so I see a difference in the text file but not in the model comparison.

Thanks
Janik

Report message to a moderator

Re: Unsettable Features [message #1781690 is a reply to message #1781361]

Mon, 12 February 2018 08:42

Laurent Goubet

Messages: 1902
Registered: July 2009

Senior Member

Hi Janik,

This is something that's expected : we consider "no value" (unset) and "default value" to be the same when comparing, since that's also how EMF should consider them as a whole. There will be a difference in the serialized file, but the behavior would be the same. EMF Compare focuses on "model" differences, not "textual" ones, so imho the result you get is what EMF Compare is expected to give you.

Laurent Goubet
Obeo

Report message to a moderator

Re: Unsettable Features [message #1784398 is a reply to message #1781690]

Tue, 27 March 2018 15:31

Janik S

Messages: 12
Registered: November 2017

Junior Member

Hey Laurent,

I'm not sure about the EMF philosophy here, but I think this is still dangerous behavior in a merge depending on the model semantics. Your assumption is correct, if the model is considered to never change default values, but I think the "unsettable" feature in EMF was added to exactly allow the distinction between "chose the default" and "chose an explicit value (which can be today equal to the default)". If the default value changes at some point in time, then the model indeed behaves differently for the cases "unset" and "set", so silently treating them the same can lead to unexpected behavior and it is more than just a textual difference.

If the default-value is not allowed to change in a model, then EMF would not need this "unsettable" modeling feature right?

Thanks
Janik

Report message to a moderator

Previous Topic:	EMF Compare 3.2.1 and Oxygen
Next Topic:	Detailed informations on a difference

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 25 20:07:48 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter