Eclipse Community Forums: Oomph » Preferences not updated on restart

Home » Eclipse Projects » Oomph » Preferences not updated on restart(When changing a preference in product.setup it doesn't get updated)

Show: Today's Messages :: Show Polls :: Message Navigator

Preferences not updated on restart [message #1777322]

Tue, 28 November 2017 13:28

Anders Jönsson

Messages: 48
Registered: January 2012

Member

Hi,
I change a preference in the product setup file and the preference is not updated upon a restart of the Eclipse IDE.

If however, I make a clean install of the IDE or even if I just create a new workspace the changed preference is loaded correctly.

Can I make Oomph detect the changed property and run the setup task when Eclipse is restarted?

The preference is a template file and the setup task looks like this:
<setupTask
xsi:type="setup:PreferenceTask"
key="/instance/org.eclipse.cdt.ui/org.eclipse.cdt.ui.text.custom_code_templates"
value="<?xml version="1.0" encoding="UTF-8" standalone="no"?><templates><template autoinsert="false" context="org.eclipse.cdt.ui.text.codetemplates.filecomment_context" deleted="false" description="Comment for created C/C++ files" enabled="true" id="org.eclipse.cdt.ui.text.codetemplates.filecomment" name="filecomment">/* &gt; Copyright XXX AB
 ***********************************************************************************
 * *
 * The copyright to the computer programs herein is the property of... etc, etc... 
 * *
 ***********************************************************************************
 */
 "/>

///Anders

Report message to a moderator

Re: Preferences not updated on restart [message #1777326 is a reply to message #1777322]

Tue, 28 November 2017 13:49

Ed Merks

Messages: 33264
Registered: July 2009

Senior Member

I see it's an XML preference and without specialized merging support, we will not replace an XML value with a different value; that's why it works when you create a new workspace, but not in an existing workspace. So we have

      registry.put(URI.createURI("//instance/org.eclipse.jdt.ui/org.eclipse.jdt.ui.text.custom_code_templates"), new Factory()
      {
        public PreferenceHandler create(URI key)
        {
          return new XMLPreferenceHandler(key, "template", new String[] { "context", "description", "name" }, null);
        }
      });

The last time this issue came up on the forum we talked about some attribute or annotation you could put on the preference task to force it to overwrite the existing preference value (which could replace/overwrite some user's own custom templates)...

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Preferences not updated on restart [message #1777328 is a reply to message #1777326]

Tue, 28 November 2017 14:08

Anders Jönsson

Messages: 48
Registered: January 2012

Member

Thanks,

An option to force a preference to be updated sounds like a good idea.
There could be a difference between overwriting only the "default" preference and to overwrite "everything" including user prefs. I,e, a parameter with two different options.

I believe overwriting everything is the functionality I need.

///Anders

Report message to a moderator

Re: Preferences not updated on restart [message #1777334 is a reply to message #1777328]

Tue, 28 November 2017 15:11

Ed Merks

Messages: 33264
Registered: July 2009

Senior Member

Many of these preferences that are XML-based are effectively lists of things (e.g., named formatter profiles), so ideally the task would only merge/modify the one profile not replace the entire list... But in many cases, replacing everything in the case of a dedicated workspace/product, is perfectly acceptable.... I'm not sure a bugzilla enhancement request is open yet, so please open one.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator