Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Compare » "Previous" and "Next" buttons in main toolbar do nothing?
"Previous" and "Next" buttons in main toolbar do nothing? [message #1747598] Wed, 16 November 2016 12:05 Go to next message
Conor O'Mahony is currently offline Conor O'MahonyFriend
Messages: 27
Registered: August 2016
Junior Member
Hi,

In the main eclipse toolbar, when there is a compare editor open, there are "Previous difference" and "Next difference" buttons.
When the default EMF compare viewer is open, these buttons do not navigate differences, except display "You have reached the first/last difference".

Is it intended that these should work with EMF compare?

(It looks like these are NavigationAction (from eclipse compare) that work by calling getNavigator() on the CompareEditorInput. I'm not sure how these actions would work though with EMF Compare viewer as there can be "Previous difference" and "Next Difference" buttons appearing in both the structure viewer and the content viewers, although I see that it could be useful to navigate the Structure Merge viewer?).

Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748055 is a reply to message #1747598] Fri, 18 November 2016 08:52 Go to previous messageGo to next message
Philip Langer is currently offline Philip LangerFriend
Messages: 83
Registered: March 2015
Location: Vienna, Austria
Member

Hi Conor,

thanks for the comment! You are right, these toolbar items don't work as expected. They seem to be contributed by eclipse.compare and don't seem to work properly with the EMF compare comparison viewer.

The Structure Merge Viewer of EMF Compare has a specific implementation for navigating through differences in its own toolbar. These specific next/previous diff actions work as expected. Maybe there is an easy way to integrate this functionality with the general eclipse.compare next/previous diff navigation actions.

Could you please open a bug report for this issue?

Thanks and best wishes,

Philip

--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/


--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/
Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748061 is a reply to message #1747598] Fri, 18 November 2016 09:41 Go to previous messageGo to next message
Laurent Goubet is currently offline Laurent GoubetFriend
Messages: 1857
Registered: July 2009
Senior Member
Hi,

These buttons work as expected on the tests I could do (for the structure viewer). About the content viewer ones, I believe they're only shown on textual viewers and should work as they do for regular text comparisons (although I couldn't test it since I don't have a model with large text differences). Could you provide us with a sample on which these actions do not work?

Laurent Goubet
Obeo
Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748112 is a reply to message #1748061] Fri, 18 November 2016 14:28 Go to previous messageGo to next message
Philip Langer is currently offline Philip LangerFriend
Messages: 83
Registered: March 2015
Location: Vienna, Austria
Member

Hi Laurent,

thanks for testing this! The _main toolbar_ buttons did work for you? How did they behave?

For me they just jump to the next file of the synchronization model (in the sync view) on and show the dialog that Conor mentioned on a second click, if there is no further file in the sync model, but they don't navigate within the SMV/CMV. They also don't work with text-diff CMV (comparing the XMI code).

I attached my test repo. Compare current state with head.

Thanks and best wishes,

Philip

--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/
  • Attachment: git.zip
    (Size: 215.27KB, Downloaded 65 times)


--
Philip Langer

Get professional Eclipse developer support:
http://eclipsesource.com/en/services/developer-support/
Re: "Previous" and "Next" buttons in main toolbar do nothing? [message #1748769 is a reply to message #1748112] Mon, 28 November 2016 14:02 Go to previous message
Conor O'Mahony is currently offline Conor O'MahonyFriend
Messages: 27
Registered: August 2016
Junior Member
Thanks Philip,

I have logged a defect here - https://bugs.eclipse.org/bugs/show_bug.cgi?id=508295
Previous Topic:Compare nodes by node name and an attribute
Next Topic:EMF Compare: Graphical comparison in GMF Editor
Goto Forum:
  


Current Time: Fri Jun 22 00:09:08 GMT 2018

Powered by FUDForum. Page generated in 0.01549 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top