Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » NatTable » 240 dpi not supported?(and possibly others dpi)
240 dpi not supported? [message #1731536] Fri, 06 May 2016 15:17 Go to next message
Oleksandr Zozulya is currently offline Oleksandr ZozulyaFriend
Messages: 15
Registered: December 2015
Junior Member
Hi, I just noticed that the images (and the table generally )are not scaled correctly for some dpi, like 240, which is a surprisingly common 2.5 x 96. The bug is easy to track down - in function GuiHelper.getDpiFactor(int dpi) only few scaling factors supported, 240 is _not_ one of them? Why not simply dividing getDpiX by 96.0 ?
Re: 240 dpi not supported? [message #1731545 is a reply to message #1731536] Fri, 06 May 2016 16:37 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2614
Registered: July 2012
Senior Member
Surprisingly common where? When I implemented it on Windows 7 that dpi where not supported. If you want to support that feel free to contribute.
Re: 240 dpi not supported? [message #1731809 is a reply to message #1731545] Tue, 10 May 2016 10:06 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2614
Registered: July 2012
Senior Member
I created a ticket [1] and provided a patch [2] at least for the scaling factors.

Please check and verify if that fits your needs. I currently don't have the time to provide icons for additional dpi so you will need to live with the upscaled ones for now or provide them via patch.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=462612
[2] https://git.eclipse.org/r/#/c/72387/
Re: 240 dpi not supported? [message #1731819 is a reply to message #1731809] Tue, 10 May 2016 11:24 Go to previous messageGo to next message
Oleksandr Zozulya is currently offline Oleksandr ZozulyaFriend
Messages: 15
Registered: December 2015
Junior Member
Yes, fantastic, thanks! Things change, 240 is quite common on modern laptops, because it's what hardware industry can now "easily" produce (e.g. macbook's ppi is 227) and Win10 OS often reports 240.
Re: 240 dpi not supported? [message #1732020 is a reply to message #1731819] Wed, 11 May 2016 21:28 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2614
Registered: July 2012
Senior Member
I pushed the changes to master in preparation for the 1.4.0 release. Please verify if it is now working as expected.
Re: 240 dpi not supported? [message #1732227 is a reply to message #1732020] Fri, 13 May 2016 14:21 Go to previous messageGo to next message
Oleksandr Zozulya is currently offline Oleksandr ZozulyaFriend
Messages: 15
Registered: December 2015
Junior Member
yes it works, I was also about to tell you that it shouldn't be downscaled ( mac os at reports 72 dpi), but you already fixed it in master.
Re: 240 dpi not supported? [message #1732464 is a reply to message #1732227] Tue, 17 May 2016 13:41 Go to previous messageGo to next message
Oleksandr Zozulya is currently offline Oleksandr ZozulyaFriend
Messages: 15
Registered: December 2015
Junior Member
Btw, just now I tried to compile with
mvn -f org.eclipse.nebula.widgets.nattable.parent/pom.xml install
which used to work 3 days ago, but now it fails with message:

[ERROR] Failed to resolve target definition nattable/nebula.widgets.nattable/target-platform/target-platform.target: Could not find "org.eclipse.sdk.ide/4.6.0.I20160317-0200" in the repositories of the current location -> [Help 1]

It looks like it cannot find the specified build, go figure...
I just deleted the version in target-platform.target and it picked up something.

Re: 240 dpi not supported? [message #1732476 is a reply to message #1732464] Tue, 17 May 2016 14:50 Go to previous message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 2614
Registered: July 2012
Senior Member
Yes I need to update the target platform for the latest Neon build. The integration builds vanish by the time.

We need the dependency to Neon because of issues with the CSS parsing that I have fixed in the platform. Thanks for the hint, I will update the target platform soon.
Previous Topic:IStructureSelection
Next Topic:Color of the text in the cell changes while scrolling the table
Goto Forum:
  


Current Time: Wed Sep 19 18:16:56 GMT 2018

Powered by FUDForum. Page generated in 0.01962 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top