Eclipse Community Forums: TMF (Xtext) » new formatting API and Xbase inherited grammar

Help

Home

Home » Modeling » TMF (Xtext) » new formatting API and Xbase inherited grammar

Show: Today's Messages :: Show Polls :: Message Navigator

new formatting API and Xbase inherited grammar [message #1707681]

Tue, 08 September 2015 13:30

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

Hi

in my DSL inheriting from Xbase I redefine the XCatchClause rule nothing
special:

XCatchClause :
=>'catch' '(' declaredParam=FullJvmFormalParameter ')'
expression=XBlockExpression;

instead of

XCatchClause :
=>'catch' '(' declaredParam=FullJvmFormalParameter ')'
expression=XExpression;

The new formatting API does not seem to work with catch clause: if you
consider this method in the XbaseFormatter

def dispatch void format(XCatchClause expr, extension
IFormattableDocument format) {

expr.regionForKeyword("catch").append(whitespaceBetweenKeywordAndParenthesisML)

regionForKeyword is not applied since this method returns null

@Override
public ISemanticRegion regionForKeyword(EObject owner, String keyword) {
AbstractEObjectTokens tokens = eObjectToTokens.get(owner);
if (tokens == null)
return null;
for (ISemanticRegion token : tokens.getTokens()) {
AbstractElement element = token.getGrammarElement();
if (element instanceof Keyword) {
Keyword kw = (Keyword) element;
if (kw.getValue().equals(keyword))
return token;
}
}
return null;
}

indeed there seem to be no token in the map associated to the
XCatchClause object...

am I missing something?

thanks in advance
Lorenzo

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book

HOME: http://www.lorenzobettini.it
TDD Book: https://leanpub.com/tdd-buildautomation-ci
Xtext Book: https://www.packtpub.com/application-development/implementing-domain-specific-languages-xtext-and-xtend-second-edition

Report message to a moderator

Re: new formatting API and Xbase inherited grammar [message #1707731 is a reply to message #1707681]

Tue, 08 September 2015 20:27

Christian Dietrich

Messages: 14665
Registered: July 2009

Senior Member

Hi the formatter is still buggy. Can you check if this one helps https://www.eclipse.org/forums/index.php/t/1068949/

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: new formatting API and Xbase inherited grammar [message #1707856 is a reply to message #1707731]

Wed, 09 September 2015 18:39

Lorenzo Bettini

Messages: 1812
Registered: July 2009
Location: Firenze, Italy

Senior Member

On 08/09/2015 22:27, Christian Dietrich wrote:
> Hi the formatter is still buggy. Can you check if this one helps
> https://www.eclipse.org/forums/index.php/t/1068949/

Hi

Yes, this fixes the problem:

XCatchClause :
{XCatchClause} =>'catch' '(' declaredParam=FullJvmFormalParameter ')'
expression=XBlockExpression;

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book

Report message to a moderator