Eclipse Community Forums: Eclipse SmartHome

Help

Home

Home » Archived » Eclipse SmartHome » REST / SSE Clazz type(Does it really need to be the full class name)

Show: Today's Messages :: Show Polls :: Message Navigator

REST / SSE Clazz type [message #1702056]

Sat, 18 July 2015 13:47

Chris Jackson

Messages: 256
Registered: December 2013

Senior Member

The recent change to the event system introduced the class name to the event, but it's the full class (ie org.eclipse.smarthome.core.library.types.DecimalType). Is this really necessary, or could we change this to the simple name (ie DecimalType)? It just seems neater to use the simple name since that's how it is referenced in the DSL type config files.

Chris

Report message to a moderator

Re: REST / SSE Clazz type [message #1702137 is a reply to message #1702056]

Mon, 20 July 2015 09:34

Kai Kreuzer

Messages: 673
Registered: December 2011

Senior Member

Can you provide a (code) reference as which event type you are referring to and where the FQDN appears?

Report message to a moderator

Re: REST / SSE Clazz type [message #1702141 is a reply to message #1702137]

Mon, 20 July 2015 09:47

Chris Jackson

Messages: 256
Registered: December 2013

Senior Member

I don't have the code as I've not looked through to find where the events are sent, but this occurs in the item state update messages (ie SSE).

Report message to a moderator

Re: REST / SSE Clazz type [message #1702144 is a reply to message #1702141]

Mon, 20 July 2015 10:03

Kai Kreuzer

Messages: 673
Registered: December 2011

Senior Member

I think I found it: https://github.com/eclipse/smarthome/blob/6da2cdc2772a9c53ac8040ca5669624c1f375c32/bundles/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/items/events/ItemEventFactory.java#L171

@Dennis: Is there any risk in changing this to the simple class name?

Report message to a moderator

Re: REST / SSE Clazz type [message #1702206 is a reply to message #1702144]

Mon, 20 July 2015 16:02

Dennis Nobel

Messages: 166
Registered: September 2014

Senior Member

It will not work if we change it. We use the className for recreating the command and state classes: https://github.com/eclipse/smarthome/blob/6da2cdc2772a9c53ac8040ca5669624c1f375c32/bundles/core/org.eclipse.smarthome.core/src/main/java/org/eclipse/smarthome/core/items/events/ItemEventFactory.java#L101

Report message to a moderator

Re: REST / SSE Clazz type [message #1702215 is a reply to message #1702206]

Mon, 20 July 2015 17:00

Kai Kreuzer

Messages: 673
Registered: December 2011

Senior Member

So we could assume that the type is always in the org.eclipse.smarthome.core.library.types package Smile

Report message to a moderator

Re: REST / SSE Clazz type [message #1702223 is a reply to message #1702215]

Mon, 20 July 2015 18:05

Dennis Nobel

Messages: 166
Registered: September 2014

Senior Member

Yes of course. But if we do so, it will not possible anymore to provide new item types - at least not with own commands or states. Because the types would not be deserializable from the event bus. In that case I would suggest to completely remove the possibility to implement an own ItemFactory.

Report message to a moderator

Re: REST / SSE Clazz type [message #1702424 is a reply to message #1702223]

Wed, 22 July 2015 09:25

Kai Kreuzer

Messages: 673
Registered: December 2011

Senior Member

Assuming you had a custom item type with custom state types defined in your own bundle - wouldn't this line in the code anyhow fail with a CNFE as it won't be available on the bundle classpath?

Report message to a moderator

Re: REST / SSE Clazz type [message #1702549 is a reply to message #1702424]

Thu, 23 July 2015 07:22

Dennis Nobel

Messages: 166
Registered: September 2014

Senior Member

Quote:

wouldn't this line in the code anyhow fail with a CNFE as it won't be available on the bundle classpath?

Yes you are right. So it is not extensible any more in any case. Well than we could change the event data to the simple class name and we should also change the event attribute "clazz" to "type".

Report message to a moderator