|
Re: Inbox concept [message #1643665 is a reply to message #1641585] |
Sun, 01 March 2015 17:59 |
Dennis Nobel Messages: 166 Registered: September 2014 |
Senior Member |
|
|
Hi Chris,
I don´t think that the inbox should be used for other purposes, than for findings things. Actually the whole concept and API is about finding and adding devices. If you use the inbox for notifications, what would happen, if someone wants to "approve" the entry? At the the moment the framework automatically calls the binding with a "createThing" call, which does not make sense. For example the Paper UI integrated the inbox inside the "Setup Wizard" for new devices. Moreover the DiscoveryService concept is hardly wired to the inbox concept, which again is about discovering things.
But the planned notification concept would definitely be the right place for any kind of notifications. The notification concept should have something like an "read/unread" status, so that the user interfaces can show only unread notifications and the user can cancel the notification. So it is similar to the inbox, in a way that it also tracks a list of notifications, that are persisted and can be accessed and not only an event mechanism.
Dennis
|
|
|
|
|
Re: Inbox concept [message #1645815 is a reply to message #1644981] |
Mon, 02 March 2015 18:05 |
Dennis Nobel Messages: 166 Registered: September 2014 |
Senior Member |
|
|
Kai, now I´m not sure if we have the same concept in mind, when we talk about the "Notification concept", especially when I read the bug.
For me the notification concept is something where different kinds of messages can be aggregated and stored. These messages may have a TTL, a severity, actions, "read" flag and so on. For example the framework can automatically create a notification, if a new thing is put into the inbox. It is comparable to the android notification concept for example. So it is a litte bit similar to the existing inbox, but only because it stores some entries, that must be acknowledged by the user. Maybe the interface "Inbox" is a bit confusing, it should better be "ThingInbox", but at least from the package "org.eclipse.smarthome.config.discovery" it can be seen that is for discovering things and not a general inbox for messages.
The notification concept, which is mentioned in https://bugs.eclipse.org/bugs/show_bug.cgi?id=434010 is more about how notifications/messages are transported and visualized to the user. I´m not sure if this is the same concept. Of course they belong somehow together. But I would assume that this is another SPI, where different implementation can be used (E-Mail, Android Push Cloud, Twitter etc.). In contrast the "NotificationInbox", which stores messages has only one implementation.
Regards
Dennis
[Updated on: Mon, 02 March 2015 18:06] Report message to a moderator
|
|
|
|
Powered by
FUDForum. Page generated in 0.02821 seconds