Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit / JGit » Show Annotations does not work anymore
Show Annotations does not work anymore [message #1634792] Wed, 25 February 2015 13:01 Go to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6682
Registered: July 2009
Senior Member
Hi,

I think it doesn't work anymore since Mars M5 or so. It does just nothing anymore. Is that a known regression or is
there some new option that I must set?

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper


Re: Show Annotations does not work anymore [message #1634843 is a reply to message #1634792] Wed, 25 February 2015 13:37 Go to previous messageGo to next message
Matthias Sohn is currently offline Matthias SohnFriend
Messages: 1268
Registered: July 2009
Senior Member
works for me on Mars M5 using latest 3.7 from http://download.eclipse.org/egit/updates-stable-nightly
Re: Show Annotations does not work anymore [message #1635111 is a reply to message #1634843] Wed, 25 February 2015 16:24 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6682
Registered: July 2009
Senior Member
Am 25.02.2015 um 14:37 schrieb Matthias Sohn:
> works for me on Mars M5 using latest 3.7 from http://download.eclipse.org/egit/updates-stable-nightly
I have version 3.7.0.201502031740-rc1 installed and there it definitely doesn't work. Any idea what else might cause
this? Or where I could set a break point to debug it?

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper


Re: Show Annotations does not work anymore [message #1635458 is a reply to message #1635111] Wed, 25 February 2015 20:19 Go to previous messageGo to next message
Matthias Sohn is currently offline Matthias SohnFriend
Messages: 1268
Registered: July 2009
Senior Member
set a breakpoint in org.eclipse.egit.ui.internal.blame.BlameOperation.execute()
and in org.eclipse.jgit.api.BlameCommand.call()
Re: Show Annotations does not work anymore [message #1636292 is a reply to message #1635458] Thu, 26 February 2015 05:50 Go to previous messageGo to next message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6682
Registered: July 2009
Senior Member
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Am 25.02.2015 um 21:19 schrieb Matthias Sohn:<br>
<blockquote cite="mid:mclao9$vms$1@xxxxxxxxe.org" type="cite">set
a breakpoint in
org.eclipse.egit.ui.internal.blame.BlameOperation.execute()
<br>
and in org.eclipse.jgit.api.BlameCommand.call()
<br>
</blockquote>
<br>
Ok, I could track it down to a NullPointerException in
WorkbenchPage.showPart():<br>
<br>
    private MPart showPart(int mode, MPart part) {<br>
        switch (mode) {<br>
        case VIEW_ACTIVATE:<br>
        ...<br>
         case VIEW_VISIBLE:<br>
            MPart activePart = partService.getActivePart();<br>
            if (activePart == null) {<br>
                ...<br>
            } else {<br>
                part = ((PartServiceImpl)
partService).addPart(part);<br>
                MPlaceholder activePlaceholder =
activePart.getCurSharedRef();<br>
                MUIElement activePartParent = activePlaceholder ==
null ? activePart<br>
                        .getParent() :
activePlaceholder.getParent();<br>
                partService.showPart(part, PartState.CREATE);<br>
                if (<font color="#ff0000"><b>part.getCurSharedRef()</b></font>.getParent()
!= activePartParent) {<br>
                    partService.bringToTop(part);<br>
                }<br>
            }<br>
            break;<br>
<br>
The part is the History view and its getCurSharedRef() method
returns null:<br>
<br>
java.lang.NullPointerException<br>
    at
org.eclipse.ui.internal.WorkbenchPage.showPart(WorkbenchPage.java:1289)<br>
    at
org.eclipse.ui.internal.WorkbenchPage.busyShowView(WorkbenchPage.java:1260)<br>
    at
org.eclipse.ui.internal.WorkbenchPage$11.run(WorkbenchPage.java:4100)<br>
    at
org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)<br>
    at
org.eclipse.ui.internal.WorkbenchPage.showView(WorkbenchPage.java:4096)<br>
    at
org.eclipse.egit.ui.internal.blame.BlameOperation.openEditor(BlameOperation.java:290)<br>
    at
org.eclipse.egit.ui.internal.blame.BlameOperation.access$0(BlameOperation.java:271)<br>
    at
org.eclipse.egit.ui.internal.blame.BlameOperation$1.run(BlameOperation.java:266)<br>
    at
org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)<br>
    at
org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)<br>
    ... 24 more<br>
<br>
The org.eclipse.ui.workbench plugin has the version
3.107.0.v20150127-1326. It's strange that the problem does not
happen in another IDE with the identical workbench version. The two
IDE differ in their EGit versions, though:<br>
<br>
    EGit 3.7.0.201502040827         (Good IDE)<br>
    EGit 3.7.0.201502031740-rc1  (Bad IDE)<br>
<br>
Cheers<br>
/Eike<br>
<br>
----<br>
<a class="moz-txt-link-freetext" href="http://www.esc-net.de">http://www.esc-net.de</a><br>
<a class="moz-txt-link-freetext" href="http://thegordian.blogspot.com">http://thegordian.blogspot.com</a><br>
<a class="moz-txt-link-freetext" href="http://twitter.com/eikestepper">http://twitter.com/eikestepper</a><br>
<br>
<br>
<br>
</body>
</html>


Re: Show Annotations does not work anymore [SOLVED] [message #1636481 is a reply to message #1636292] Thu, 26 February 2015 07:55 Go to previous message
Eike Stepper is currently offline Eike StepperFriend
Messages: 6682
Registered: July 2009
Senior Member
I found the problem:

EGit is mostly likely not related at all. Something in my perspective (the WorkbenchPage) was not okay. When I closed
the Java perspective and reopened it the problem did not occur anymore.

Sorry for the noise!

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper


Previous Topic:Indexing gen folder
Next Topic:What part of updates do I need to install?
Goto Forum:
  


Current Time: Fri Apr 19 10:57:45 GMT 2024

Powered by FUDForum. Page generated in 0.02018 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top