Eclipse Community Forums - RDF feed
https://www.eclipse.org/forums/
Eclipse Community ForumsEmpty password
https://www.eclipse.org/forums/index.php/mv/msg/19183/61598/#msg_61598
Originally posted by: morten.hindsholm.dk
I am developing a connector, and I think I might have spotted a minor bug.
My backend requires a login, but it is legal to have an empty password.
However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks -
via the private method isMissingCredentials() - against empty passwords.
This means that I cannot easily implement isPageComplete() in my
RepositorySettings class which extends AbstractRepositorySettingsPage, because
I cannot call super.isPageComplete() with an empty password, and I also cannot
bypass AbstractRepositorySettingsPage and call isPageComplete() in its
superclass AbstractTaskRepositoryPage. If you understand...
I think a reasonable fix would be to make
AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
private.
> I am developing a connector, and I think I might have spotted a minor bug.
>
> My backend requires a login, but it is legal to have an empty password.
>
> However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks
> - via the private method isMissingCredentials() - against empty passwords.
>
> This means that I cannot easily implement isPageComplete() in my
> RepositorySettings class which extends AbstractRepositorySettingsPage,
> because I cannot call super.isPageComplete() with an empty password, and I
> also cannot bypass AbstractRepositorySettingsPage and call
> isPageComplete() in its superclass AbstractTaskRepositoryPage. If you
> understand...
>
> I think a reasonable fix would be to make
> AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
> private.
>]]>Steffen Pingel2008-11-11T20:56:37-00:00Re: Empty password
https://www.eclipse.org/forums/index.php/mv/msg/19183/61657/#msg_61657
http://eclipse.org/mylyn/
Thanks.
Steffen
Morten Hindsholm wrote:
> I am developing a connector, and I think I might have spotted a minor bug.
>
> My backend requires a login, but it is legal to have an empty password.
>
> However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks
> - via the private method isMissingCredentials() - against empty passwords.
>
> This means that I cannot easily implement isPageComplete() in my
> RepositorySettings class which extends AbstractRepositorySettingsPage,
> because I cannot call super.isPageComplete() with an empty password, and I
> also cannot bypass AbstractRepositorySettingsPage and call
> isPageComplete() in its superclass AbstractTaskRepositoryPage. If you
> understand...
>
> I think a reasonable fix would be to make
> AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
> private.
>]]>Steffen Pingel2008-11-11T20:56:37-00:00Re: Empty password
https://www.eclipse.org/forums/index.php/mv/msg/19183/594778/#msg_594778
steffen.pingel@tasktop.com> writes:
> Please file a new bug to request this API enhancement:
>
> http://eclipse.org/mylyn/
Bug #255003 filed.
> Thanks.
You're welcome :-)
>
> Steffen
>
>
> Morten Hindsholm wrote:
>
>> I am developing a connector, and I think I might have spotted a minor bug.
>>
>> My backend requires a login, but it is legal to have an empty password.
>>
>> However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks
>> - via the private method isMissingCredentials() - against empty passwords.
>>
>> This means that I cannot easily implement isPageComplete() in my
>> RepositorySettings class which extends AbstractRepositorySettingsPage,
>> because I cannot call super.isPageComplete() with an empty password, and I
>> also cannot bypass AbstractRepositorySettingsPage and call
>> isPageComplete() in its superclass AbstractTaskRepositoryPage. If you
>> understand...
>>
>> I think a reasonable fix would be to make
>> AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
>> private.
>>
>
--
/\/\orten]]>Morten Hindsholm2008-11-12T10:04:29-00:00Re: Empty password
https://www.eclipse.org/forums/index.php/mv/msg/19183/61681/#msg_61681
Originally posted by: morten.hindsholm.dk
>
> Steffen
>
>
> Morten Hindsholm wrote:
>
>> I am developing a connector, and I think I might have spotted a minor bug.
>>
>> My backend requires a login, but it is legal to have an empty password.
>>
>> However, AbstractRepositorySettingsPage.isPageComplete() explicitly checks
>> - via the private method isMissingCredentials() - against empty passwords.
>>
>> This means that I cannot easily implement isPageComplete() in my
>> RepositorySettings class which extends AbstractRepositorySettingsPage,
>> because I cannot call super.isPageComplete() with an empty password, and I
>> also cannot bypass AbstractRepositorySettingsPage and call
>> isPageComplete() in its superclass AbstractTaskRepositoryPage. If you
>> understand...
>>
>> I think a reasonable fix would be to make
>> AbstractRepositorySettingsPage.isMissingCredentials() protected instead of
>> private.
>>
>