Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-text-dev] [platform-ui-dev] [proposal] Unite platform text and UI projects forces

Hi Stefan,

I can follow some of your arguments and those from others, but at the moment I'd really prefer to add seriously interested people to Platform Text rather than merge the sub-project into Platform UI and give over 20 people access to that code. The same arguments for merging could be brought up for other Platform sub-projects. Maybe in the end merging everything will be the final answer. However, the drawback is that we loose the publicly declared leadership for those sub-projects and persons being accountable for that code when we merge everything into one pot.

I will bring this into the PMC for discussion and let you all know of the outcome.

Thanks,
Dani



From:        Stefan Xenos <sxenos@xxxxxxxxxx>
To:        "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>, Eclipse Platform Text component developers list <platform-text-dev@xxxxxxxxxxx>
Date:        09.10.2015 14:58
Subject:        Re: [platform-ui-dev] [proposal] Unite platform text and UI        projects forces
Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx




+1 from me for the merge. To be honest, I was about to propose the same thing. The high segregation of Eclipse projects makes it hard to perform large-scale cleanup (deal with deprecations, fix formatting, update copyright headers, etc.).

Platform text is such a small project that it would take a long time for any one UI committer to build up enough patches to get nominated for commit rights, but it's a very important one... and having so few committers on it creates an unnecessary bottleneck. Most of the patterns used in platform text are familiar to other UI developers who have worked on concrete text editors, so there would be many people qualified to write good bugfixes when they come up.

The current platform text committers will still be the platform text experts and would be consulted on any design change. The difference would be that they would no longer need to be involved in the "context-free" changes that make up a large portion of contributions to platform text. This would reduce the workload for the current text committers and would reduce the time that such changes need to wait in the queue.

  - Stefan

On Fri, Oct 9, 2015 at 5:10 AM Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
Hi Andrey

I know your patch is waiting, sorry, it's on my list to be done after the zoom patch.


-1 from me for the merge. I haven't seen many Text related contributions form Platform UI committers that would justify giving access to all Platform UI committers. Changes that are of Text context-free related changes (remove comments, change BREE, etc.) are not Platform Text specific. Having said that, if there are Platform UI committers - or any other contributors - that provide further contributions, or good code reviews over the next time, then I'd be very happy to welcome them as new committers on Platform Text.


Dani




From:        
Andrey Loskutov <loskutov@xxxxxx>
To:        
platform-text-dev@xxxxxxxxxxx, platform-ui-dev@xxxxxxxxxxx
Date:        
09.10.2015 13:56
Subject:        
[platform-ui-dev] [proposal] Unite platform text and UI projects        forces
Sent by:        
platform-ui-dev-bounces@xxxxxxxxxxx




Hi all,

Recently I was trying to update the platform text projects to BREE 1.7
to get rid of nasty compile problems with incompatible JRE (platform
text still insists to see JRE 1.4 on classpath), see [1], but so far it
didn't found any feedback except the one non-text committer (it was Lars
as usually :-)).

This does not surprise me, especially looking on the project statistics
[2] where one can see that there are actually only 2 active committers
with commit rights on the platform text (Dani and Markus), and the 2
commits which were made from non-project contributors are representing
9% of the project activity in the last 3 months! BTW both those
"external" 2 commits were made by platform UI committers.

So while we all know how overloaded both active platform text committers
are, and how bad our overall state with reviewing bugs and patches etc
is, why not unite our forces and integrate platform text into platform
UI project? Those two projects have really many things in common and it
feels naturally for me if we could allow both teams to work on their
code together. Actually the half of platform text committers are already
platform UI committers, but unfortunately not other way around.

So what do you think?
Does this proposal makes sense for you?

Are platform UI committer ready to take over few projects from platform
text? Are platform text committers agree to give platform UI members
commit rights on platform text and vice versa?

Few data about projects in platform text: 6 projects (without tests),
~1200 files, 4 committers (2 active):

org.eclipse.core.filebuffers
org.eclipse.jface.text
org.eclipse.search
org.eclipse.text
org.eclipse.ui.editors
org.eclipse.ui.workbench.texteditor

For comparison: Platform UI: 38 projects (without tests), ~5200 files,
25 committers (although I guess only half of them are active).

[1]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478673
[2]
https://projects.eclipse.org/projects/eclipse.platform.text/who

--
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
_______________________________________________
platform-ui-dev mailing list

platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


_______________________________________________
platform-ui-dev mailing list

platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/platform-ui-dev_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

Back to the top