Re: [aspectj-dev] Legal requirement question

[Andy Clement <andrew.clement@xxxxxxxxx>]

I wouldn't take a modified jar. I would take a simple patch attached to an issue if you have signed the Eclipse contributors agreement (and it looks like you have on the bugzilla). However, I won't change HashMap to WeakHashMap as there are reasons why it is a weakhashmap. I'd rather get to the root of the problem but i know recreation steps when that data structure is involved are challenging.The discussion reminded me of https://bugs.eclipse.org/bugs/show_bug.cgi?id=550705 which was a very cryptic issue that eventually got fixed by the community and was related to the management of the type maps. But I guess if you have seen your problem on 1.9.6 then that isn't the fix you needed.

Being pragmatic, given the complexity around a testcase, I *might* take a patch that switched the choice of map based on a property, since you don't seem to mind it not being a weakhashmap in your setup. Then you could set it but by default everyone else would get a WeakHashMap.

cheers,

Andy

On Tue, 18 May 2021 at 03:43, Szalkai, Gabor via aspectj-dev <aspectj-dev@xxxxxxxxxxx> wrote:

Hi!

 

I would like to enquiry about legal requirements like whether it is enough to send you the modified jar here on the bug ticket?

 

Attachment can be found in https://bugs.eclipse.org/bugs/show_bug.cgi?id=534755#c7.

 

 

If it is inevitable to do changes here https://git.eclipse.org/c/ajdt/org.eclipse.ajdt.git/a, then I only have to push my changes to branch to be legally ok?

Looking forward to hearing from you.

 

Kind regards,

Gabor Szalkai

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/aspectj-dev