Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » NatTable » Major refactoring for edit behaviour
Major refactoring for edit behaviour [message #1005840] Mon, 28 January 2013 23:19 Go to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 1405
Registered: July 2012
Senior Member
Hi everybody,

the last few days I worked on refactoring the architecture of editing in NatTable. While doing this I realized that there
is need to change several things, so I fixed several bugs and added some enhancements, refactoring quite a few. As these changes can
not be separated to be committed for atomic bug/enhancement description, I decided to create a bug that summarizes all the
changes, connecting the commit to. I also created bugs for every single bugfix/enhancement to keep track about the
changes in detail.

This is the bug for collecting all changes:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399313

The following are the bugs/enhancements that are related to the edit refactoring:

Add dialog that supports increment/decrement on multi edit
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379891

Performing tick updates does not validate the value after processing
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399322

Performing tick update on non double values will cause exception
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399323

Allow configuration for NatCombo to allow editing the text control for adding values outside the specified items
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379955

Support multi select in NatCombo
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399316

Make icon of ComboBoxCellEditor and ComboBoxCellPainter configurable
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399317

PasswordCellEditor allows to copy the value
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399325

Add multi line text editor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399338

Refactoring of ICellEditor interface
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399326

Opening cell editors always in a subdialog
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399327

Open adjacent editor after commit succeeded and the selection moves (e.g. pressing TAB in an open editor)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=379956

Refactoring of ActiveCellEditor (unfortunately not fixed but refactored)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=392535

Allow commiting of values by skipping validation
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398357

Refactoring of ICellEditHandler for clear processes and API
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399328

Add support for dialog only editors that wrap SWT or JFace dialogs
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399329

Allow value change of CheckboxCellEditor on pressing Space
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399330

Allow configuration of error rendering style in TextCellEditor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399332

Improved KeyMatcher for activating a cell by keypress
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399333

Wrong implementation of equals() and hashCode() for LetterOrDigitKeyEventMatcher
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399334

Improve registering of ICellEditors in UIBindingRegistry
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399335


The only changes that should affect users of the NatTable are related to create custom editors. If you didn't customize
behaviour there, you shouldn't realize these changes.

You will also find a new EditorExample in the examples project, showing the usage of editors in various configurations.

As these changes are really ground breaking, we need your help in evaluating if everything is still working. The test cases are running without issues and the EditorExample does work really stable. But further testing from different parties is always a good idea.

Thanks for help and comments on this refactoring. We hope you like the changes, even if it means you need to adjust some of your code.

Greez,
Dirk
Re: Major refactoring for edit behaviour [message #1006149 is a reply to message #1005840] Wed, 30 January 2013 09:05 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 1405
Registered: July 2012
Senior Member
The following bugs/enhancements where reported regarding the edit refactoring and have already been fixed in master:

It is not possible to deselect all items in a multi select combo
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399387

NullPointerException if key is pressed on a NatTable without selection
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399393

FocusListener issues on Mac OS
https://bugs.eclipse.org/bugs/show_bug.cgi?id=399461
Re: Major refactoring for edit behaviour [message #1009119 is a reply to message #1006149] Thu, 14 February 2013 13:28 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 1405
Registered: July 2012
Senior Member
Add support for custom configuration of (multi) cell edit dialogs
https://bugs.eclipse.org/bugs/show_bug.cgi?id=400808
Re: Major refactoring for edit behaviour [message #1015728 is a reply to message #1009119] Fri, 01 March 2013 22:47 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 1405
Registered: July 2012
Senior Member
Add support for cross validation
https://bugs.eclipse.org/bugs/show_bug.cgi?id=402193

How to use this is also described in this blog post:
http://www.vogella.com/blog/2013/03/02/crossweak-validation-in-nattable-by-dirk-fauth/
Re: Major refactoring for edit behaviour [message #1015935 is a reply to message #1015728] Mon, 04 March 2013 10:12 Go to previous messageGo to next message
Dirk Fauth is currently offline Dirk FauthFriend
Messages: 1405
Registered: July 2012
Senior Member
Provide convenience methods to request the row/column index/position from the current active cell editor
https://bugs.eclipse.org/bugs/show_bug.cgi?id=402284
Re: Major refactoring for edit behaviour [message #1020573 is a reply to message #1015935] Mon, 18 March 2013 13:41 Go to previous message
Renso Lohuis is currently offline Renso LohuisFriend
Messages: 44
Registered: July 2012
Member
Wow. A lot of changes. Looking good. Can't wait to try it out, once 1.0 is released.

I just found another bug in 0.9 regarding editing:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=403630

Do you know if it still there in 1.0 or that is fixed by the refactoring?
Previous Topic:Auto resize column does not always work correctly
Next Topic:Bug in VerticalTextPainter.paintCell()
Goto Forum:
  


Current Time: Sun Nov 23 17:37:56 GMT 2014

Powered by FUDForum. Page generated in 0.02609 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software