Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit » Delete Added Line fails to delete LF at end of file
Delete Added Line fails to delete LF at end of file [message #991489] Wed, 19 December 2012 08:20 Go to next message
R Shapiro is currently offline R Shapiro
Messages: 386
Registered: June 2011
Senior Member
In EGit 2.2.0.201212162313 + Juno SR1 I now see the following anomaly:

1) In any text file, add a new line at the end. The content doesn't matter.
2) Save the change. Observe that the file now has an unstaged change, as expected.
3) In the left margin right-click menu of that line, choose 'Delete Added Line'.
4) Observe that that file is marked as modified and that the content of line is gone, as expected. Save the change.
5) Observe that the file is still considered to have an unstaged change and appears to have an empty line at the end. In short, the content of the new line was deleted but the line-feed was not.
Expected: line-feed should have been removed and the file should no longer have unstaged changes.

Note that this problem is very specific to the last line in the file-- anywhere else Deleted Added Line deletes the line-feed along with the contents (if any)

Update: Looks now like this is probably a Quick Diff bug rather than an EGit bug.

[Updated on: Sun, 23 December 2012 09:06]

Report message to a moderator

Re: Delete Added Line fails to delete LF at end of file [message #992748 is a reply to message #991489] Sat, 22 December 2012 08:51 Go to previous messageGo to next message
R Shapiro is currently offline R Shapiro
Messages: 386
Registered: June 2011
Senior Member
Filed as bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=397113
Re: Delete Added Line fails to delete LF at end of file [message #992755 is a reply to message #992748] Sat, 22 December 2012 09:16 Go to previous message
R Shapiro is currently offline R Shapiro
Messages: 386
Registered: June 2011
Senior Member
If you're not seeing 'Deleted Added Line', you don't have EGit quick-diff enabled. But surely everyone uses quick-diff?
Previous Topic:Egit well installed, but no GIT menu
Next Topic:Problem when merging
Goto Forum:
  


Current Time: Wed Aug 20 18:34:40 EDT 2014

Powered by FUDForum. Page generated in 0.01780 seconds