| Question regarding ServiceSelector Filter mechanism [message #114815] |
Mon, 21 July 2008 07:41  |
|
Originally posted by: fappel.innoopract.com
This is a multi-part message in MIME format.
------=_NextPart_000_0076_01C8EB37.A59456F0
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Hi,
doing a follow up on a RAP user complaint regarding that the eclipse
help doesn't work with RAP anymore I came across the ServiceSelector
filter mechanism (bug 158168
<https://bugs.eclipse.org/bugs/show_bug.cgi?id=158168> ). It took me a
while to figure out that using
'-Dorg.eclipse.equinox.http.jetty.other.info=org.eclipse.hel p' as VM
argument revives the help system.
Unfortunately RAP applications are most often not deployed using OSGi
standalone with the Jetty engine as HttpService provider, they run
embedded in the various available servlet container implementations. So
what I couldn't figure out is what I have to do to bring the help system
back to work in those scenarios (e.g running in tomcat). My hope is that
users don't have to configure a different startup parameter for each
container implementation, since this will cause us user-acceptance
problems. Anyway it would be nice if somebody could point me to more
detailed information or solution regarding this problem.
By the way something that I couldn't understand properly by reading the
bug, is why this functionality was introduced the first time, since it
was stated by Simon that ' its quite rare to run more than one
HttpService in a single VM'. So I'm wondering if there was a real
usecase where the previous situation actually caused problems.
Ciao
Frank
------=_NextPart_000_0076_01C8EB37.A59456F0
Content-Type: text/html;
charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml" =
xmlns:o=3D"urn:schemas-microsoft-com:office:office" =
xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" =
xmlns=3D"http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3DContent-Type content=3D"text/html; =
charset=3Dus-ascii">
<meta name=3DGenerator content=3D"Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Vorformatiert Zchn";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.E-MailFormatvorlage17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLVorformatiertZchn
{mso-style-name:"HTML Vorformatiert Zchn";
mso-style-priority:99;
mso-style-link:"HTML Vorformatiert";
font-family:"Courier New";}
..MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3DDE link=3Dblue vlink=3Dpurple>
<div class=3DSection1>
<p class=3DMsoNormal>Hi,<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>doing a follow up on a RAP user complaint regarding =
that the
eclipse help doesn't work with RAP anymore I came across the =
ServiceSelector
filter mechanism (bug <a
href=3D"https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D158168">158168</a=
>). It
took me a while to figure out that using =
'-Dorg.eclipse.equinox.http.jetty.other.info=3Dorg.eclipse.h elp'
as VM argument revives the help system.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Unfortunately RAP applications are most often not =
deployed using
OSGi standalone with the Jetty engine as HttpService provider, they run
embedded in the various available servlet container implementations. So =
what I
couldn't figure out is what I have to do to bring the help system back =
to work
in those scenarios (e.g running in tomcat). My hope is that users don't =
have to
configure a different startup parameter for each container =
implementation,
since this will cause us user-acceptance problems. Anyway it would be =
nice if somebody
could point me to more detailed information or solution regarding this =
problem.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<pre><span =
style=3D'font-size:11.0pt;font-family:"Calibri","sans-serif "'>By the way =
something that I couldn't understand properly by reading the bug, is why =
this functionality was introduced the first time, since it was stated by =
Simon that ' its quite rare to run more than one HttpService in a single =
VM'. So I'm wondering if there was a real usecase where the =
previous situation actually caused problems.<o:p></o:p></span></pre>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Ciao<o:p></o:p></p>
<p class=3DMsoNormal>Frank<o:p></o:p></p>
</div>
</body>
</html>
------=_NextPart_000_0076_01C8EB37.A59456F0--
|
|
|
|
| Re: Question regarding ServiceSelector Filter mechanism [message #114987 is a reply to message #114853] |
Tue, 22 July 2008 05:01   |
|
Originally posted by: fappel.innoopract.com
Hm,
I think you have a valid use case, but our end user's use case is as
valid as the one that you describe. So the filter approach solves one
problem by bringing in a problem that didn't exist before. To me it
seems not a good strategy to make the usage of Equinox on the serverside
more popular by suggesting to our users to patch bundles to solve such
problems.
I would prefer an approach e.g. that allows to declare such filters
independently from the servlet/resources registration. This would solve
the problem you describe and still allows people to use the help.webapp
bundle.
Ciao
Frank
-----Ursprüngliche Nachricht-----
Von: Gunnar Wagenknecht [mailto:gunnar@wagenknecht.org]
Bereitgestellt: Montag, 21. Juli 2008 17:48
Bereitgestellt in: eclipse.technology.equinox
Unterhaltung: Question regarding ServiceSelector Filter mechanism
Betreff: Re: Question regarding ServiceSelector Filter mechanism
Hi Frank,
Frank Appel schrieb:
> problems. Anyway it would be nice if somebody could point me to more
> detailed information or solution regarding this problem.
I'm afraid you need to patch the help plug-in to register with *any*
HttpService available (or use an alternate filter if necessary).
> By the way something that I couldn't understand properly by reading
> the bug, is why this functionality was introduced the first time,
> since it was stated by Simon that ' its quite rare to run more than
> one HttpService in a single VM'. So I'm wondering if there was a
> real usecase where the previous situation actually caused problems.
I can't comment on why it was introduced the first time. However, I have
a use case. I'm developing a platform which provides multiple
HttpService instances. One is for "public" stuff and the other for
"admin" stuff. Think of it as an admin/system back office which - in
addition to being password protected - must also be hidden from the
public port.
Yet another use case might be virtual hosting or SSL sites. Some content
should only be available over an SSL connection.
FWIW, I actually patched RAP to only register with a specific service
instance. This works well for the actual servlet but not for the
resources.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=241210
-Gunnar
--
Gunnar Wagenknecht
gunnar@wagenknecht.org
http://wagenknecht.org/
|
|
|
|
| Re: Question regarding ServiceSelector Filter mechanism [message #115080 is a reply to message #115050] |
Wed, 23 July 2008 03:54   |
|
Originally posted by: fappel.innoopract.com
-----Ursprüngliche Nachricht-----
Von: Gunnar Wagenknecht [mailto:gunnar@wagenknecht.org]
Bereitgestellt: Dienstag, 22. Juli 2008 19:46
Bereitgestellt in: eclipse.technology.equinox
Unterhaltung: Question regarding ServiceSelector Filter mechanism
Betreff: Re: Question regarding ServiceSelector Filter mechanism
Frank Appel schrieb:
> I would prefer an approach e.g. that allows to declare such filters
> independently from the servlet/resources registration. This would
solve
> the problem you describe and still allows people to use the
help.webapp
> bundle.
Hehe, by "patching" I mean providing a patch attached to Bugzilla which
could be integrated into a following release. ;)
-Gunnar
--
Gunnar Wagenknecht
gunnar@wagenknecht.org
http://wagenknecht.org/
|
|
|
| Re: Question regarding ServiceSelector Filter mechanism [message #115092 is a reply to message #115050] |
Wed, 23 July 2008 03:56   |
|
Originally posted by: fappel.innoopract.com
Hi,
sorry for the misunderstanding...I'll see if I found something usefull.
Ciao
Frank
-----Ursprüngliche Nachricht-----
Von: Gunnar Wagenknecht [mailto:gunnar@wagenknecht.org]
Bereitgestellt: Dienstag, 22. Juli 2008 19:46
Bereitgestellt in: eclipse.technology.equinox
Unterhaltung: Question regarding ServiceSelector Filter mechanism
Betreff: Re: Question regarding ServiceSelector Filter mechanism
Frank Appel schrieb:
> I would prefer an approach e.g. that allows to declare such filters
> independently from the servlet/resources registration. This would
solve
> the problem you describe and still allows people to use the
help.webapp
> bundle.
Hehe, by "patching" I mean providing a patch attached to Bugzilla which
could be integrated into a following release. ;)
-Gunnar
--
Gunnar Wagenknecht
gunnar@wagenknecht.org
http://wagenknecht.org/
|
|
|
|
| Re: Question regarding ServiceSelector Filter mechanism [message #115291 is a reply to message #115132] |
Fri, 25 July 2008 03:52   |
|
Originally posted by: fappel.innoopract.com
Hi Gunnar,
thanks for your thoughts on this. I didn't made up my mind yet how to
handle this. But I'm not lucky how this filter mechanism is working. In
my opinion those filters should not be set by the plug-in developer like
it happens in the webapp plug-in. This should be done by the one who
knows about the target system. I mean someone like that person who
creates a product. He is the one how can decide things like "ok I have
two http services instances and I map servlet x to service httpservice
one and servlet y to service two".
Ciao
Frank
-----Ursprüngliche Nachricht-----
Von: Gunnar Wagenknecht [mailto:gunnar@wagenknecht.org]
Bereitgestellt: Mittwoch, 23. Juli 2008 20:50
Bereitgestellt in: eclipse.technology.equinox
Unterhaltung: Question regarding ServiceSelector Filter mechanism
Betreff: Re: Question regarding ServiceSelector Filter mechanism
Frank Appel schrieb:
> sorry for the misunderstanding...I'll see if I found something
usefull.
Hmm... unfortunately, the service selector is introduced via plugin.xml.
Thus, the only way will be to use product customization via XSLT
transformation of the extension registry.
http://wiki.eclipse.org/Product_Customization
http://wiki.eclipse.org/Equinox_Transforms
Ideally, it would be configurable in the help webapp plug-in. The
plug-in would check a configuration property if the service selector
should be used or not. But I don't see a way to pass that to the
extension registry from outside other than the concept mentioned above.
-Gunnar
--
Gunnar Wagenknecht
gunnar@wagenknecht.org
http://wagenknecht.org/
|
|
|
|
| Re: Question regarding ServiceSelector Filter mechanism [message #115356 is a reply to message #115343] |
Fri, 25 July 2008 06:52  |
|
Originally posted by: fappel.innoopract.com
Hi again,
> The problem with the serviceSelector element is that it leaks runtime
environment specifics into development.
that's the precise phrase I was looking for :-)
Thanks for the bundle, I will check it out.
Ciao
Frank
-----Ursprüngliche Nachricht-----
Von: Gunnar Wagenknecht [mailto:gunnar@wagenknecht.org]
Bereitgestellt: Freitag, 25. Juli 2008 12:16
Bereitgestellt in: eclipse.technology.equinox
Unterhaltung: Question regarding ServiceSelector Filter mechanism
Betreff: Re: Question regarding ServiceSelector Filter mechanism
Frank Appel schrieb:
> In my opinion those filters should not be set by the plug-in developer
> like it happens in the webapp plug-in. This should be done by the one
> who knows about the target system. I mean someone like that person who
> creates a product.
Yupp, I agree. There should be a "default" which can be overwritten by
product creators.
The problem with the serviceSelector element is that it leaks runtime
environment specifics into development.
FWIW, I've opend bug 239555 which patches the HTTP registry to limit the
service it registers with (mainly for security reasons). But this is not
really related to the HELP case. I think that the HELP WebApp developers
wanted to be good citizens. The HELP plug-in starts it's own service on
a random port only for the purpose to run the help content on it. Thus,
the usage of the serviceSelector is reasonable.
But did you know that there is any easy workaround? Simply deploy the
attached bundle and it will register the help content without any
serviceSelector. :)
-Gunnar
--
Gunnar Wagenknecht
gunnar@wagenknecht.org
http://wagenknecht.org/
|
|
|
Powered by
FUDForum. Page generated in 0.01857 seconds